From: Kim Phillips <kim.phillips@amd.com>
To: <kvm@vger.kernel.org>, <linux-coco@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>,
Ashish Kalra <ashish.kalra@amd.com>,
"Nikunj A . Dadhania" <nikunj@amd.com>,
Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>,
"Naveen N Rao" <naveen@kernel.org>,
Alexey Kardashevskiy <aik@amd.com>,
"Borislav Petkov" <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Sean Christopherson" <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v5 0/2] KVM: SEV: Add support for the ALLOWED_SEV_FEATURES feature
Date: Mon, 10 Mar 2025 15:16:01 -0500 [thread overview]
Message-ID: <20250310201603.1217954-1-kim.phillips@amd.com> (raw)
AMD EPYC 5th generation processors have introduced a feature that allows
the hypervisor to control the SEV_FEATURES that are set for, or by, a
guest [1]. ALLOWED_SEV_FEATURES can be used by the hypervisor to enforce
that SEV-ES and SEV-SNP guests cannot enable features that the
hypervisor does not want to be enabled.
Patch 1/2 adds support to detect the feature.
Patch 2/2 configures the ALLOWED_SEV_FEATURES field in the VMCB
according to the features the hypervisor supports.
Tested SNP by setting random feature bits to the sev_features
assignment in wakeup_cpu_via_vmgexit() (but not its ghcb_set_rax).
Tested SEV-ES by manipulating the save->sev_features assignment
in sev_es_sync_vmsa(). Note that SEV-ES "allows" operation only
works on features available in SEV-ES, i.e., it ignores SNP-only
features. Zen5 SEV-ES features are DEBUG_SWAP, PREVENT_HOST_IBS,
VMGEXIT_PARAMETER, PMC_VIRTUALIZATION, and IBS_VIRTUALIZATION.
Based on x86-kvm/next.
[1] Section 15.36.20 "Allowed SEV Features", AMD64 Architecture
Programmer's Manual, Pub. 24593 Rev. 3.42 - March 2024:
https://bugzilla.kernel.org/attachment.cgi?id=306250
v5:
- Add reviews-by
- Add the two new vmcb fields to dump_vmcb() output (Pankaj)
- Address comment by Tom and put single assignment in sev_es_init_vmcb
v4: https://lore.kernel.org/kvm/20250306003806.1048517-1-kim.phillips@amd.com/
- Revert the user-opt in (Sean, sorry for the misunderstanding)
- this basically undoes v3 uAPI changes and makes the feature
always-on, if available
- rebased on top of x86-kvm/next
v3: https://lore.kernel.org/kvm/20250207233410.130813-1-kim.phillips@amd.com/
- Assign allowed_sev_features based on user-provided vmsa_features mask (Sean)
- Users now have to explicitly opt-in with a qemu "allowed-sev-features=on" switch.
- Rebased on top of 6.14-rc1 and reworked authorship chain (tglx)
v2: https://lore.kernel.org/lkml/20240822221938.2192109-1-kim.phillips@amd.com/
- Added some SEV_FEATURES require to be explicitly allowed by
ALLOWED_SEV_FEATURES wording (Sean).
- Added Nikunj's Reviewed-by.
v1: https://lore.kernel.org/lkml/20240802015732.3192877-3-kim.phillips@amd.com/
Kim Phillips (1):
KVM: SEV: Configure "ALLOWED_SEV_FEATURES" VMCB Field
Kishon Vijay Abraham I (1):
x86/cpufeatures: Add "Allowed SEV Features" Feature
arch/x86/include/asm/cpufeatures.h | 1 +
arch/x86/include/asm/svm.h | 7 ++++++-
arch/x86/kvm/svm/sev.c | 5 +++++
arch/x86/kvm/svm/svm.c | 2 ++
4 files changed, 14 insertions(+), 1 deletion(-)
base-commit: c9ea48bb6ee6b28bbc956c1e8af98044618fed5e
--
2.43.0
next reply other threads:[~2025-03-10 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 20:16 Kim Phillips [this message]
2025-03-10 20:16 ` [PATCH v5 1/2] x86/cpufeatures: Add "Allowed SEV Features" Feature Kim Phillips
2025-03-10 20:16 ` [PATCH v5 2/2] KVM: SEV: Configure "ALLOWED_SEV_FEATURES" VMCB Field Kim Phillips
2025-03-14 19:59 ` Tom Lendacky
2025-04-25 23:23 ` [PATCH v5 0/2] KVM: SEV: Add support for the ALLOWED_SEV_FEATURES feature Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310201603.1217954-1-kim.phillips@amd.com \
--to=kim.phillips@amd.com \
--cc=Neeraj.Upadhyay@amd.com \
--cc=aik@amd.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=naveen@kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox