Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: "Clément Léger" <cleger@rivosinc.com>
Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
	 Anup Patel <apatel@ventanamicro.com>,
	Atish Patra <atishp@rivosinc.com>
Subject: Re: [kvm-unit-tests PATCH v8 2/6] riscv: Set .aux.o files as .PRECIOUS
Date: Wed, 12 Mar 2025 18:53:28 +0100	[thread overview]
Message-ID: <20250312-70978d5a25e382c2b36935f4@orel> (raw)
In-Reply-To: <20250312-c9b8ee98ed38271ed7422550@orel>

On Wed, Mar 12, 2025 at 05:30:09PM +0100, Andrew Jones wrote:
> On Fri, Mar 07, 2025 at 05:15:44PM +0100, Clément Léger wrote:
> > When compiling, we need to keep .aux.o file or they will be removed
> > after the compilation which leads to dependent files to be recompiled.
> > Set these files as .PRECIOUS to keep them.
> > 
> > Signed-off-by: Clément Léger <cleger@rivosinc.com>
> > ---
> >  riscv/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/riscv/Makefile b/riscv/Makefile
> > index 52718f3f..ae9cf02a 100644
> > --- a/riscv/Makefile
> > +++ b/riscv/Makefile
> > @@ -90,6 +90,7 @@ CFLAGS += -I $(SRCDIR)/lib -I $(SRCDIR)/lib/libfdt -I lib -I $(SRCDIR)/riscv
> >  asm-offsets = lib/riscv/asm-offsets.h
> >  include $(SRCDIR)/scripts/asm-offsets.mak
> >  
> > +.PRECIOUS: %.aux.o
> >  %.aux.o: $(SRCDIR)/lib/auxinfo.c
> >  	$(CC) $(CFLAGS) -c -o $@ $< \
> >  		-DPROGNAME=\"$(notdir $(@:.aux.o=.$(exe)))\" -DAUXFLAGS=$(AUXFLAGS)
> > -- 
> > 2.47.2
> >
> 
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

I meant to give this a

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>

but I'm using the wrong mutt config right now...

drew

  reply	other threads:[~2025-03-12 17:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 16:15 [kvm-unit-tests PATCH v8 0/6] riscv: add SBI SSE extension tests Clément Léger
2025-03-07 16:15 ` [kvm-unit-tests PATCH v8 1/6] kbuild: Allow multiple asm-offsets file to be generated Clément Léger
2025-03-07 16:15 ` [kvm-unit-tests PATCH v8 2/6] riscv: Set .aux.o files as .PRECIOUS Clément Léger
2025-03-12 16:30   ` Andrew Jones
2025-03-12 17:53     ` Andrew Jones [this message]
2025-03-07 16:15 ` [kvm-unit-tests PATCH v8 3/6] riscv: Use asm-offsets to generate SBI_EXT_HSM values Clément Léger
2025-03-07 16:15 ` [kvm-unit-tests PATCH v8 4/6] riscv: lib: Add SBI SSE extension definitions Clément Léger
2025-03-07 16:15 ` [kvm-unit-tests PATCH v8 5/6] lib: riscv: Add SBI SSE support Clément Léger
2025-03-12 16:29   ` Andrew Jones
2025-03-07 16:15 ` [kvm-unit-tests PATCH v8 6/6] riscv: sbi: Add SSE extension tests Clément Léger
2025-03-12 17:51   ` Andrew Jones
2025-03-14  9:29     ` Clément Léger
2025-03-14 10:09       ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250312-70978d5a25e382c2b36935f4@orel \
    --to=ajones@ventanamicro.com \
    --cc=apatel@ventanamicro.com \
    --cc=atishp@rivosinc.com \
    --cc=cleger@rivosinc.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox