Re: [kvm-unit-tests PATCH v3 0/5] arm64: Change the default QEMU CPU type to "max"

Alexandru Elisei
2025-03-27T17:17:46Z

Hi Drew,

On Wed, Mar 26, 2025 at 07:51:35PM +0100, Andrew Jones wrote:
> On Tue, Mar 25, 2025 at 04:00:28PM +0000, Jean-Philippe Brucker wrote:
> > This is v3 of the series that cleans up the configure flags and sets the
> > default CPU type to "max" on arm64, in order to test the latest Arm
> > features.
> >
> > Since v2 [1] I moved the CPU selection to ./configure, and improved the
> > help text. Unfortunately I couldn't keep most of the Review tags since
> > there were small changes all over.
> >
> > [1] https://lore.kernel.org/all/20250314154904.3946484-2-jean-philippe@linaro.org/
> >
> > Alexandru Elisei (3):
> > configure: arm64: Don't display 'aarch64' as the default architecture
> > configure: arm/arm64: Display the correct default processor
> > arm64: Implement the ./configure --processor option
> >
> > Jean-Philippe Brucker (2):
> > configure: Add --qemu-cpu option
> > arm64: Use -cpu max as the default for TCG
> >
> > scripts/mkstandalone.sh | 3 ++-
> > arm/run | 15 ++++++-----
> > riscv/run | 8 +++---
> > configure | 55 +++++++++++++++++++++++++++++++++++------
> > arm/Makefile.arm | 1 -
> > arm/Makefile.common | 1 +
> > 6 files changed, 63 insertions(+), 20 deletions(-)
> >
> > --
> > 2.49.0
>
> Thanks Jean-Philippe. I'll let Alex and Eric give it another look, but
> LGTM.

Looks good to me too, just two nitpicks, not sure if it's worth respining just
for them, or if you want to make the changes when you apply the patches (or just
ignore them, that's fine too!).

Thanks,
Alex