From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C5D0229B28 for ; Mon, 7 Apr 2025 08:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744015481; cv=none; b=q2SWsutAfuYyd3jh2PAo/yd1x5WbWYzjh9UOqikOYPYJ4N2TIkEPYwTthA1t/Tfyu3BmQToOeVvpXkTooRxJ7kK3VB8WizaiM3gj/apqTxNbrSKMhXwLl5VS7eVSmmKXJzbvswlPVUn3xt0EWWAgefG9eLjA+Ydz73z+nOmwONs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744015481; c=relaxed/simple; bh=PtiFvCi0OCxZqEy7v1TJKjthTCLnjNTw9mDEXSxL+Sk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZTjXlCJP958tWNyvEMj5w5mwfGPOEvtEtbv1ehQc1xridte5PtjQnKc/30Xm5q4tWd45af6V14Fnef2wARm/NZ2kOjf4LsmdFSZ4Ao3dM3w+yMjmlf4VpPKiUWwkzzKmn0+QD9N5H9nvuiuizQ6TaMGJQvGygMYOcTNRObi61fM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RT/3AVT0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RT/3AVT0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744015478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BxsyOJ1xzReb7dqRLf34SXfhgO/SwPIG7kI1XoYIq/U=; b=RT/3AVT0TVDl9dvu2MbB0201U/CHSEO4EDr9iNyFFqsPaisifv1cGvXYCBfo4Uis6crzxu nRdoBWREaoAKgkk9KJiEJ0MvN7Z1pcd00OGhr5+pkhIGk4K68tYqCINnlw8YTAQaUsgoy2 2pglUdTqVBApgpu9McWjbkzV6MAI89Q= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-V4KSOKChNIChRXRma9xnjA-1; Mon, 07 Apr 2025 04:44:37 -0400 X-MC-Unique: V4KSOKChNIChRXRma9xnjA-1 X-Mimecast-MFC-AGG-ID: V4KSOKChNIChRXRma9xnjA_1744015476 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3914608e90eso2563129f8f.2 for ; Mon, 07 Apr 2025 01:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744015476; x=1744620276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BxsyOJ1xzReb7dqRLf34SXfhgO/SwPIG7kI1XoYIq/U=; b=f8b0IneqS5RL5rQphFZcsXkk0Y2uH2sT8rfCRTh/fOLoPG78LvSIRMzpIBi12MWNfw 0sY8DMUZxCHJbz3oF2zBqcy6+jzuv52z6GsluDswoYo0UZvXdbmCX2MkTVO4LUEFHq1b fXoFIyfzJXXAlCUWmXf094Y7vuqUgFpY8uI8NM/5JWlCpXQIdfKifGTjH0lxsv+70hTp mcpN6vfHzBQvZa5zaEV9N3OZnRIJwFaWdA2Cs1ZEIcPoly0UjOci5WYPOzvsWyzNrI55 KLVBZ1mVZ0QMxMaP5dovCnNfZIB2Ec4dvy7tBhtv9Vf9SlHvuS6ti9rA/4qnDSy6CSpb QRTA== X-Forwarded-Encrypted: i=1; AJvYcCUZqlwk1llM3n2+mbJLJSWhjEBTyANnvMg5o+bcfccwSoJDDNbmcXxZh8m9uo45a59oKj0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8kb1/5xVJ9p6IMD38+LoHQHzLVzAKYsotzd0IriM+cxUbDWf+ PA8LIynCr8NlCQETXlQdN17xAnH37GGw4++D5Znbm0YarV2fKzKHa3H9GWcTwYU7A/8uHrzMLK6 7iI5tunsgExcXoXQnm2Ram6xKClj/dy79KPQ5w/s7abioKSrySg== X-Gm-Gg: ASbGnctQ67ohn1Y1/iQUZOmIYFrpgj71tngwF7LnR5XVNmODKA+3LrCH8DAYHWUDbEk wL2k3nFiCsSfnjumEGBM83fk6j3LhZyE8i8VdS7ciBQBP9CvZluhTkeTHlD6/hNs7au0hLODFPs 4euw4FHgI/u98b2o1lFHgy+NxfjaU/L6yKkXVRzVXdWdt1hIZJ+IamHfwD6GZzJuzyiArK1MqMH M93gkGeNsiUi/X+gX1lolGOZGy76gQ6nAGwfWoqDLiqhE3fCD1XgUrxL/kvH3k5QT9eQvQa4fVY Cru2L+r3Gg== X-Received: by 2002:a05:6000:2285:b0:391:3049:d58d with SMTP id ffacd0b85a97d-39cadc85ab6mr9887020f8f.0.1744015476150; Mon, 07 Apr 2025 01:44:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5RHnKh0qDdKz/5Ine63hPlJA3HH3Ym3a+73u+PAR+VrXtWlXlmPf7sT0QkaNygBVDWFb9Aw== X-Received: by 2002:a05:6000:2285:b0:391:3049:d58d with SMTP id ffacd0b85a97d-39cadc85ab6mr9886995f8f.0.1744015475774; Mon, 07 Apr 2025 01:44:35 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30226be7sm11211086f8f.89.2025.04.07.01.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 01:44:35 -0700 (PDT) Date: Mon, 7 Apr 2025 04:44:32 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: Halil Pasic , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, Chandra Merla , Stable@vger.kernel.org, Cornelia Huck , Thomas Huth , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Wei Wang Subject: Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues Message-ID: <20250407044246-mutt-send-email-mst@kernel.org> References: <4a33daa3-7415-411e-a491-07635e3cfdc4@redhat.com> <20250404153620.04d2df05.pasic@linux.ibm.com> <20250404160025.3ab56f60.pasic@linux.ibm.com> <6f548b8b-8c6e-4221-a5d5-8e7a9013f9c3@redhat.com> <20250404173910.6581706a.pasic@linux.ibm.com> <20250407034901-mutt-send-email-mst@kernel.org> <2b187710-329d-4d36-b2e7-158709ea60d6@redhat.com> <39a67ca9-966b-40c1-b080-95d8e2cde376@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39a67ca9-966b-40c1-b080-95d8e2cde376@redhat.com> Wow great job digging through all these hypervisors! On Mon, Apr 07, 2025 at 10:38:59AM +0200, David Hildenbrand wrote: > crossvm: > https://github.com/google/crosvm/blob/main/devices/src/virtio/balloon.rs > > -> Hard-codes queue numbers; does *not* offer/implement > VIRTIO_BALLOON_F_STATS_VQ but does offer VIRTIO_BALLOON_F_STATS_VQ > and VIRTIO_BALLOON_F_DEFLATE_ON_OOM. > > -> Implements something that is not in the virtio-spec > > const VIRTIO_BALLOON_F_WS_REPORTING: u32 = 8; // Working Set Reporting > virtqueues > > and > > const WS_DATA_VQ: usize = 5; > const WS_OP_VQ: usize = 6; > > > IIUC, Linux inside cross-vm might actually be problematic? They would > disagree on the virtqueue for free-page-reporting That's why things must be tied to negotiated features, not to offered ones. > > Maybe I am missing something, it's a mess ... Indeed. Let's fix the implementations while keeping work arounds for existing ones. -- MST