From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE9152288CC for ; Mon, 7 Apr 2025 08:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744016307; cv=none; b=oPeyOpJqkvb8imuH0RVZo83wc3/33tgU9j1MZs+FJgpeTETG/zKSZpWDQVZePEY0J1kiCzlrrmmUBNxz6q17kxtN0FVU5CLEy/UQH8FLxUr0n+dMVZplvr6FGcANIwEYLOSo46T2eTC68vsD5TnHb+uoVykkUQg8Cp9SFE5IJJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744016307; c=relaxed/simple; bh=CG8MriHLl4x6ooaR3HqW98i5p2ZNjETviVu5KLjC8Ok=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rdKNXPrMQ9M0s1fkuNNAvUVG75bOYPZUMIrREepFpLTdoEAtyAwcJKTPxXkut+QSvT1cSjeSLFQrkha4j7E8pUMmPGnJIr2KJYOPooiCKoRooTR9ff0noH1f+IzqcXzd6/oQ1Oyb2k3pAV3f6hpfSotQWAknIjjIDTgl6fsuvi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JECNUsOk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JECNUsOk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744016304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZV2HmK5xoNyWQTq3ZOPhBucA+WbSSx9NK0eZZiZro+I=; b=JECNUsOk6InsM64N6tecTWiUJZbDV5wi+58pL+l1zC3Cf2FklXMtmuTJZL+N1t7pKg5JC4 Lx25XgsH/dNGtITptNHqiE82oG02Ou36fq29T31AmhexBRem6Zzf4EfWHXwFijhZ1GzJbz p4BHSnL4t5A2RINqzrx2PTAVtMndmec= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-YjXIPiLuMGWuX2p9U8p23g-1; Mon, 07 Apr 2025 04:58:23 -0400 X-MC-Unique: YjXIPiLuMGWuX2p9U8p23g-1 X-Mimecast-MFC-AGG-ID: YjXIPiLuMGWuX2p9U8p23g_1744016302 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so32075625e9.3 for ; Mon, 07 Apr 2025 01:58:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744016302; x=1744621102; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZV2HmK5xoNyWQTq3ZOPhBucA+WbSSx9NK0eZZiZro+I=; b=dHILc7Gyr3At9IETyv7I8JtwWaNl2B0j9h5dIWKD1JFHrE0bWHrArn3uc/QO7fNO7S O98ET0lfPuiNzXclHEkTQyjjuoyvZEO7Bmwcc48QO8U/eA34J0gYHq80zSlQ6VxIT71T YUhdjNZkwRdJ003JXkTDKgw2i6aCcXlyFZrh+ov9w5Lz+Awe0xatiN9ertrXEpp+4RaZ kVLHfaob5+MQOpNmFZSaioJaJvl7A9NnVc9gQOKrOp5jJ0KmQqKIvjZc0UvVx3zBikdC 8E20pDN1bamnDY091vU5tSmugaa8NMqyboOfZkxy56l7iIPOxyF8myxlmL/SNvMgBsZv 2iKQ== X-Forwarded-Encrypted: i=1; AJvYcCVuPYPjRfnf6ARwdX36mwIgHdepHWUVKRBN0GkIE+alvnLaCixgWGeumY8GZXn82broYR0=@vger.kernel.org X-Gm-Message-State: AOJu0YzYjz4Hj6bQyqaSc/MM9NTdcHTY/fzJ0D3wuy9aKp9DuZcHwFJr xzXs58zJ/KVXIQ+bclmWCvopqNs//bBUMaPI1KNV1n9bgsoc3Ent2fDUkyWw8liaR5zxYurFI3G whzH3lcDEHElaOB1A7LisYJPek9zc72y9l1nOkcfQeUtYAtuzqw== X-Gm-Gg: ASbGncsuL4wmzd83SsHJ0t8v5QAY45pXnhDUbm9FjtH7XoLy/6IGgxJ7EZgH4XCcx0R E3ZuOZJol/tFWyDzjlq7V7u49s+CFBRV3JqyXY5zV1k1UBz++sNweE2NLvN4mL2mcSPjVpFPHK5 S0+cqX4P2qq6C5SzJMpMWUD/OHXAed+AdbFp58GYRrbzuIsQxxILBPtNKX+csrNXef7xzxJ3p2g UxLUlMBYfbvlUSoyfbNAZbuwjmrm6eXuaiLJDVqbb+UNkKaTp03EQIXWGqVLKyZTvtR2bYCPkXB cQlewlTu4A== X-Received: by 2002:a05:600c:468c:b0:43c:f75a:eb54 with SMTP id 5b1f17b1804b1-43ecf89dddcmr115799965e9.13.1744016302268; Mon, 07 Apr 2025 01:58:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHhKuX0mUrFJVEgLqylU9xtfrLnxP9uo0MumXdr880MeHJm8lYFGfF2ifqGSX/2NbtuHhA09A== X-Received: by 2002:a05:600c:468c:b0:43c:f75a:eb54 with SMTP id 5b1f17b1804b1-43ecf89dddcmr115799665e9.13.1744016301907; Mon, 07 Apr 2025 01:58:21 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec342827fsm124494865e9.6.2025.04.07.01.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 01:58:21 -0700 (PDT) Date: Mon, 7 Apr 2025 04:58:18 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: Halil Pasic , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, Chandra Merla , Stable@vger.kernel.org, Cornelia Huck , Thomas Huth , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Wei Wang Subject: Re: [PATCH v1] s390/virtio_ccw: don't allocate/assign airqs for non-existing queues Message-ID: <20250407045456-mutt-send-email-mst@kernel.org> References: <20250404160025.3ab56f60.pasic@linux.ibm.com> <6f548b8b-8c6e-4221-a5d5-8e7a9013f9c3@redhat.com> <20250404173910.6581706a.pasic@linux.ibm.com> <20250407034901-mutt-send-email-mst@kernel.org> <2b187710-329d-4d36-b2e7-158709ea60d6@redhat.com> <20250407042058-mutt-send-email-mst@kernel.org> <0c221abf-de20-4ce3-917d-0375c1ec9140@redhat.com> <20250407044743-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 07, 2025 at 10:54:00AM +0200, David Hildenbrand wrote: > On 07.04.25 10:49, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2025 at 10:44:21AM +0200, David Hildenbrand wrote: > > > > > > > > > > > > > > > > > Whoever adds new feat_X *must be aware* about all previous features, > > > > > otherwise we'd be reusing feature bits and everything falls to pieces. > > > > > > > > > > > > The knowledge is supposed be limited to which feature bit to use. > > > > > > I think we also have to know which virtqueue bits can be used, right? > > > > > > > what are virtqueue bits? vq number? > > Yes, sorry. I got confused myself, it's vq index actually now, we made the spec consistent with that terminology. used to be number/index interchangeably. > Assume cross-vm as an example. It would make use of virtqueue indexes 5+6 > with their VIRTIO_BALLOON_F_WS_REPORTING. crossvm guys really should have reserved the feature bit even if they did not bother specifying it. Let's reserve it now at least? > So whatever feature another device implements couldn't use this feature bit > or these virtqueue indexes. > > (as long the other device never intends to implement > VIRTIO_BALLOON_F_WS_REPORTING, the virtqueue indexes could be reused. But > the spec will also be a mess, because virtqueue indexes could also have > duplicate meanings ... ugh) what do they do with vq indices btw? > -- > Cheers, > > David / dhildenb