Re: [kvm-unit-tests PATCH v3 02/16] scripts: Add 'test_args' test definition parameter

Andrew Jones
2025-05-07T15:58:58Z

On Wed, May 07, 2025 at 04:12:42PM +0100, Alexandru Elisei wrote:
...
> # FPU/SIMD test
> @@ -276,17 +291,20 @@ arch = arm64
> [mte-sync]
> file = mte.flat
> groups = mte
> -qemu_params = -machine mte=on -append 'sync'
> +test_args=sync

add spaces around =

> +qemu_params = -machine mte=on
> arch = arm64
>
> [mte-async]
> file = mte.flat
> groups = mte
> -qemu_params = -machine mte=on -append 'async'
> +test_args=async

spaces

> +qemu_params = -machine mte=on
> arch = arm64
>
> [mte-asymm]
> file = mte.flat
> groups = mte
> -qemu_params = -machine mte=on -append 'asymm'
> +test_args=asymm

spaces

...
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index 400e8a082528..06cc58e79b69 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -80,12 +80,18 @@ function run()
> local groups="$2"
> local smp="$3"
> local kernel="$4"
> - local opts="$5"
> - local arch="$6"
> - local machine="$7"
> - local check="${CHECK:-$8}"
> - local accel="$9"
> - local timeout="${10:-$TIMEOUT}" # unittests.cfg overrides the default
> + local test_args="$5"
> + local opts="$6"
> + local arch="$7"
> + local machine="$8"
> + local check="${CHECK:-$9}"
> + local accel="${10}"
> + local timeout="${11:-$TIMEOUT}" # unittests.cfg overrides the default
> +
> + # If $test_args is empty, qemu will interpret the first option after -append
> + # as a kernel parameter instead of a qemu option, so make sure the -append
> + # option is used only if $test_args is not empy.

^ empty

Otherwise,

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>