From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 244B622F757 for ; Fri, 9 May 2025 15:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746805119; cv=none; b=XNZNZ0elPnAxwM/KT3DS56bitAdlXHpplEbEVgml7yE5EtCHOxAgBTXLZbbSdooXaEFqjzZ7I5WaEng4LAdkDN9PfVZD5BWxMmB1XX90QQu5Xp+CVd13rA3ERJYsGeSrEZ6/TgU8qx6esbSQcuVd9jYOw4ASS0usNbApdjvLIlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746805119; c=relaxed/simple; bh=4s2rO8gDEhG/vrt24mHiJ7x4gEXjB1pG/4/+2tzNW3c=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HMzsywNM7lEnstsceDo15x0Lv8kZLm3kvqm0O//fcdr+1CIbb8Q8h/Ossf85ILYFBPcsEJZMAyinSISuK6I4Ui3ZcudJebx7Cqvv8U6QgQWcDFSAsbgDZG57c/ekhWP4cjLGNgnmdFmExZduFkCS+KFNlFjG5dFG22yl/FWcB/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=R0zSpsHr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R0zSpsHr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746805117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nacOks2riggVWBsNA+mzbNQsW0rVzzTbedwggtXVT54=; b=R0zSpsHrMzU6jkuWCozproO9X7gVrBl1ekZEObgTn5Gr4qCw/GAjXbOU54gmS8JrS7MzeO xxeCsg8KMa4K5eLBw+RQvsDYy1hnLHD3qOYd1Ra03l469hRJDjN2KsieSHkpFYWFkKPo5B 2eowud7EEbbmZXfD0CkcjJys+Mf8iRw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-82oDUaa7PZOyolFM53_SyA-1; Fri, 09 May 2025 11:38:35 -0400 X-MC-Unique: 82oDUaa7PZOyolFM53_SyA-1 X-Mimecast-MFC-AGG-ID: 82oDUaa7PZOyolFM53_SyA_1746805114 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43efa869b0aso15780965e9.3 for ; Fri, 09 May 2025 08:38:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746805114; x=1747409914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nacOks2riggVWBsNA+mzbNQsW0rVzzTbedwggtXVT54=; b=GMfmwUClcs+DO5yAU6Cy/D7Kb7cwQOoaeeXnYKp6MpfJ+204qQP6nXozh93Eh0morZ P1TfUzu8y6gixkmdHBMBXAAOH8lKnjn0lLv8J7S35a2CAUlGuSV88ACehg3wyHPit/Jz iMqyMmSDSpwuK60ZDOLoxHyd8HIgU2+BIWL+ckFz/SJIorP1j669VDtealaSX4vEricR N+ZwDguiO48OOUCk9ecxMjqW8HIQZYjmyRyiGX93dJlMyZyliQ7GbWYPc8fBAmU2EccE 3x5SJone3G2mVGLAOj2/74JOegkkv160aN2YoTDY45fShU4gcYpqbH1rpMLLcMSvhjlw hQqw== X-Forwarded-Encrypted: i=1; AJvYcCVPTDfVf19fKmgwtr6qIhDSKdpEGqbt9GlW4MzQ0Y7Wtkh7uyUGsmuL7PijcPS8PHghCBM=@vger.kernel.org X-Gm-Message-State: AOJu0YxnX56vj4IT57vAcqhhaBOvsEtjApK+D+W29giP85ZtDQwtVO7s i4lKww84zv//LceWVARbYdjXekT03fNUIh9DVGZs+HtqpWhLnGCpbmtOMmbjYKMf5OyEDHPGMj9 55ThZHtt5ap11ExFtiE84p3DqaqJOXRSLUZ30Is0AQPtrqYFAQQ== X-Gm-Gg: ASbGncuygCENtQ05qPoccWjKC6LDeSbh2DX4hKWqIOmLFiPqObbGKKNbdeGbGZ0vkdN YmV4XDEsxiAREvzZlV/Ne//mV8kl9I2G9bcIzU8pQ/NUj3D0XRRoU8lhHbyg8UYctIsfNSNuPCY a9GkXTY0nf4YhJDr5rjLFxMOQDhH3RINXEDeAaLYSBwp+pzrtJq200QfgxrLSQgd8+REGmhDHO1 BnmWj5HoGvS3b4b8Y+tu4+r2m7zKt9zr3i+bqhd41Nb415in2ImdZsH9jNjMdQqdqJ4eLagaGuw 0BmXHVZczWFaM7fAPmcosDpaC6H3QWmR X-Received: by 2002:a05:600c:1da8:b0:43c:fb95:c76f with SMTP id 5b1f17b1804b1-442d6d1f997mr36588955e9.9.1746805114255; Fri, 09 May 2025 08:38:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBEcV+/MRGEimFQAdvMHfUPN89iu355oNKXju8PihTLwzByIgEtqzNodbo9ktiTe49ZmDRCg== X-Received: by 2002:a05:600c:1da8:b0:43c:fb95:c76f with SMTP id 5b1f17b1804b1-442d6d1f997mr36588685e9.9.1746805113892; Fri, 09 May 2025 08:38:33 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd34bc2esm75445085e9.20.2025.05.09.08.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 May 2025 08:38:33 -0700 (PDT) Date: Fri, 9 May 2025 17:38:30 +0200 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Zhao Liu , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?UTF-8?B?Q2zDqW1lbnQ=?= Mathieu--Drif , qemu-arm@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Huacai Chen , Jason Wang Subject: Re: [PATCH v4 05/27] hw/nvram/fw_cfg: Factor fw_cfg_init_mem_internal() out Message-ID: <20250509173830.65d0fde7@imammedo.users.ipa.redhat.com> In-Reply-To: <20250508133550.81391-6-philmd@linaro.org> References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-6-philmd@linaro.org> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 8 May 2025 15:35:28 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > Factor fw_cfg_init_mem_internal() out of fw_cfg_init_mem_wide(). > In fw_cfg_init_mem_wide(), assert DMA arguments are provided. > Callers without DMA have to use the fw_cfg_init_mem() helper. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Igor Mammedov > --- > hw/nvram/fw_cfg.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 10f8f8db86f..4067324fb09 100644 > --- a/hw/nvram/fw_cfg.c > +++ b/hw/nvram/fw_cfg.c > @@ -1053,9 +1053,9 @@ FWCfgState *fw_cfg_init_io_dma(uint32_t iobase, uin= t32_t dma_iobase, > return s; > } > =20 > -FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr, > - hwaddr data_addr, uint32_t data_width, > - hwaddr dma_addr, AddressSpace *dma_as) > +static FWCfgState *fw_cfg_init_mem_internal(hwaddr ctl_addr, > + hwaddr data_addr, uint32_t d= ata_width, > + hwaddr dma_addr, AddressSpac= e *dma_as) > { > DeviceState *dev; > SysBusDevice *sbd; > @@ -1087,10 +1087,19 @@ FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr, > return s; > } > =20 > +FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr, > + hwaddr data_addr, uint32_t data_width, > + hwaddr dma_addr, AddressSpace *dma_as) > +{ > + assert(dma_addr && dma_as); > + return fw_cfg_init_mem_internal(ctl_addr, data_addr, data_addr, > + dma_addr, dma_as); > +} > + > FWCfgState *fw_cfg_init_mem_nodma(hwaddr ctl_addr, hwaddr data_addr, > unsigned data_width) > { > - return fw_cfg_init_mem_wide(ctl_addr, data_addr, data_width, 0, NULL= ); > + return fw_cfg_init_mem_internal(ctl_addr, data_addr, data_width, 0, = NULL); > } > =20 > =20