From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4802E21CA1F for ; Fri, 23 May 2025 23:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748043043; cv=none; b=XKo1lwMNuDq1j3BorE0mNRrMjTLsHf7ejrOG64ta50/4FdRNP3/5U+05lj1ZZgR6v190MMXEqY9qG+Tw24t8f96ZJQlO6mnXxuhfUFWSuE6GMSS0Hem4c7FqY1/RXhYgsaTMu9MtAtc527ww2I7E3TGTacfJrqgY8/N+p8LOSLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748043043; c=relaxed/simple; bh=Aqyq0W+hAHBspl+ajt8stjwvubegV6/J/Df6q3br1nc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jiEGzYWxJCct7l8xN6DPb3i0sW9BP9LS4uBrEnHJB9fWxBXxwP3UnsZCxvwujxiUhGDj177YV0TzpzM+rORKTyMTObKPuvHk/AU953St4i6JFeh7Q9aK0CkraG0VDYB0TEkXWJxoOCjBr2C+y/5fUzV8ytzagA7bHnP/w6TboQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Dtsay5Hs; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Dtsay5Hs" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-b26eec6da92so1014994a12.1 for ; Fri, 23 May 2025 16:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748043041; x=1748647841; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=cwOUKrqDnrShBJxmHxDTVTcPqWKQE/hfpajQGZaZKZM=; b=Dtsay5HsEypcResYKXJIGHh9vKh7yHVrd7DEP4Eia87Y474UzOcU8YOdf2YO0rQIvB GiPslEkM/BcMFfXPuywNUyT1dGDU0nZr1VlOk69WSfu6J5fUd+mRNoRk8Hy493PwMEoP tO/g8SyJFscn14XSionls1yH0np+DsRddV0yX3JtLUQI7Rljs0u3eI1m3/2j4t6goPxC Kn/Yxu+xrbu9FEaxtcw/APg1NDXP/pj7l3XXl6rSZFHHVRWoVF8CQy7IUsx4K6CqCVRI dV+cMQspbNpfmcO0momEZ2jCqD/q9a6OI/Rj7d/fvy6Qou5PJ/io2aTQkZVCz6eqMihZ dBSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748043041; x=1748647841; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cwOUKrqDnrShBJxmHxDTVTcPqWKQE/hfpajQGZaZKZM=; b=DY+ebxAyRsvVDIcBQIbILl0Uzj+lB15HqObxeuhcWE5kKcXmTt49m8lBXs9chXocFL TvzKwf/uKdm5IDY7gXxek2tlyVyGtI8QUfoBU9bJUuKQLxzmbqMVCJYWJ6H3zWB2T1cx C+0bSs+iJFp9DzckA9rxdBwi5jwEIRaE7wPqK3CKHyS48RJZWM/VFJx0o8j8zqEEkHtO 2Oij1YY8a4BFj2Qdqn5itG+lucbDRchOsJGZVpGXV4gruY9GvE8J/+MnKz/S5i6NdIja If2OXDHhCVdqZkAv9VRNK1oZzbOA4PZiclraxWb+2gjyv3Xwg8MZz1mK1XTgtInuQJ7Q s17w== X-Forwarded-Encrypted: i=1; AJvYcCUXBK3WcAqTAUzIURPs8sCg2zfuFWjZ6Ng91kD0avyNuhOigTFfvY8CCyU3OhNmTITM3eI=@vger.kernel.org X-Gm-Message-State: AOJu0Yydz7mD+HSm5p5ftsYEzWKikAfPBq94D056Qcte8ORMRMF5Y7fO 4jLNsYe0QK4HF1U2n3+Co3ysAn1wGSIPCf1kzjsJyDnNqOGMBTnrDWVnMduEYwxKGDiSSkNYFwR 1J/aEO4NV9yZ3zQ== X-Google-Smtp-Source: AGHT+IG9T6H5Zl9+1iefukPvRNFWkP3vCYFpO3lRHedONnpo0g986Nw4dw8SwgkH7GKWFeY+Z8nBvattkxALcw== X-Received: from pjuw7.prod.google.com ([2002:a17:90a:d607:b0:308:867e:1ced]) (user=dmatlack job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1c05:b0:30a:3e8e:ea30 with SMTP id 98e67ed59e1d1-310e8900934mr8344911a91.11.1748043041433; Fri, 23 May 2025 16:30:41 -0700 (PDT) Date: Fri, 23 May 2025 23:29:53 +0000 In-Reply-To: <20250523233018.1702151-1-dmatlack@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250523233018.1702151-1-dmatlack@google.com> X-Mailer: git-send-email 2.49.0.1151.ga128411c76-goog Message-ID: <20250523233018.1702151-9-dmatlack@google.com> Subject: [RFC PATCH 08/33] vfio: selftests: Validate 2M/1G HugeTLB are mapped as 2M/1G in IOMMU From: David Matlack To: Alex Williamson Cc: Shuah Khan , Paolo Bonzini , David Matlack , Vinod Koul , Fenghua Yu , "Masami Hiramatsu (Google)" , Adhemerval Zanella , Jiri Olsa , Andrii Nakryiko , Wei Yang , Bjorn Helgaas , Takashi Iwai , Greg Kroah-Hartman , Pierre-Louis Bossart , Andy Shevchenko , FUJITA Tomonori , WangYuli , Sean Christopherson , Andrew Jones , Claudio Imbrenda , Eric Auger , Josh Hilke , linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, Jason Gunthorpe , Kevin Tian , Vipin Sharma , Pasha Tatashin , Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , Vinicius Costa Gomes , Dave Jiang , Dan Williams Content-Type: text/plain; charset="UTF-8" From: Josh Hilke Update vfio dma mapping test to verify that the IOMMU uses 2M and 1G mappings when 2M and 1G HugeTLB pages are mapped into a device respectively. This validation is done by inspecting the contents of the I/O page tables via /sys/kernel/debug/iommu/intel/. This validation is skipped if that directory is not available (i.e. non-Intel IOMMUs). Signed-off-by: Josh Hilke [reword commit message, refactor code] Signed-off-by: David Matlack --- .../selftests/vfio/vfio_dma_mapping_test.c | 126 +++++++++++++++++- 1 file changed, 119 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/vfio/vfio_dma_mapping_test.c b/tools/testing/selftests/vfio/vfio_dma_mapping_test.c index 4b838a06a5fe..c4920267ae42 100644 --- a/tools/testing/selftests/vfio/vfio_dma_mapping_test.c +++ b/tools/testing/selftests/vfio/vfio_dma_mapping_test.c @@ -20,6 +20,83 @@ static struct { const char *bdf; } test_config; +struct iommu_mapping { + u64 pgd; + u64 p4d; + u64 pud; + u64 pmd; + u64 pte; +}; + +static void parse_next_value(char **line, u64 *value) +{ + char *token; + + token = strtok_r(*line, " \t|\n", line); + if (!token) + return; + + /* Caller verifies `value`. No need to check return value. */ + sscanf(token, "0x%lx", value); +} + +static int intel_iommu_mapping_get(const char *bdf, u64 iova, + struct iommu_mapping *mapping) +{ + char iommu_mapping_path[PATH_MAX], line[PATH_MAX]; + u64 line_iova = -1; + int ret = -ENOENT; + FILE *file; + char *rest; + + snprintf(iommu_mapping_path, sizeof(iommu_mapping_path), + "/sys/kernel/debug/iommu/intel/%s/domain_translation_struct", + bdf); + + printf("Searching for IOVA 0x%lx in %s\n", iova, iommu_mapping_path); + + file = fopen(iommu_mapping_path, "r"); + VFIO_ASSERT_NOT_NULL(file, "fopen(%s) failed", iommu_mapping_path); + + while (fgets(line, sizeof(line), file)) { + rest = line; + + parse_next_value(&rest, &line_iova); + if (line_iova != (iova / getpagesize())) + continue; + + /* + * Ensure each struct field is initialized in case of empty + * page table values. + */ + memset(mapping, 0, sizeof(*mapping)); + parse_next_value(&rest, &mapping->pgd); + parse_next_value(&rest, &mapping->p4d); + parse_next_value(&rest, &mapping->pud); + parse_next_value(&rest, &mapping->pmd); + parse_next_value(&rest, &mapping->pte); + + ret = 0; + break; + } + + fclose(file); + + if (ret) + printf("IOVA not found\n"); + + return ret; +} + +static int iommu_mapping_get(const char *bdf, u64 iova, + struct iommu_mapping *mapping) +{ + if (access("/sys/kernel/debug/iommu/intel", F_OK)) + return intel_iommu_mapping_get(bdf, iova, mapping); + + return -EOPNOTSUPP; +} + FIXTURE(vfio_dma_mapping_test) { struct vfio_pci_device *device; @@ -37,19 +114,54 @@ FIXTURE_TEARDOWN(vfio_dma_mapping_test) TEST_F(vfio_dma_mapping_test, dma_map_unmap) { + const int prot = PROT_READ | PROT_WRITE; + const u64 iova = test_config.iova; + const u64 size = test_config.size; + struct iommu_mapping mapping; void *mem; + int rc; - mem = mmap(NULL, test_config.size, PROT_READ | PROT_WRITE, - test_config.mmap_flags, -1, 0); + mem = mmap(NULL, size, prot, test_config.mmap_flags, -1, 0); ASSERT_NE(mem, MAP_FAILED); - vfio_pci_dma_map(self->device, test_config.iova, test_config.size, mem); - printf("Mapped HVA %p (size 0x%lx) at IOVA 0x%lx\n", mem, - test_config.size, test_config.iova); + vfio_pci_dma_map(self->device, iova, size, mem); + printf("Mapped HVA %p (size 0x%lx) at IOVA 0x%lx\n", mem, size, iova); + + rc = iommu_mapping_get(test_config.bdf, iova, &mapping); + if (rc == -EOPNOTSUPP) + goto unmap; + + ASSERT_EQ(0, rc); + printf("Found IOMMU mappings for IOVA 0x%lx:\n", iova); + printf("PGD: 0x%016lx\n", mapping.pgd); + printf("P4D: 0x%016lx\n", mapping.p4d); + printf("PUD: 0x%016lx\n", mapping.pud); + printf("PMD: 0x%016lx\n", mapping.pmd); + printf("PTE: 0x%016lx\n", mapping.pte); + + switch (size) { + case SZ_4K: + ASSERT_NE(0, mapping.pte); + break; + case SZ_2M: + ASSERT_EQ(0, mapping.pte); + ASSERT_NE(0, mapping.pmd); + break; + case SZ_1G: + ASSERT_EQ(0, mapping.pte); + ASSERT_EQ(0, mapping.pmd); + ASSERT_NE(0, mapping.pud); + break; + default: + VFIO_FAIL("Unrecognized size: 0x%lx\n", size); + } - vfio_pci_dma_unmap(self->device, test_config.iova, test_config.size); +unmap: + vfio_pci_dma_unmap(self->device, iova, size); + printf("Unmapped IOVA 0x%lx\n", iova); + ASSERT_NE(0, iommu_mapping_get(test_config.bdf, iova, &mapping)); - ASSERT_TRUE(!munmap(mem, test_config.size)); + ASSERT_TRUE(!munmap(mem, size)); } static void help(const char *name) -- 2.49.0.1151.ga128411c76-goog