From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842882EA48A for ; Wed, 11 Jun 2025 22:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749682099; cv=none; b=L1R0a5q9U0csJZDp+TUc9pLSGrDxUgdgZvPqSMcR83I4T1AXddFEy2O1bITjjfTdLue+REhMICydM4xzT5LmpS7dkuofsvF7aRP0uF7LvZqKy05mcwIaZm3d1jucIsTVD7s8zTsZgyR5uoVT2SVBlfmEyDirUy4U9h40h5/hLns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749682099; c=relaxed/simple; bh=CIkDX4NeyEz+bCplX5aJPQm6IavTLLLziMyDsf7mnvM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pV5l2UoyQYCfnL5Sbtm6ikSmLgSLH+nkmFuuQwKaQ1tzgDINNeP90Vzh+Sk1IvYvwkV26rSfzvSXih6aon4autrcXujBjKc4S9RxdET2nfOkKgNCXAv/T9nAzI7vYCwwGmpvZWOLytq8u4Rac3Zwp/pmJJQbdr0zJWoTm/l5TQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XChpKgnA; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XChpKgnA" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-313360ce7fcso298605a91.2 for ; Wed, 11 Jun 2025 15:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749682097; x=1750286897; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=OBsMBd1i0baUKewPQxLHxyy7sMDVTDzHxDH7w12EKXQ=; b=XChpKgnAAMM21SVqJo313lhNJC+wF9I69bdi/oPDKYQOardhOrqTCcztifo7GITQzq Lflh62btwNvZCWVdCKN9NOPdy+FpDIMU4aaBlZjzml6uFQqVkIXwjwd/T04KvOe/APlQ Xwxzlp/MhXZOTSvz1prBL5+S0DGWNu17X/eNsIu8+agmiIdIcPNq1TDfBQVYNtuWkrZJ Lo0r3QgD35Z7qIHAp5RiQlw78aRDUaJfy+c/mgW0P/2ejSQH3qv7WGfEFjw/Ofo23LCq 4U1YArk0mCiOKXrHSk5NgCFZIgVHPcuD4VD5Mb0ewgrjJEJ3FD/rOvfNNEhRu7OV/8a0 KbQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749682097; x=1750286897; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OBsMBd1i0baUKewPQxLHxyy7sMDVTDzHxDH7w12EKXQ=; b=ipZ/oU/6X0/Z2McHnHUMykWynZDclZBqFx3cNoUa5Z6agtUvQDTYHuaK/x8TysNLOf NINCRhROAaJ9hPqnc1jniObUkAVEFl+wcC4BV/9rzAdLCfTTfYja7tG+vD2OR7KQKDiE YZsZv6be8ydnmwt6OZVpipTIS8TiIhTlhpgssTwIGIjYGEDkuyRHL/of6JC8VuTPuQ+9 QU/AxQ0tZJzq0K7TaW3fnqiC4cJbsyXB3P49txTc9gC20fwaAji8Yxj1PjsjAcOUOLdj DNXJZpczBa/g3tUdm/lfrtRjUlXwwgM/qfFCFQG/P7zy0o0jz9sCKgQuJwzijTX/iPvM nnJA== X-Forwarded-Encrypted: i=1; AJvYcCVcs0HJb6WHsWO2m+/amUEve13/l77NvmLLFJ2FUXAUTvgBIkOJUdITAQkLShxv7kjii/U=@vger.kernel.org X-Gm-Message-State: AOJu0YxXqkPoUpjVHMttimOpuabgH+3xLn9CPRDu844bx2ZCJM+uNdyo aKRiwhF867hptPS0pAnzl6/XyqBYMk6C+j3QgCCE/BSfS3+HdmiHBsoj0jPZerukvc7wTeeo4D1 rMgN8aw== X-Google-Smtp-Source: AGHT+IHBEy8+OKJmY+A4zi/3hTeqSjfA/ttP2bWoyN5/kshTJAQ27HG4vGJt+llsgPQtOFs3CpzMzSvtcZQ= X-Received: from pjxx16.prod.google.com ([2002:a17:90b:58d0:b0:2ff:6132:8710]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4e8d:b0:311:d258:3473 with SMTP id 98e67ed59e1d1-313af12a361mr7057487a91.13.1749682097123; Wed, 11 Jun 2025 15:48:17 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 11 Jun 2025 15:45:50 -0700 In-Reply-To: <20250611224604.313496-2-seanjc@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250611224604.313496-2-seanjc@google.com> X-Mailer: git-send-email 2.50.0.rc1.591.g9c95f17f64-goog Message-ID: <20250611224604.313496-49-seanjc@google.com> Subject: [PATCH v3 47/62] KVM: SVM: Process all IRTEs on affinity change even if one update fails From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Sean Christopherson , Paolo Bonzini , Joerg Roedel , David Woodhouse , Lu Baolu Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Sairaj Kodilkar , Vasant Hegde , Maxim Levitsky , Joao Martins , Francesco Lavra , David Matlack Content-Type: text/plain; charset="UTF-8" When updating IRTE GA fields, keep processing all other IRTEs if an update fails, as not updating later entries risks making a bad situation worse. Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/avic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index 6048cd90e731..24e07f075646 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -849,12 +849,10 @@ static inline int avic_update_iommu_vcpu_affinity(struct kvm_vcpu *vcpu, int cpu if (list_empty(&svm->ir_list)) return 0; - list_for_each_entry(irqfd, &svm->ir_list, vcpu_list) { + list_for_each_entry(irqfd, &svm->ir_list, vcpu_list) ret = amd_iommu_update_ga(cpu, irqfd->irq_bypass_data); - if (ret) - return ret; - } - return 0; + + return ret; } void avic_vcpu_load(struct kvm_vcpu *vcpu, int cpu) -- 2.50.0.rc1.591.g9c95f17f64-goog