From: Jason Gunthorpe <jgg@ziepe.ca>
To: lizhe.67@bytedance.com
Cc: alex.williamson@redhat.com, david@redhat.com, peterx@redhat.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] vfio/type1: optimize vfio_unpin_pages_remote() for large folio
Date: Wed, 2 Jul 2025 15:28:44 -0300 [thread overview]
Message-ID: <20250702182844.GE904431@ziepe.ca> (raw)
In-Reply-To: <20250630072518.31846-5-lizhe.67@bytedance.com>
On Mon, Jun 30, 2025 at 03:25:18PM +0800, lizhe.67@bytedance.com wrote:
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index a02bc340c112..7cacfb2cefe3 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -802,17 +802,29 @@ static long vfio_pin_pages_remote(struct vfio_dma *dma, unsigned long vaddr,
> return pinned;
> }
>
> +static inline void put_valid_unreserved_pfns(unsigned long start_pfn,
> + unsigned long npage, int prot)
> +{
> + unpin_user_page_range_dirty_lock(pfn_to_page(start_pfn), npage,
> + prot & IOMMU_WRITE);
> +}
I don't think you need this wrapper.
This patch and the prior look OK
Jason
next prev parent reply other threads:[~2025-07-02 18:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 7:25 [PATCH 0/4] vfio/type1: optimize vfio_pin_pages_remote() and vfio_unpin_pages_remote() for large folio lizhe.67
2025-06-30 7:25 ` [PATCH 1/4] vfio/type1: optimize vfio_pin_pages_remote() for large folios lizhe.67
2025-06-30 7:25 ` [PATCH 2/4] vfio/type1: batch vfio_find_vpfn() in function vfio_unpin_pages_remote() lizhe.67
2025-07-02 18:27 ` Jason Gunthorpe
2025-07-03 4:18 ` lizhe.67
2025-07-03 12:27 ` Jason Gunthorpe
2025-07-04 2:20 ` lizhe.67
2025-06-30 7:25 ` [PATCH 3/4] vfio/type1: introduce a new member has_rsvd for struct vfio_dma lizhe.67
2025-07-01 15:13 ` Dan Carpenter
2025-07-02 3:47 ` lizhe.67
2025-07-02 16:11 ` Dan Carpenter
2025-06-30 7:25 ` [PATCH 4/4] vfio/type1: optimize vfio_unpin_pages_remote() for large folio lizhe.67
2025-07-02 18:28 ` Jason Gunthorpe [this message]
2025-07-03 6:12 ` lizhe.67
2025-07-02 8:15 ` [PATCH 0/4] vfio/type1: optimize vfio_pin_pages_remote() and " David Hildenbrand
2025-07-02 9:38 ` lizhe.67
2025-07-02 9:57 ` David Hildenbrand
2025-07-02 12:47 ` Jason Gunthorpe
2025-07-03 4:04 ` lizhe.67
2025-07-03 3:54 ` lizhe.67
2025-07-03 11:06 ` David Hildenbrand
2025-07-03 11:12 ` Jason Gunthorpe
2025-07-03 11:35 ` lizhe.67
2025-07-03 11:34 ` lizhe.67
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702182844.GE904431@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhe.67@bytedance.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox