From: Alex Williamson <alex.williamson@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
oe-kbuild@lists.linux.dev, Ankit Agrawal <ankita@nvidia.com>,
Brett Creeley <brett.creeley@amd.com>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Kevin Tian <kevin.tian@intel.com>,
kvm@vger.kernel.org, Longfang Liu <liulongfang@huawei.com>,
qat-linux@intel.com,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
virtualization@lists.linux.dev, Xin Zeng <xin.zeng@intel.com>,
Yishai Hadas <yishaih@nvidia.com>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH v3] vfio/pci: Do vf_token checks for VFIO_DEVICE_BIND_IOMMUFD
Date: Wed, 16 Jul 2025 11:00:27 -0600 [thread overview]
Message-ID: <20250716110027.7e94129f.alex.williamson@redhat.com> (raw)
In-Reply-To: <20250715230618.GV2067380@nvidia.com>
On Tue, 15 Jul 2025 20:06:18 -0300
Jason Gunthorpe <jgg@nvidia.com> wrote:
> On Wed, Jul 16, 2025 at 01:55:45AM +0300, Dan Carpenter wrote:
> > 5fcc26969a164e Yi Liu 2023-07-18 117 mutex_lock(&device->dev_set->lock);
> > 5fcc26969a164e Yi Liu 2023-07-18 118 /* one device cannot be bound twice */
> > 5fcc26969a164e Yi Liu 2023-07-18 119 if (df->access_granted) {
> > 5fcc26969a164e Yi Liu 2023-07-18 120 ret = -EINVAL;
> > 5fcc26969a164e Yi Liu 2023-07-18 121 goto out_unlock;
> > 5fcc26969a164e Yi Liu 2023-07-18 122 }
> > 5fcc26969a164e Yi Liu 2023-07-18 123
> > be2e70b96c3e54 Jason Gunthorpe 2025-07-14 124 ret = vfio_df_check_token(device, &bind);
> > be2e70b96c3e54 Jason Gunthorpe 2025-07-14 125 if (ret)
> > be2e70b96c3e54 Jason Gunthorpe 2025-07-14 @126 return ret;
> >
> > This needs to be a goto unlock.
>
> Oop yes, thank you
>
> Alex can you fix it up when applying?
Yes, I'll apply with:
diff --git a/drivers/vfio/device_cdev.c b/drivers/vfio/device_cdev.c
index 53a602563f00..480cac3a0c27 100644
--- a/drivers/vfio/device_cdev.c
+++ b/drivers/vfio/device_cdev.c
@@ -123,7 +123,7 @@ long vfio_df_ioctl_bind_iommufd(struct vfio_device_file *df,
ret = vfio_df_check_token(device, &bind);
if (ret)
- return ret;
+ goto out_unlock;
df->iommufd = iommufd_ctx_from_fd(bind.iommufd);
if (IS_ERR(df->iommufd)) {
next prev parent reply other threads:[~2025-07-16 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 16:08 [PATCH v3] vfio/pci: Do vf_token checks for VFIO_DEVICE_BIND_IOMMUFD Jason Gunthorpe
2025-07-15 0:00 ` Tian, Kevin
2025-07-15 22:55 ` Dan Carpenter
2025-07-15 23:06 ` Jason Gunthorpe
2025-07-16 17:00 ` Alex Williamson [this message]
2025-07-16 20:22 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716110027.7e94129f.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=ankita@nvidia.com \
--cc=brett.creeley@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=giovanni.cabiddu@intel.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=patches@lists.linux.dev \
--cc=qat-linux@intel.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=virtualization@lists.linux.dev \
--cc=xin.zeng@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).