From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62182F99A2 for ; Wed, 13 Aug 2025 19:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755113008; cv=none; b=VrAvegeCBDgqfLNMJV9wdtkCEkX8iWcX0u6Q6HcVX1xeO1AYBNy/e5T+bMTQalL5hz/3DOguYh7cuIALchEYuPEGdtDTsmiU0qSuSnVnwdq30mkn4tS6W41T0KszW0+toqaqSVD5Ejf3DLys8DnqV1KwwZKPz+s4JkiH8soE/lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755113008; c=relaxed/simple; bh=odDD8SbrUA/Us8WVd664Wi2+XyRFRFLnt1lNe/4JBsc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F6X8MnYRMUX8kzQbGAwEmuEBZL9NTOLpsEfy3UicFX0m/N/n+7Q3cL+2j3Goz78P6w+ZhbwEWXvP722fQqAzbLj6VS0CPeIE4snjrGyDpm+Gh9M+wTZd6MIqObsjrfXIRHR4FqlGKPlOUG6+kQyHXHH4GrXM4NG1uTPa/QVENHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dv0V3RIs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dv0V3RIs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755113005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jgbMTcNiqkXJF3R6x+5VhGOD4G8jt3bfqCPXMbYMCOY=; b=dv0V3RIsioFXEL76QeFg4rnAuM4hCVJCsMceJGSACkT65zp4RrVcdu1YWs8+z+pjGOPo6n oAQjp4+0CgGRDPe0W354bLp/Yfb7/7eVeZt7Eh/pQIb8N/Bu6ZS/I+vae2I4FcH+H4pHBF UzhSgCwP791ItXiswe87O2qXL8b0ulk= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-mZkleHuzP5SvVYQcUEruWg-1; Wed, 13 Aug 2025 15:23:21 -0400 X-MC-Unique: mZkleHuzP5SvVYQcUEruWg-1 X-Mimecast-MFC-AGG-ID: mZkleHuzP5SvVYQcUEruWg_1755112999 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA0D9195608E; Wed, 13 Aug 2025 19:23:18 +0000 (UTC) Received: from intellaptop.redhat.com (unknown [10.22.81.148]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CED181955F16; Wed, 13 Aug 2025 19:23:16 +0000 (UTC) From: Maxim Levitsky To: kvm@vger.kernel.org Cc: Sean Christopherson , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Paolo Bonzini , x86@kernel.org, Borislav Petkov , linux-kernel@vger.kernel.org, Maxim Levitsky Subject: [PATCH 1/3] KVM: x86: Warn if KVM tries to deliver an #APF completion when APF is not enabled Date: Wed, 13 Aug 2025 15:23:11 -0400 Message-ID: <20250813192313.132431-2-mlevitsk@redhat.com> In-Reply-To: <20250813192313.132431-1-mlevitsk@redhat.com> References: <20250813192313.132431-1-mlevitsk@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 KVM flushes the APF queue completely when the asynchronous pagefault is disabled, therefore this case should not occur. Signed-off-by: Maxim Levitsky --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a1c49bc681c4..9018d56b4b0a 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -13466,7 +13466,7 @@ void kvm_arch_async_page_present_queued(struct kvm_vcpu *vcpu) bool kvm_arch_can_dequeue_async_page_present(struct kvm_vcpu *vcpu) { - if (!kvm_pv_async_pf_enabled(vcpu)) + if (WARN_ON_ONCE(!kvm_pv_async_pf_enabled(vcpu))) return true; else return kvm_lapic_enabled(vcpu) && apf_pageready_slot_free(vcpu); -- 2.49.0