From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D5D62C0262 for ; Thu, 21 Aug 2025 20:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755807059; cv=none; b=Xut+HC6w+6+zsT4ueZnX0wWKFjKG7o6RBlIQ/SD0Wh1892jZtbql9PiQGZP2WI/jWRc7HtCPk87obnyXZCzbz0oJzTzIFEfEqJifLuRGq/EZNjIU8h5kiEUGZ8tvOj67t8y1s6UoLSHFzPBnCsgY2AsCJ24FvUccBSYa1S/YbA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755807059; c=relaxed/simple; bh=R0ZyW/lP53DUpD5XCfGL8s/RHhsGuoWDmk/SVEPPWc8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mhIaINFvhniVhyyF1sojs6uDhXEXlqrB729tgGi/VwPuSaEthYafcae8SkB8WvWkdM0xF+r62W4uIw5zs60PfEf/CnvvP55s9k7PdpAfSemUYfvKpi2F5nOHp0EbZDwEJ1mG3ov9KCzHuFHVDdiIq7UaSefPpy2fZQ6/OqIWH9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WloXl5Al; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WloXl5Al" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755807057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=An+3TCbux96ebWXl79jkDvpeTXFUup6Liv8QO7JiiR4=; b=WloXl5AlJmqcY6isKKXSorqfTao4xnrfxRX4pRiy2v5H3fCiuaDNJI/EhVlbA7ci7WIGCo 57JIzgwd137b+oEBKxw1Yo6Vm7QXwCmj8OCstBCYd0UiJPykQk5TTMJ2CQGUMWHAnecodN dwRinHYUlwi9/rhUCjwsyc/L5APDkd8= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-x4knwsppMdCyanQ5C4moKQ-1; Thu, 21 Aug 2025 16:10:55 -0400 X-MC-Unique: x4knwsppMdCyanQ5C4moKQ-1 X-Mimecast-MFC-AGG-ID: x4knwsppMdCyanQ5C4moKQ_1755807055 Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-3e58433459bso3551795ab.2 for ; Thu, 21 Aug 2025 13:10:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755807055; x=1756411855; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=An+3TCbux96ebWXl79jkDvpeTXFUup6Liv8QO7JiiR4=; b=irGCZlzpzaOvcQjacsUm5U0jL7mgi0hfi8F/jlPLtg7fCoqAHUFZyUMvmkyC1Mc6VR d/+Ge6sRt+218gzvzHDIygzkYljQaLtA8rJ/C69bqx7nv3kkKzxjQF+FccekBI0+HE+P 1Q+6vhRsRCH4F5JvyjX1Fp9jZ0eon7B9TqqqHwG7mVro3mJJODt7qxMe0aHDQRClFOCs irV4Z0Vn+cy6B7cW7G1yE+onqCC3Z/R2JPrc7/SaHplb5Q1F9UOiBCg2BwXlMVQrnqEg e6AOxCkcmPujs+VMPJir5jFp5I69ga23Y44t29cO++J2lQbZyU8BnIgeGPurtSuvd3Em yQ4A== X-Forwarded-Encrypted: i=1; AJvYcCXGi2xShSye+H8vMUhg3MH9aZTnJSr/8YW1iqqy6O6cuQENfqTZMU90zIj2iFjwDrdCjXY=@vger.kernel.org X-Gm-Message-State: AOJu0YwYtbPIccAdH4KI27gBFS/KE7rP+b0gAJlBZSVvDZ+plOqPejHv woWjlJJyNZccJDAZcjZP/rVYcRqMJ9o0XqetwtNMQ223aFFfYRCj1kUYNP/AZbNCWCp7Nn14PNe UZBGMT8LJc/DMgY/EHwLXkdbDtUF5XI9SHe4K56uotexew8p/wySuJA== X-Gm-Gg: ASbGncu2oxkSh3iNhud0yYVaf7YSJ/SzUqGqXR7cxeNWoO9mR03+gmtHAUPZ7X8ExcV WEWVBbRVqU4MThyYzidUQyxXFY6Q0Hdhm/lU/biMZRBamaM6fscYghAP4o15ShnHvKm4q8CPImD qTrsBJrM/o0Y8M4SdlWy983ekn3Ulo1P7oEUhiIFFND/QEFIy0rfzj7dBpTFn2aLKL+iqVQCeCn eqvzxFDoOgG7Xcn809otzdlHClaR0NIVaUalvbJTgtS88V7NV5pvweP8p3L5xvC92Lqsxo0ggRa FgYw/pAwjClq72916+yQTOIlNQE+OoRudY3CXvs0vUM= X-Received: by 2002:a05:6602:6407:b0:881:982b:9946 with SMTP id ca18e2360f4ac-886bd0f1ad1mr31881839f.1.1755807054505; Thu, 21 Aug 2025 13:10:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7UyEEHnmghSQL6lcVlKCttefDYrWN/3zEcgegYm6NRgpa88y8amc0JBLXw47xKtjo5rcPAA== X-Received: by 2002:a05:6602:6407:b0:881:982b:9946 with SMTP id ca18e2360f4ac-886bd0f1ad1mr31879039f.1.1755807053992; Thu, 21 Aug 2025 13:10:53 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8843f9c3329sm702744239f.19.2025.08.21.13.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Aug 2025 13:10:53 -0700 (PDT) Date: Thu, 21 Aug 2025 14:10:48 -0600 From: Alex Williamson To: David Matlack Cc: Jason Gunthorpe , Aaron Lewis , Adhemerval Zanella , Adithya Jayachandran , Andrew Jones , Ard Biesheuvel , Arnaldo Carvalho de Melo , Bibo Mao , Claudio Imbrenda , Dan Williams , Dave Jiang , dmaengine@vger.kernel.org, Huacai Chen , James Houghton , Joel Granados , Josh Hilke , Kevin Tian , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, "Mike Rapoport (Microsoft)" , Paolo Bonzini , Pasha Tatashin , "Pratik R. Sampat" , Saeed Mahameed , Sean Christopherson , Shuah Khan , Vinicius Costa Gomes , Vipin Sharma , Wei Yang , "Yury Norov [NVIDIA]" Subject: Re: [PATCH 00/33] vfio: Introduce selftests for VFIO Message-ID: <20250821141048.6e16e546.alex.williamson@redhat.com> In-Reply-To: References: <20250620232031.2705638-1-dmatlack@google.com> <20250728102737.5b51e9da.alex.williamson@redhat.com> <20250729222635.GU36037@nvidia.com> <20250818133721.32b660e3.alex.williamson@redhat.com> Organization: Red Hat Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 18 Aug 2025 13:33:52 -0700 David Matlack wrote: > On Mon, Aug 18, 2025 at 12:37=E2=80=AFPM Alex Williamson > wrote: > > > > On Mon, 18 Aug 2025 11:59:39 -0700 > > David Matlack wrote: > > =20 > > > On Thu, Jul 31, 2025 at 1:55=E2=80=AFPM David Matlack wrote: =20 > > > > > > > > On Tue, Jul 29, 2025 at 3:26=E2=80=AFPM Jason Gunthorpe wrote: =20 > > > > > > > > > > On Mon, Jul 28, 2025 at 10:27:37AM -0600, Alex Williamson wrote: = =20 > > > > > > On Fri, 25 Jul 2025 09:47:48 -0700 > > > > > > David Matlack wrote: =20 > > > > > > > I also was curious about your thoughts on maintenance of VFIO > > > > > > > selftests, since I don't think we discussed that in the RFC. = I am > > > > > > > happy to help maintain VFIO selftests in whatever way makes t= he most > > > > > > > sense. For now I added tools/testing/selftests/vfio under the > > > > > > > top-level VFIO section in MAINTAINERS (so you would be the ma= intainer) > > > > > > > and then also added a separate section for VFIO selftests wit= h myself > > > > > > > as a Reviewer (see PATCH 01). Reviewer felt like a better cho= ice than > > > > > > > Maintainer for myself since I am new to VFIO upstream (I've p= rimarily > > > > > > > worked on KVM in the past). =20 > > > > > > > > > > > > Hi David, > > > > > > > > > > > > There's a lot of potential here and I'd like to see it proceed.= =20 > > > > > > > > > > +1 too, I really lack time at the moment to do much with this but= I'm > > > > > half inclined to suggest Alex should say it should be merged in 6 > > > > > weeks (to motivate any reviewing) and we can continue to work on = it > > > > > in-tree. > > > > > > > > > > As they are self tests I think there is alot more value in having= the > > > > > tests than having perfect tests. =20 > > > > > > > > They have been quite useful already within Google. Internally we ha= ve > > > > something almost identical to the RFC and have been using that for > > > > testing our 6.6-based kernel continuously since March. Already they > > > > have caught one (self-inflicted) regression where 1GiB HugeTLB pages > > > > started getting mapped with 2MiB mappings in the IOMMU, and have be= en > > > > very helpful with new development (e.g. Aaron's work, and Live Upda= te > > > > support). > > > > > > > > So I agree, it's probably net positive to merge early and then iter= ate > > > > in-tree. Especially since these are only tests and not e.g. > > > > load-bearing kernel code (although I still want to hold a high bar = for > > > > the selftests code). > > > > > > > > The only patches to hold off merging would be 31-33, since those > > > > should probably go through the KVM tree? And of course we need Acks > > > > for the drivers/dma/{ioat,idxd} changes, but the changes there are > > > > pretty minor. =20 > > > > > > Alex, how would you like to proceed? =20 > > > > I think we need an ack from Shuah for the overall inclusion in > > tools/testing/selftests/ > > > > AFAICT the tools include files don't seem to have any central > > authority, so maybe we just need to chase those ioat/idxd acks, along > > with Shuah's and we can get this rolling and follow-up with the latter > > KVM patches once the base is merged. Thanks, =20 >=20 > Sounds good. >=20 > And yeah, I also don't see any maintainers listed for tools/include/ > or tools/arch/x86/include/. Jason left some comments on the RFC that > reduced the delta in v1, but that's the only feedback I've gotten so > far there. >=20 > I will try emailing Shuah and the ioat/idxd maintainers directly as a > next step, since it has been about 2 months since I posted this series > and we haven't heard anything yet. >=20 > Thanks for the help. I think we have all the required acks now and reviews just suggest some minor patch shuffling, right?. You were also going to switch from reviewer to maintainer of the selftests in MAINTAINERS ;) Are you planning to collect those acks, add the minor changes, drop the trailing KVM changes to come in through the existing kvm selftests and repost? With KVM Forum coming up, I'd like to try to get this squared away and into the vfio next branch by next week. Thanks, Alex