From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9CAE35E4DC for ; Thu, 21 Aug 2025 20:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806879; cv=none; b=nhkASsc9ORtwISHaWlt5BQheHIe20APH4gufibJLO3zNyR3n10x3cqrF9C+iePPYk7Veh4pUTeHWavAIW5vQeO5ugTKWk/ZB2VGLBMGvHKpYRgzubbRikU69SpGT+fNvyOLikmk+kPVcfXqcK2YEFuemya5KygJfiZZusvkzTSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806879; c=relaxed/simple; bh=jeuBd6AEd//7dLky0U/9/K8CcfgAIF74DmeLEQ7xh6M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qScPUmjXt/aV47f8Czz+gtbMMdYeDO1xsSKMge24N7FJ29CzCAK2vF/r7Kigu3Ng0V1aimw24ywbjoAwx7QH4NISvKl7fj8jPFgljbQ7+M9dywa6btfaWM976Owez+oxRh4qcw+L9y4OLfaeBqBYd+Q70tY07beYmXemSIxV4pY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aF4HxFg5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aF4HxFg5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NPs2EdTZ9fd3MpWdb0ATDCa6nUqfGtFMv2uyZP7L+uU=; b=aF4HxFg5JpXNVeLFIw/OyHbb2D9mmnfx5a8LqUFhXI/7ebtYoPoJwpgfA7mJDYQhTXCXmU DYgYfvUFxxAKS6LcrbfmGHWzYOb248B7yUp7f5ejrYXDWfNsNabMRylz1fmQOpYvDl8/nE 13Q5MXPSHqaRtyiK5AfLCwk1fLYn9a0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-kjX7-v-xMVqGAogtm7D5hg-1; Thu, 21 Aug 2025 16:07:55 -0400 X-MC-Unique: kjX7-v-xMVqGAogtm7D5hg-1 X-Mimecast-MFC-AGG-ID: kjX7-v-xMVqGAogtm7D5hg_1755806874 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45a1b00352eso7028835e9.0 for ; Thu, 21 Aug 2025 13:07:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806874; x=1756411674; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NPs2EdTZ9fd3MpWdb0ATDCa6nUqfGtFMv2uyZP7L+uU=; b=G5gqxZfQ6hMB3gUJSJpMHpBQJpF+xvdRpVS9yeU9GRw1LosftrpSoyE319J8BFeKkC /I2Z9wz4OG4dX2gyFwpATlbL1ImueHt8HfbWLS6imjxi+ffTbhMshBNJuDLonYhvIW87 WklBhYYuZ4FXA4tGZGAAewgaDcWY0sWChEDgvLY4uNhHAVLKdZcjP57lgJ4/S1p9cB8X E8YTtcD4SR4A5YXNo9dulFPqoErBGOh/7iQQYQvIzzaN6Tu6JgTE5plH67qkOEMZyoJ2 8Z73+ote+gzW3UB5GOKkr+uK3FJJBDSQnDt7PjTPGNCN9oTgDGR376c8V7ZYDefmjdND jOcQ== X-Forwarded-Encrypted: i=1; AJvYcCWrx787lVMumtIR5a21Dcl7oYzxZ8/fbdtGSJZEl/9qMLH7ZuCWQfe51R0N8o3rFtUeQIU=@vger.kernel.org X-Gm-Message-State: AOJu0YxrRs+Ua/MYzhjTtKjZf6GLTbJLpP7Kon8P45EPjR/tSB4m/rSv 4jmu3VIZ9NbUsww5a9XbAOb755ZDtcOVpA2LMlFhj5liLicBoZtpAjOkmX/sl+VNYoEUUMPnDcO J5cupVMTM51gxZS56VS0ni5cpCi1enPoTLgO0oZbgD/yMtYxGvaqRmA== X-Gm-Gg: ASbGncuXpQ+J9l8ccK9hbZHdc28zOuirJM0G4Cf9tr08DSvHw7OktYibVZgPyHfN2nZ mlBD4l8VW0PTZa7sdnT8fiY8DFVtPVh3jrG3goeQ+uWZr9x7RuG+xSMigU1F76RkSdnxUSvRfQd Q5fn8KfLGPxL/3fdomsVVIZqGrLn9VVsk87pdY6El5oXXQHSdRCjpXQAvgK6Q3V8OKk6IPETuHE HUKgJsvvpcna1cCG5RLL2h3A3bE8yqYAnnXIQpX4X3NFAddbs8Mw6jAqZN1lksOJhqFOM2Gm1Y1 W4KDKGuWce0niBSpnl9A+ln63AM7nSkYE78nKhF4TqHlu8ljGEYNTi59wvdCacL8UF6qArs+nAq h0wrvNnluRJ3f/kGnI2O16w== X-Received: by 2002:a05:600c:1388:b0:459:d451:3364 with SMTP id 5b1f17b1804b1-45b517d40f2mr2554415e9.24.1755806874323; Thu, 21 Aug 2025 13:07:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFo8ikhW4DoWVw60oDeAXqMRvn4UERlcVawLCjGel2pacwRc1R1ONhYVQm5EzuW0YIJQT4FDg== X-Received: by 2002:a05:600c:1388:b0:459:d451:3364 with SMTP id 5b1f17b1804b1-45b517d40f2mr2553905e9.24.1755806873856; Thu, 21 Aug 2025 13:07:53 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c07487a009sm12690403f8f.11.2025.08.21.13.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:07:53 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 17/35] mm/gup: drop nth_page() usage within folio when recording subpages Date: Thu, 21 Aug 2025 22:06:43 +0200 Message-ID: <20250821200701.1329277-18-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nth_page() is no longer required when iterating over pages within a single folio, so let's just drop it when recording subpages. Signed-off-by: David Hildenbrand --- mm/gup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index b2a78f0291273..f017ff6d7d61a 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -491,9 +491,9 @@ static int record_subpages(struct page *page, unsigned long sz, struct page *start_page; int nr; - start_page = nth_page(page, (addr & (sz - 1)) >> PAGE_SHIFT); + start_page = page + ((addr & (sz - 1)) >> PAGE_SHIFT); for (nr = 0; addr != end; nr++, addr += PAGE_SIZE) - pages[nr] = nth_page(start_page, nr); + pages[nr] = start_page + nr; return nr; } @@ -1512,7 +1512,7 @@ static long __get_user_pages(struct mm_struct *mm, } for (j = 0; j < page_increm; j++) { - subpage = nth_page(page, j); + subpage = page + j; pages[i + j] = subpage; flush_anon_page(vma, subpage, start + j * PAGE_SIZE); flush_dcache_page(subpage); -- 2.50.1