From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3225335CEB4 for ; Thu, 21 Aug 2025 20:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806878; cv=none; b=pZFLiXYPUncXaW4jXi2mhBVwK7zXbMK9t52QVTBjkZEyz4ks5gu15M92OmOQozYe0kiFaVLI3D6xcN1fmP+RKHfZNWdbfzQOxE38FvMMHAWyPTlarW07yczY2GwaoE5qKvYSM70AOltpTO2+jL3coj0v7srh21fIjjJjrzSEWFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806878; c=relaxed/simple; bh=ncGz2ZUizfxPtBenqYCMYHXawyPm3K75je3+1YWzFIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bhArbcqUEKQHLALALi/ZfFqlaDchHMy5/awTm/Fr1HNYx/yoPFsaZykKx6QdNRQfJ9IJOFBYuNxMzMzObtI6H7P6fBktF/HcctuBtY0PYjupKIRgydgi0RtBxOgv1bW7PYDakeVGEMv7IU0MUDSRJYP/d4fsXfz0w9qyGRSCKX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OvtW7bhD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OvtW7bhD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G9hzYOZv6YXUN4v1wicJ53nqMhopJDezqYU76J2buLg=; b=OvtW7bhDfUtdNqX+TPGBxXl3U5IT98i+VvnrpvK+bR+vHs5nl8GtB5QjmETvwnx6X7/SEy 51wpzLxt7xPAoqJKtJGOtiG/qDElcGpNUnE9HRVIl/o8s1IYWFnbTv2DDEP3ov74pO+GUZ tsMqrS7vAPux994/8QjyKk70sWUcx08= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-aUDOK9kvNyyy3friZaLbGg-1; Thu, 21 Aug 2025 16:07:31 -0400 X-MC-Unique: aUDOK9kvNyyy3friZaLbGg-1 X-Mimecast-MFC-AGG-ID: aUDOK9kvNyyy3friZaLbGg_1755806850 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45a1b05a59cso9773745e9.1 for ; Thu, 21 Aug 2025 13:07:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806850; x=1756411650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G9hzYOZv6YXUN4v1wicJ53nqMhopJDezqYU76J2buLg=; b=dpbvjjjkY3ihMigbNVSYqJqtX0Nyn1GJ9RWe/2zl2vIQxxLTHOg3FkS1FF4JPYgmPS grII6JGGmPmzD8bQi0t3qBR0nqV11uAG0hv8/JxqaL+DOAgoQL+CFmJAdN/LHBygt7Eo ZFeP/8wLB+Cd+QFog7deyAWTW+8R8uB0ZsKNoBA4I6sulYjxrF06Tp/KfL5hfpfMPggK 0A2wlFYh+e7fVmdcHw8nOpla9FSB4TOCHOPu6zwNBYWWN0pjaHl3YeSL4O3mtDAC6bIU iePdK8icOU4qDbdZukzuD9KXPxl9NONWUZn/FclQHk7Nc6cevDOWiQlvn9PznTl2DvM5 JOqA== X-Forwarded-Encrypted: i=1; AJvYcCWVUa+tLuHPckFpmGUoLY1n9pDCiH1Za2cxFC4G8JejkSARxP1zFekRJeupoEdZ/hJPDog=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+9wK637IEsoYn7r+oG+SCRzQpu7UwsP3Q/VzLDnX45gov3wu6 aK/mTRchvPW82TUJQHGQb3MY3LZ03TkflM7ucCRdypihle+lO+5+4IRU5HTvIV0BqAnvA1Wvek4 yomWVlcdF16F4Htu/2iCIDS3KfNisYJkzvzsi0UhG0g79ynP0BP4eUw== X-Gm-Gg: ASbGncsPx9xKmm0MVG7VT7dV4dX+iDB1teM8bYHgqyIJ4hFKO9MSYqLp947w8Dtsixb zH50PIn55Oix4jmDeDR2NNf0dCKAuMJg5tTqN+ojkOP7huljb05zk/2s8xERyh6ppGqXp29WuGg QuMuZWHBw+idHq6h4gmyP3IRreDvUvfxsEJeAxR1TPgaWoIN2TWPMPm7mkxTB8pDPIfmpU/dT4i eszwcXxaxve7Cup5p4tZucyCrLNUySyQJC3HBVKGPKCad545cfw1o3RGyC7+XuqiavQbP9IsDPf LoHAnv1CMEftKd1sP57y6OBwoDDp9vG7mPn6KNZpOw5dCPz3JhaWLnMCrVHIOZHDsHvjX59sQYq nHH7Yy99wzC3wGQqLkK4HLg== X-Received: by 2002:a05:600c:1548:b0:459:dfde:3329 with SMTP id 5b1f17b1804b1-45b517ddbe2mr2955785e9.31.1755806850005; Thu, 21 Aug 2025 13:07:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHPNoTdvVqQJqQwQf/z0aFpcDb/7HunF1Y6KwbAqmFFF4D3cnAaKEmAnoGbjwE6N5eIepmoyw== X-Received: by 2002:a05:600c:1548:b0:459:dfde:3329 with SMTP id 5b1f17b1804b1-45b517ddbe2mr2955545e9.31.1755806849496; Thu, 21 Aug 2025 13:07:29 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c3a8980ed5sm7242256f8f.16.2025.08.21.13.07.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:07:29 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 08/35] mm/hugetlb: check for unreasonable folio sizes when registering hstate Date: Thu, 21 Aug 2025 22:06:34 +0200 Message-ID: <20250821200701.1329277-9-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Let's check that no hstate that corresponds to an unreasonable folio size is registered by an architecture. If we were to succeed registering, we could later try allocating an unsupported gigantic folio size. Further, let's add a BUILD_BUG_ON() for checking that HUGETLB_PAGE_ORDER is sane at build time. As HUGETLB_PAGE_ORDER is dynamic on powerpc, we have to use a BUILD_BUG_ON_INVALID() to make it compile. No existing kernel configuration should be able to trigger this check: either SPARSEMEM without SPARSEMEM_VMEMMAP cannot be configured or gigantic folios will not exceed a memory section (the case on sparse). Signed-off-by: David Hildenbrand --- mm/hugetlb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 514fab5a20ef8..d12a9d5146af4 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4657,6 +4657,7 @@ static int __init hugetlb_init(void) BUILD_BUG_ON(sizeof_field(struct page, private) * BITS_PER_BYTE < __NR_HPAGEFLAGS); + BUILD_BUG_ON_INVALID(HUGETLB_PAGE_ORDER > MAX_FOLIO_ORDER); if (!hugepages_supported()) { if (hugetlb_max_hstate || default_hstate_max_huge_pages) @@ -4740,6 +4741,7 @@ void __init hugetlb_add_hstate(unsigned int order) } BUG_ON(hugetlb_max_hstate >= HUGE_MAX_HSTATE); BUG_ON(order < order_base_2(__NR_USED_SUBPAGE)); + WARN_ON(order > MAX_FOLIO_ORDER); h = &hstates[hugetlb_max_hstate++]; __mutex_init(&h->resize_lock, "resize mutex", &h->resize_key); h->order = order; -- 2.50.1