kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vfio: selftests: Fix .gitignore for already tracked files
@ 2025-08-28 18:58 David Matlack
  2025-08-29 17:16 ` Alex Williamson
  0 siblings, 1 reply; 2+ messages in thread
From: David Matlack @ 2025-08-28 18:58 UTC (permalink / raw)
  To: Alex Williamson; +Cc: David Matlack, kvm, Shuah Khan, kernel test robot

Fix the rules in tools/testing/selftests/vfio/.gitignore to not ignore
some already tracked files (.gitignore, Makefile, lib/libvfio.mk).

This change should be a no-op, since these files are already tracked by git and
thus git will not ignore updates to them even though they match the ignore
rules in the VFIO selftests .gitignore file.

However, they do generate warnings with W=1, as reported by the kernel test
robot.

  $ KBUILD_EXTRA_WARN=1 scripts/misc-check
  tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files
  tools/testing/selftests/vfio/Makefile: warning: ignored by one of the .gitignore files
  tools/testing/selftests/vfio/lib/libvfio.mk: warning: ignored by one of the .gitignore files

Fix this by explicitly un-ignoring the tracked files.

Fixes: 292e9ee22b0a ("selftests: Create tools/testing/selftests/vfio")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202508280918.rFRyiLEU-lkp@intel.com/
Signed-off-by: David Matlack <dmatlack@google.com>
---
Note, this is on top of the vfio/next branch so I'm not sure if the hash
in the fixes tag is guaranteed to be stable. It might be simpler to
squash this into commit 292e9ee22b0a ("selftests: Create
tools/testing/selftests/vfio") before sending the pull request to Linus.

 tools/testing/selftests/vfio/.gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/vfio/.gitignore b/tools/testing/selftests/vfio/.gitignore
index 6d9381d60172..7fadc19d3bca 100644
--- a/tools/testing/selftests/vfio/.gitignore
+++ b/tools/testing/selftests/vfio/.gitignore
@@ -5,3 +5,6 @@
 !*.h
 !*.S
 !*.sh
+!*.mk
+!.gitignore
+!Makefile

base-commit: 9f3acb3d9a1872e2fa36af068ca2e93a8a864089
-- 
2.51.0.338.gd7d06c2dae-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] vfio: selftests: Fix .gitignore for already tracked files
  2025-08-28 18:58 [PATCH] vfio: selftests: Fix .gitignore for already tracked files David Matlack
@ 2025-08-29 17:16 ` Alex Williamson
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2025-08-29 17:16 UTC (permalink / raw)
  To: David Matlack; +Cc: kvm, Shuah Khan, kernel test robot

On Thu, 28 Aug 2025 18:58:14 +0000
David Matlack <dmatlack@google.com> wrote:

> Fix the rules in tools/testing/selftests/vfio/.gitignore to not ignore
> some already tracked files (.gitignore, Makefile, lib/libvfio.mk).
> 
> This change should be a no-op, since these files are already tracked by git and
> thus git will not ignore updates to them even though they match the ignore
> rules in the VFIO selftests .gitignore file.
> 
> However, they do generate warnings with W=1, as reported by the kernel test
> robot.
> 
>   $ KBUILD_EXTRA_WARN=1 scripts/misc-check
>   tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files
>   tools/testing/selftests/vfio/Makefile: warning: ignored by one of the .gitignore files
>   tools/testing/selftests/vfio/lib/libvfio.mk: warning: ignored by one of the .gitignore files
> 
> Fix this by explicitly un-ignoring the tracked files.
> 
> Fixes: 292e9ee22b0a ("selftests: Create tools/testing/selftests/vfio")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508280918.rFRyiLEU-lkp@intel.com/
> Signed-off-by: David Matlack <dmatlack@google.com>
> ---
> Note, this is on top of the vfio/next branch so I'm not sure if the hash
> in the fixes tag is guaranteed to be stable. It might be simpler to
> squash this into commit 292e9ee22b0a ("selftests: Create
> tools/testing/selftests/vfio") before sending the pull request to Linus.
> 
>  tools/testing/selftests/vfio/.gitignore | 3 +++
>  1 file changed, 3 insertions(+)

Applied to vfio next branch for v6.18.  Let's consider the commit
hashes sufficiently stable for now.  In the off chance that I need to
back something out, I can fix them.  I think it's useful for the log
to have the fixes separate, as evidenced by being able to reference
Sean's similar fix.  Thanks,

Alex


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-29 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-28 18:58 [PATCH] vfio: selftests: Fix .gitignore for already tracked files David Matlack
2025-08-29 17:16 ` Alex Williamson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).