From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3949923BD1B for ; Fri, 29 Aug 2025 06:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756448996; cv=none; b=XQMsjdZoyqGi+eaYjckssskerX00VYWxQHTkmwAl3hydJmAhsdP1YbogfwmPHHOVfuzLa9IVkq/T0qtVXumywejOkYzNkXvG2Knq2Vx323ueDArJpexdnR9ml+oJkR4XuB16io7Sk91tXXyYCTVG3jnyY2dD1nfoKVAcLSN5TpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756448996; c=relaxed/simple; bh=tGwSjGcSe128TtD7AHOwtP4PhJjbYMmvmFE0Ow3n7qo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gwp3UmFxIhaKtUZRkrzmkhKfaahX7R7mbtpAQNNoMiILFSuNdGm86oUlDLnPmsiPaioqlLxO0QY8cDu+9hqE7FFdbFHJKc6HrK1CHkX1dfopI9SfpzGmNhbPwy6qknCEUdUSIG/54WpyKj+Yy5u1xLMXbNRkp76bDvNjTTkLc8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DY+dr7/5; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DY+dr7/5" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-248a638dbbeso15830835ad.2 for ; Thu, 28 Aug 2025 23:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756448994; x=1757053794; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CokGLX1/yeX4DJMWAz1LmKt9I3G7o4FsQeoqSBuvVPY=; b=DY+dr7/5AYifsOB2jkD7YJAsc3EkrlaD87ZXXamuk9eRkkMJ9bpnQ9NtXMZ/m51IKQ W/hX2Lw6m0Rt0MhX1aPSSTW9JLm86s5TQ2RzZMEmZ6dh+fP2B/0WD9sedlLY6U8vdemg vgJUR7AoHH7XBq150ld8OwdWMrwMMWJaGceCKAQYyBPtm8a0Smyv6A0n34uMtGDaORO2 4mlx/LccHp7VeojfM7fpq5uP73YyvyuPTazRWuYKAV0afPy8ZOr5NJXQbO3+97peg41E 17fE3BWXly2lo/ybsuFDeSDci0+y8pU02yXE3h2KSXlPDpZfYhFvtBGsh6qu/Oee6ZBB Xd7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756448994; x=1757053794; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CokGLX1/yeX4DJMWAz1LmKt9I3G7o4FsQeoqSBuvVPY=; b=Q4Fb35Hj7tirp0HjOjgrAs4SDbqqtVtYn8a97OAYj9mgb8G+cdwZthsOgMi0BmZv6G d7YR0BfLV+VChcLksbl/WC432e3aM27tudexcTeGKBWKHuLMMfHASFoso2r4Xw6rPrf3 KJC/XDj8WABqpeGjp8NnQFBFS+KRQ7QrJ6n6HyduVB/JK7YSfcY7odPF/6dsuGcxhOH6 6PrvwHhoumIdGyn4QaupRjeV/+TmQetqhMB/SM4An8lheG3djVeMUPKDqE2S6LZz+rec CxhhNfdzgH8Yjz0XbpGuA7zivqOcTIjZ8FJoFwvwgB4hMrPeOXGrBpyykBTIDvwFhX99 tLlw== X-Forwarded-Encrypted: i=1; AJvYcCXT5uhBerBAJ27h8PJqs5lUSThqRylujHLwjrzNw/NTxWB9yetIAUBGKVtfvsckaOfigFE=@vger.kernel.org X-Gm-Message-State: AOJu0YwgcDwhRHONZzjjMlm5qu+bjxuYXLe7FfuOIM0LU7pNaz4Bgrey RraUzP9A6xh14YBNipo1/zhPmJyhjEjwM3h6wQ+lftodK6/Cvn6+qnFw5YaumX01+VE= X-Gm-Gg: ASbGnculJVGbtMLlDC+q5trWNnrkqMLQ31MthknT1jnlDNr/kNU7JJh2Je8PT+Y3nfV MUbXEj8CMlQhwDc/oCCLfwgs3u3uIcl4Wi4rdXuUY0zZPDqZ+xSm49kQ1PIwvRthjsJy/sI57eP D3oIFTR8cGP3fY24Y2bkZ1djA1aAOresieaI1j5AS2Gnji07prqxx9jN0dPgw/SWHpdyFVU8UJI XYJufzuRKTyTvvikID7VgjjSyasm9KpvMpTgDGMQNcQipKJ7QL3OwJYxbTYcFcfVGcUJPV2+wwz du5DdFDBnxpBtSlUioEBljwtYHREfPXx2GRyV5wsSbkZmt8cytOuwB5ajA5MyybL0HecjLAAIay PYlX+ROR7ukkFOaI1BLEF9ECB X-Google-Smtp-Source: AGHT+IFbX3s0aoe3pqEivfWfaakWxvchfFFbfgXfyIlcOqslqMMZIBk7FeaK/V2UaSwtVV106XuK4Q== X-Received: by 2002:a17:902:ec89:b0:245:fa00:6e25 with SMTP id d9443c01a7336-2462ef1ea0bmr386065885ad.28.1756448994426; Thu, 28 Aug 2025 23:29:54 -0700 (PDT) Received: from localhost ([122.172.87.165]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24903705be3sm14571325ad.18.2025.08.28.23.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 23:29:53 -0700 (PDT) Date: Fri, 29 Aug 2025 11:59:51 +0530 From: Viresh Kumar To: Zihuan Zhang Cc: "Rafael J . wysocki" , Catalin Marinas , Will Deacon , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Markus Mayer , Florian Fainelli , Srinivas Pandruvada , Madhavan Srinivasan , Michael Ellerman , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Daniel Lezcano , Sascha Hauer , Shawn Guo , Eduardo Valentin , Keerthy , Matthias Brugger , AngeloGioacchino Del Regno , zhenglifeng , "H . Peter Anvin" , Zhang Rui , Len Brown , Nicholas Piggin , Christophe Leroy , Lukasz Luba , Pengutronix Kernel Team , Beata Michalska , Fabio Estevam , Pavel Machek , Sumit Gupta , Prasanna Kumar T S M , Sudeep Holla , Yicong Yang , linux-pm@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, linux-acpi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/18] cpufreq: tegra186: Use __free(put_cpufreq_policy) for policy reference Message-ID: <20250829062951.ximauv2so442q4gv@vireshk-i7> References: <20250827023202.10310-1-zhangzihuan@kylinos.cn> <20250827023202.10310-12-zhangzihuan@kylinos.cn> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250827023202.10310-12-zhangzihuan@kylinos.cn> On 27-08-25, 10:31, Zihuan Zhang wrote: > Replace the manual cpufreq_cpu_put() with __free(put_cpufreq_policy) > annotation for policy references. This reduces the risk of reference > counting mistakes and aligns the code with the latest kernel style. > > No functional change intended. > > Signed-off-by: Zihuan Zhang > --- > drivers/cpufreq/tegra186-cpufreq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c > index cbabb726c664..4d71e262a729 100644 > --- a/drivers/cpufreq/tegra186-cpufreq.c > +++ b/drivers/cpufreq/tegra186-cpufreq.c > @@ -105,7 +105,7 @@ static unsigned int tegra186_cpufreq_get(unsigned int cpu) > { > struct tegra186_cpufreq_data *data = cpufreq_get_driver_data(); > struct tegra186_cpufreq_cluster *cluster; > - struct cpufreq_policy *policy; > + struct cpufreq_policy *policy __free(put_cpufreq_policy); > unsigned int edvd_offset, cluster_id; > u32 ndiv; > > @@ -117,7 +117,6 @@ static unsigned int tegra186_cpufreq_get(unsigned int cpu) > ndiv = readl(data->regs + edvd_offset) & EDVD_CORE_VOLT_FREQ_F_MASK; > cluster_id = data->cpus[policy->cpu].bpmp_cluster_id; > cluster = &data->clusters[cluster_id]; > - cpufreq_cpu_put(policy); > > return (cluster->ref_clk_khz * ndiv) / cluster->div; Merged with: diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c index 4d71e262a729..4270686fc3e3 100644 --- a/drivers/cpufreq/tegra186-cpufreq.c +++ b/drivers/cpufreq/tegra186-cpufreq.c @@ -103,13 +103,12 @@ static int tegra186_cpufreq_set_target(struct cpufreq_policy *policy, static unsigned int tegra186_cpufreq_get(unsigned int cpu) { + struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu); struct tegra186_cpufreq_data *data = cpufreq_get_driver_data(); struct tegra186_cpufreq_cluster *cluster; - struct cpufreq_policy *policy __free(put_cpufreq_policy); unsigned int edvd_offset, cluster_id; u32 ndiv; - policy = cpufreq_cpu_get(cpu); if (!policy) return 0; -- viresh