From: Sagi Shahar <sagis@google.com>
To: linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Ackerley Tng <ackerleytng@google.com>,
Ryan Afranji <afranji@google.com>,
Andrew Jones <ajones@ventanamicro.com>,
Isaku Yamahata <isaku.yamahata@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Sagi Shahar <sagis@google.com>,
Roger Wang <runanwang@google.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
Oliver Upton <oliver.upton@linux.dev>,
"Pratik R. Sampat" <pratikrajesh.sampat@amd.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Ira Weiny <ira.weiny@intel.com>, Chao Gao <chao.gao@intel.com>,
Chenyi Qiang <chenyi.qiang@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: [PATCH v10 10/21] KVM: selftests: Set up TDX boot parameters region
Date: Wed, 3 Sep 2025 23:54:40 -0700 [thread overview]
Message-ID: <20250904065453.639610-11-sagis@google.com> (raw)
In-Reply-To: <20250904065453.639610-1-sagis@google.com>
Allocate memory for TDX boot parameters and define the utility functions
necessary to fill this memory with the boot parameters.
Co-developed-by: Ackerley Tng <ackerleytng@google.com>
Signed-off-by: Ackerley Tng <ackerleytng@google.com>
Signed-off-by: Sagi Shahar <sagis@google.com>
---
.../selftests/kvm/include/x86/tdx/tdx_util.h | 4 +
.../selftests/kvm/lib/x86/tdx/tdx_util.c | 75 +++++++++++++++++++
2 files changed, 79 insertions(+)
diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
index ec05bcd59145..dafdc7e46abe 100644
--- a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
+++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h
@@ -12,5 +12,9 @@ static inline bool is_tdx_vm(struct kvm_vm *vm)
}
void vm_tdx_setup_boot_code_region(struct kvm_vm *vm);
+void vm_tdx_setup_boot_parameters_region(struct kvm_vm *vm, uint32_t nr_runnable_vcpus);
+void vm_tdx_load_common_boot_parameters(struct kvm_vm *vm);
+void vm_tdx_load_vcpu_boot_parameters(struct kvm_vm *vm, struct kvm_vcpu *vcpu);
+void vm_tdx_set_vcpu_entry_point(struct kvm_vcpu *vcpu, void *guest_code);
#endif // SELFTESTS_TDX_TDX_UTIL_H
diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
index a1cf12de9d56..ff61333bc848 100644
--- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
+++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c
@@ -5,10 +5,12 @@
#include "kvm_util.h"
#include "processor.h"
#include "tdx/td_boot.h"
+#include "tdx/td_boot_asm.h"
#include "tdx/tdx_util.h"
/* Arbitrarily selected to avoid overlaps with anything else */
#define TD_BOOT_CODE_SLOT 20
+#define TD_BOOT_PARAMETERS_SLOT 21
#define X86_RESET_VECTOR 0xfffffff0ul
#define X86_RESET_VECTOR_SIZE 16
@@ -52,3 +54,76 @@ void vm_tdx_setup_boot_code_region(struct kvm_vm *vm)
hva[1] = 256 - 2 - TD_BOOT_CODE_SIZE;
hva[2] = 0xcc;
}
+
+void vm_tdx_setup_boot_parameters_region(struct kvm_vm *vm, uint32_t nr_runnable_vcpus)
+{
+ size_t boot_params_size =
+ sizeof(struct td_boot_parameters) +
+ nr_runnable_vcpus * sizeof(struct td_per_vcpu_parameters);
+ int npages = DIV_ROUND_UP(boot_params_size, PAGE_SIZE);
+ vm_paddr_t gpa;
+
+ vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS,
+ TD_BOOT_PARAMETERS_GPA,
+ TD_BOOT_PARAMETERS_SLOT, npages,
+ KVM_MEM_GUEST_MEMFD);
+ gpa = vm_phy_pages_alloc(vm, npages, TD_BOOT_PARAMETERS_GPA, TD_BOOT_PARAMETERS_SLOT);
+ TEST_ASSERT(gpa == TD_BOOT_PARAMETERS_GPA, "Failed vm_phy_pages_alloc\n");
+
+ virt_map(vm, TD_BOOT_PARAMETERS_GPA, TD_BOOT_PARAMETERS_GPA, npages);
+}
+
+void vm_tdx_load_common_boot_parameters(struct kvm_vm *vm)
+{
+ struct td_boot_parameters *params =
+ addr_gpa2hva(vm, TD_BOOT_PARAMETERS_GPA);
+ uint32_t cr4;
+
+ TEST_ASSERT_EQ(vm->mode, VM_MODE_PXXV48_4K);
+
+ cr4 = kvm_get_default_cr4();
+
+ /* TDX spec 11.6.2: CR4 bit MCE is fixed to 1 */
+ cr4 |= X86_CR4_MCE;
+
+ /* Set this because UEFI also sets this up, to handle XMM exceptions */
+ cr4 |= X86_CR4_OSXMMEXCPT;
+
+ /* TDX spec 11.6.2: CR4 bit VMXE and SMXE are fixed to 0 */
+ cr4 &= ~(X86_CR4_VMXE | X86_CR4_SMXE);
+
+ /* Set parameters! */
+ params->cr0 = kvm_get_default_cr0();
+ params->cr3 = vm->pgd;
+ params->cr4 = cr4;
+ params->idtr.base = vm->arch.idt;
+ params->idtr.limit = kvm_get_default_idt_limit();
+ params->gdtr.base = vm->arch.gdt;
+ params->gdtr.limit = kvm_get_default_gdt_limit();
+
+ TEST_ASSERT(params->cr0 != 0, "cr0 should not be 0");
+ TEST_ASSERT(params->cr3 != 0, "cr3 should not be 0");
+ TEST_ASSERT(params->cr4 != 0, "cr4 should not be 0");
+ TEST_ASSERT(params->gdtr.base != 0, "gdt base address should not be 0");
+ TEST_ASSERT(params->idtr.base != 0, "idt base address should not be 0");
+}
+
+void vm_tdx_load_vcpu_boot_parameters(struct kvm_vm *vm, struct kvm_vcpu *vcpu)
+{
+ struct td_boot_parameters *params =
+ addr_gpa2hva(vm, TD_BOOT_PARAMETERS_GPA);
+ struct td_per_vcpu_parameters *vcpu_params =
+ ¶ms->per_vcpu[vcpu->id];
+
+ vcpu_params->esp_gva = kvm_allocate_vcpu_stack(vm);
+}
+
+void vm_tdx_set_vcpu_entry_point(struct kvm_vcpu *vcpu, void *guest_code)
+{
+ struct td_boot_parameters *params =
+ addr_gpa2hva(vcpu->vm, TD_BOOT_PARAMETERS_GPA);
+ struct td_per_vcpu_parameters *vcpu_params =
+ ¶ms->per_vcpu[vcpu->id];
+
+ vcpu_params->guest_code = (uint64_t)guest_code;
+}
--
2.51.0.338.gd7d06c2dae-goog
next prev parent reply other threads:[~2025-09-04 6:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 6:54 [PATCH v10 00/21] TDX KVM selftests Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 01/21] KVM: selftests: Allocate pgd in virt_map() as necessary Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 02/21] KVM: selftests: Expose functions to get default sregs values Sagi Shahar
2025-09-04 9:23 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 03/21] KVM: selftests: Expose function to allocate guest vCPU stack Sagi Shahar
2025-09-04 9:27 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 04/21] KVM: selftests: Update kvm_init_vm_address_properties() for TDX Sagi Shahar
2025-09-05 5:19 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 05/21] KVM: selftests: Expose segment definitons to assembly files Sagi Shahar
2025-09-05 5:24 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 06/21] KVM: selftests: Add kbuild definitons Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 07/21] KVM: selftests: Define structs to pass parameters to TDX boot code Sagi Shahar
2025-09-08 7:19 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 08/21] KVM: selftests: Add " Sagi Shahar
2025-09-08 7:33 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 09/21] KVM: selftests: Set up TDX boot code region Sagi Shahar
2025-09-08 7:39 ` Binbin Wu
2025-09-04 6:54 ` Sagi Shahar [this message]
2025-09-08 8:07 ` [PATCH v10 10/21] KVM: selftests: Set up TDX boot parameters region Binbin Wu
2025-09-25 17:13 ` Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 11/21] KVM: selftests: Add helper to initialize TDX VM Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 12/21] KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs' attribute configuration Sagi Shahar
2025-09-08 9:22 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 13/21] KVM: selftests: Add helpers to init TDX memory and finalize VM Sagi Shahar
2025-09-10 6:49 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 14/21] KVM: selftests: Call TDX init when creating a new TDX vm Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 15/21] KVM: selftests: Setup memory regions for TDX on vm creation Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 16/21] KVM: selftests: Call KVM_TDX_INIT_VCPU when creating a new TDX vcpu Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 17/21] KVM: selftests: Set entry point for TDX guest code Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 18/21] KVM: selftests: Add support for TDX TDCALL from guest Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 19/21] KVM: selftests: Add wrapper for TDX MMIO " Sagi Shahar
2025-09-04 6:54 ` [PATCH v10 20/21] KVM: selftests: Add ucall support for TDX Sagi Shahar
2025-09-10 7:46 ` Binbin Wu
2025-09-04 6:54 ` [PATCH v10 21/21] KVM: selftests: Add TDX lifecycle test Sagi Shahar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904065453.639610-11-sagis@google.com \
--to=sagis@google.com \
--cc=ackerleytng@google.com \
--cc=afranji@google.com \
--cc=ajones@ventanamicro.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=chenyi.qiang@intel.com \
--cc=erdemaktas@google.com \
--cc=ira.weiny@intel.com \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=pratikrajesh.sampat@amd.com \
--cc=reinette.chatre@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=runanwang@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox