From: John Allen <john.allen@amd.com>
To: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<x86@kernel.org>, <seanjc@google.com>, <pbonzini@redhat.com>,
<dave.hansen@intel.com>
Cc: <rick.p.edgecombe@intel.com>, <mlevitsk@redhat.com>,
<weijiang.yang@intel.com>, <chao.gao@intel.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <hpa@zytor.com>,
<mingo@redhat.com>, <tglx@linutronix.de>,
<thomas.lendacky@amd.com>, John Allen <john.allen@amd.com>
Subject: [PATCH v4 4/5] KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernel
Date: Mon, 8 Sep 2025 20:17:49 +0000 [thread overview]
Message-ID: <20250908201750.98824-5-john.allen@amd.com> (raw)
In-Reply-To: <20250908201750.98824-1-john.allen@amd.com>
When a guest issues a cpuid instruction for Fn0000000D_x0B_{x00,x01}, KVM will
be intercepting the CPUID instruction and will need to access the guest
MSR_IA32_XSS value. For SEV-ES, the XSS value is encrypted and needs to be
included in the GHCB to be visible to the hypervisor.
Signed-off-by: John Allen <john.allen@amd.com>
---
v2:
- Omit passing through XSS as this has already been properly
implemented in a26b7cd22546 ("KVM: SEV: Do not intercept
accesses to MSR_IA32_XSS for SEV-ES guests")
v3:
- Move guest kernel GHCB_ACCESSORS definition to new series.
v4:
- Change logic structure to be more intuitive.
---
arch/x86/kvm/svm/sev.c | 5 +++++
arch/x86/kvm/svm/svm.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index f4381878a9e5..33c42dd853b3 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -3310,6 +3310,11 @@ static void sev_es_sync_from_ghcb(struct vcpu_svm *svm)
vcpu->arch.cpuid_dynamic_bits_dirty = true;
}
+ if (kvm_ghcb_xss_is_valid(svm)) {
+ vcpu->arch.ia32_xss = ghcb_get_xss(ghcb);
+ vcpu->arch.cpuid_dynamic_bits_dirty = true;
+ }
+
/* Copy the GHCB exit information into the VMCB fields */
exit_code = ghcb_get_sw_exit_code(ghcb);
control->exit_code = lower_32_bits(exit_code);
diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h
index 3c7f208b7935..552c58b050f1 100644
--- a/arch/x86/kvm/svm/svm.h
+++ b/arch/x86/kvm/svm/svm.h
@@ -935,5 +935,6 @@ DEFINE_KVM_GHCB_ACCESSORS(sw_exit_info_1)
DEFINE_KVM_GHCB_ACCESSORS(sw_exit_info_2)
DEFINE_KVM_GHCB_ACCESSORS(sw_scratch)
DEFINE_KVM_GHCB_ACCESSORS(xcr0)
+DEFINE_KVM_GHCB_ACCESSORS(xss)
#endif
--
2.47.3
next prev parent reply other threads:[~2025-09-08 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 20:17 [PATCH v4 0/5] Enable Shadow Stack Virtualization for SVM John Allen
2025-09-08 20:17 ` [PATCH v4 1/5] KVM: x86: SVM: Emulate reads and writes to shadow stack MSRs John Allen
2025-09-12 22:55 ` Sean Christopherson
2025-09-08 20:17 ` [PATCH v4 2/5] KVM: x86: SVM: Update dump_vmcb with shadow stack save area additions John Allen
2025-09-08 20:17 ` [PATCH v4 3/5] KVM: x86: SVM: Pass through shadow stack MSRs John Allen
2025-09-08 20:17 ` John Allen [this message]
2025-09-10 21:24 ` [PATCH v4 4/5] KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernel Sean Christopherson
2025-09-11 15:23 ` John Allen
2025-09-08 20:17 ` [PATCH v4 5/5] KVM: SVM: Enable shadow stack virtualization for SVM John Allen
2025-09-12 22:54 ` [PATCH v4 0/5] Enable Shadow Stack Virtualization " Sean Christopherson
2025-09-15 14:52 ` John Allen
2025-09-15 16:46 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908201750.98824-5-john.allen@amd.com \
--to=john.allen@amd.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=weijiang.yang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox