* [PATCH] KVM: s390: Remove unused return variable in kvm_arch_vcpu_ioctl_set_fpu
@ 2025-09-16 13:12 Thorsten Blum
2025-10-01 9:32 ` Janosch Frank
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-09-16 13:12 UTC (permalink / raw)
To: Christian Borntraeger, Janosch Frank, Claudio Imbrenda,
David Hildenbrand, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Sven Schnelle
Cc: Thorsten Blum, kvm, linux-s390, linux-kernel
kvm_arch_vcpu_ioctl_set_fpu() always returns 0 and the local return
variable 'ret' is not used anymore. Remove it.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/s390/kvm/kvm-s390.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index bf6fa8b9ca73..f61cb8a5ea77 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -4367,8 +4367,6 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
{
- int ret = 0;
-
vcpu_load(vcpu);
vcpu->run->s.regs.fpc = fpu->fpc;
@@ -4379,7 +4377,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
memcpy(vcpu->run->s.regs.fprs, &fpu->fprs, sizeof(fpu->fprs));
vcpu_put(vcpu);
- return ret;
+ return 0;
}
int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] KVM: s390: Remove unused return variable in kvm_arch_vcpu_ioctl_set_fpu
2025-09-16 13:12 [PATCH] KVM: s390: Remove unused return variable in kvm_arch_vcpu_ioctl_set_fpu Thorsten Blum
@ 2025-10-01 9:32 ` Janosch Frank
0 siblings, 0 replies; 2+ messages in thread
From: Janosch Frank @ 2025-10-01 9:32 UTC (permalink / raw)
To: Thorsten Blum, Christian Borntraeger, Claudio Imbrenda,
David Hildenbrand, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Sven Schnelle
Cc: kvm, linux-s390, linux-kernel
On 9/16/25 3:12 PM, Thorsten Blum wrote:
> kvm_arch_vcpu_ioctl_set_fpu() always returns 0 and the local return
> variable 'ret' is not used anymore. Remove it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Thanks, picked
> ---
> arch/s390/kvm/kvm-s390.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index bf6fa8b9ca73..f61cb8a5ea77 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -4367,8 +4367,6 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
>
> int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
> {
> - int ret = 0;
> -
> vcpu_load(vcpu);
>
> vcpu->run->s.regs.fpc = fpu->fpc;
> @@ -4379,7 +4377,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
> memcpy(vcpu->run->s.regs.fprs, &fpu->fprs, sizeof(fpu->fprs));
>
> vcpu_put(vcpu);
> - return ret;
> + return 0;
> }
>
> int kvm_arch_vcpu_ioctl_get_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-01 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-16 13:12 [PATCH] KVM: s390: Remove unused return variable in kvm_arch_vcpu_ioctl_set_fpu Thorsten Blum
2025-10-01 9:32 ` Janosch Frank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox