public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Naveen N Rao <naveen@kernel.org>
Subject: [PATCH v3 3/6] KVM: SVM: Always print "AVIC enabled" separately, even when force enabled
Date: Thu, 18 Sep 2025 17:21:33 -0700	[thread overview]
Message-ID: <20250919002136.1349663-4-seanjc@google.com> (raw)
In-Reply-To: <20250919002136.1349663-1-seanjc@google.com>

Print the customary "AVIC enabled" informational message even when AVIC is
force enabled on a system that doesn't advertise supported for AVIC in
CPUID, as not printing the standard message can confuse users and tools.

Opportunistically clean up the scary message when AVIC is force enabled,
but keep it as separate message so that it is printed at level "warn",
versus the standard message only being printed for level "info".

Suggested-by: Naveen N Rao <naveen@kernel.org>
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 arch/x86/kvm/svm/avic.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
index 683411442476..bafef2f75af2 100644
--- a/arch/x86/kvm/svm/avic.c
+++ b/arch/x86/kvm/svm/avic.c
@@ -1167,16 +1167,15 @@ bool __init avic_hardware_setup(struct kvm_x86_ops *svm_ops)
 		return false;
 	}
 
-	if (boot_cpu_has(X86_FEATURE_AVIC)) {
-		pr_info("AVIC enabled\n");
-	} else if (force_avic) {
-		/*
-		 * Some older systems does not advertise AVIC support.
-		 * See Revision Guide for specific AMD processor for more detail.
-		 */
-		pr_warn("AVIC is not supported in CPUID but force enabled");
-		pr_warn("Your system might crash and burn");
-	}
+	/*
+	 * Print a scary message if AVIC is force enabled to make it abundantly
+	 * clear that ignoring CPUID could have repercussions.  See Revision
+	 * Guide for specific AMD processor for more details.
+	 */
+	if (!boot_cpu_has(X86_FEATURE_AVIC))
+		pr_warn("AVIC unsupported in CPUID but force enabled, your system might crash and burn\n");
+
+	pr_info("AVIC enabled\n");
 
 	/* AVIC is a prerequisite for x2AVIC. */
 	x2avic_enabled = boot_cpu_has(X86_FEATURE_X2AVIC);
-- 
2.51.0.470.ga7dc726c21-goog


  parent reply	other threads:[~2025-09-19  0:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19  0:21 [PATCH v3 0/6] KVM: SVM: Enable AVIC for Zen4+ (if x2AVIC) Sean Christopherson
2025-09-19  0:21 ` [PATCH v3 1/6] KVM: SVM: Move x2AVIC MSR interception helper to avic.c Sean Christopherson
2025-09-19  9:35   ` Naveen N Rao
2025-09-19  0:21 ` [PATCH v3 2/6] KVM: SVM: Update "APICv in x2APIC without x2AVIC" in avic.c, not svm.c Sean Christopherson
2025-09-19  9:42   ` Naveen N Rao
2025-09-19 14:21     ` Sean Christopherson
2025-09-22  7:08       ` Chao Gao
2025-09-19  0:21 ` Sean Christopherson [this message]
2025-09-19  9:52   ` [PATCH v3 3/6] KVM: SVM: Always print "AVIC enabled" separately, even when force enabled Naveen N Rao
2025-09-19  0:21 ` [PATCH v3 4/6] KVM: SVM: Don't advise the user to do force_avic=y (when x2AVIC is detected) Sean Christopherson
2025-09-19 10:26   ` Naveen N Rao
2025-09-19  0:21 ` [PATCH v3 5/6] KVM: SVM: Move global "avic" variable to avic.c Sean Christopherson
2025-09-19 10:31   ` Naveen N Rao
2025-09-19 14:44     ` Sean Christopherson
2025-09-19 18:27       ` Naveen N Rao
2025-09-19  0:21 ` [PATCH v3 6/6] KVM: SVM: Enable AVIC by default for Zen4+ if x2AVIC is support Sean Christopherson
2025-09-19 10:37   ` Naveen N Rao
2025-09-19 21:56     ` Sean Christopherson
2025-09-19 10:42 ` [PATCH v3 0/6] KVM: SVM: Enable AVIC for Zen4+ (if x2AVIC) Naveen N Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250919002136.1349663-4-seanjc@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen@kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox