Re: [PATCH v3 5/5] KVM: SVM: Add Page modification logging support

Nikunj A. Dadhania
2025-09-29T10:35:32Z

On 9/29/2025 4:00 PM, Huang, Kai wrote:
>>
>> I tested the above patch and it needed few SVM and x86 changes, here is a
>> diff on top of your patch that works on SVM:
>
> Ah thanks! I did build test but not sure why I missed some changes.
>
> [...]
>
>> --- a/arch/x86/kvm/svm/svm.h
>> +++ b/arch/x86/kvm/svm/svm.h
>> @@ -51,6 +51,7 @@ extern bool intercept_smi;
>> extern bool x2avic_enabled;
>> extern bool vnmi;
>> extern int lbrv;
>> +extern bool __read_mostly enable_pml;
>
> I think this could be in <asm/kvm_host.h>, similar to enable_apicv?
>
> VMX code needs it too.

Sure, will move it there.

Regards
Nikunj