Re: [PATCH v3 5/5] KVM: SVM: Add Page modification logging support

Nikunj A. Dadhania
2025-09-30T05:46:48Z

On 9/29/2025 7:11 AM, Huang, Kai wrote:
>
> There are duplicated code between SVM and VMX for the above chunks. The
> logic of marking 'update_cpu_dirty_logging' as pending when vCPU is in L2
> mode and then actually updating the CPU dirty logging when existing from
> L2 to L1 can be made common, as both SVM and VMX share the same logic.
>
> How about below diff [*]? It could be split into multiple patches (e.g.,
> one to move the code around 'update_cpu_dirty_logging_pending' from VMX to
> x86 common, and the other one to apply SVM changes on top of that).
>
> Build test only .. I plan to have a test as well (needing to setup testing
> environment) but it would be great to see whether it works at SVM side.
>
> [*] The diff (also attached):
>
Hi Kai,

Thank you for the patch to move the nested CPU dirty logging logic to common code. I have a couple of questions:

1) Should I include this patch as part of my PML series and post it with v4, or would you prefer to submit it separately?

2) Since you authored this patch, may I add your From/Signed-off-by line when including it in the series?

Please let me know your preference. I'm happy to integrate it into the series or wait for you to submit it independently.

Regards,
Nikunj