From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CC4C14A91 for ; Sat, 27 Sep 2025 20:37:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759005426; cv=none; b=diAgs0APCDSoHadJnkXSaSmY3j8FmM5/qFCxtntfNJfjZh4tak+UROknqLzXWP3h9DgraeM2yp0sd+2WHJSC5Kv8takAQdEAhwgRsJ7Dqo3H9qoJNgvKdsbnc2uS0vfp81XKXLPcjlmovA+QFiNEUhmGqsSonXAj9GwC4MTTb1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759005426; c=relaxed/simple; bh=sfYVx76JGrxHqHCOgMqEADM4JLCw9ZLaEQjj51LNMr4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d+WJBByJyHkYfYE0iCz/diIERlXXV1cRbmAYh6IxeCMs8jJxYDt4X0BeErB3/RwM12WcgFcWIb1mYDLbwY35cF5/8mf2XyNgwOeDoBsd2Y7N9Rlv8KncZ6cEvDTE91SEoFm3wtBFaXANP900W5EFtH7p/Rnj8k3PYRSumAtjAew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wrhp2NKy; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wrhp2NKy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759005423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NSL50vU3vn5zRDcV8odSyRV3zrATLUSrY+rAICw6mik=; b=Wrhp2NKyOLUs0qrzYjw9/JK1kyH1EpsJuuUqOCePjqL1aMJ+4z9DekGrsss6MDjiM/67jL t6i0eo/W7qPtzdus++75K2UC63XgBXMd2UzNR6bJczlQp8zCFuFvFdqSk4hZG6Bj7SIou/ uLsim3RD5TsH61nRd9D07T9B69eLeMs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-Nz_GCEDfM22GyZW3c5_mTA-1; Sat, 27 Sep 2025 16:37:01 -0400 X-MC-Unique: Nz_GCEDfM22GyZW3c5_mTA-1 X-Mimecast-MFC-AGG-ID: Nz_GCEDfM22GyZW3c5_mTA_1759005420 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3ecdc9dbc5fso2267206f8f.1 for ; Sat, 27 Sep 2025 13:37:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759005420; x=1759610220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NSL50vU3vn5zRDcV8odSyRV3zrATLUSrY+rAICw6mik=; b=GIymCTbirJxIUHJOUjGOYnj7Q2WQ/RxK8UWDlZhO3rsYJ9qYelXRhDBRp3B0Hy+Cbu f0bqb880EQ7ZP52sHyexcBowkEc6DenQPiXPqIcwNDwBYnAKNY0vOrjOUnDZrwUb8Af3 xu4aETfBTdcNU5QLT1rUUfebi6oF1YC1cMaxBGSo4Z0uRbCvdmSVPJvpfXvYvSyiyNZS HElMf1gRx7JfwVwkPIJqoS3N9yjjOWpqKdfC/RHHlZd9ph20wfdJ+wFh/DWqkkGyUVB3 PZOKzvlTJaqvPar/6d+pTzoMlDmBT0Ma9CrfGQDzUPsRpLTlyuvUwWf1ABsonYYYFOOp JFDg== X-Forwarded-Encrypted: i=1; AJvYcCXVfBWvzgLxxXP54PAnZHstwVxwryPp84EPUZrM/lvcSfAx32pcNAeoEOe6yVc9GOFE5eI=@vger.kernel.org X-Gm-Message-State: AOJu0YzL/VlUHqymWQ+ojce26PPYEDDYnYhvBx3LMDAetsmmT5MmNK9L aUOqbI5/XoVimbCeJo3BWYHEapgS/OoGjmMFHw+XiIdQ5aMF7cSXRoT0CAahXSGd5EHz+Ef3uV+ lVCDaM4epsiztKxcK56jxWkeO6J/DG50D5PPut0Fv2DaYalbTdebDUg== X-Gm-Gg: ASbGnctNeeGS0jlhFE19CTXbAo38U+qdd9ere+nlMdL25ObuSFmO5qcTiTjbU8iV6xU 3kg2rYZveAa4E3VgLVwSz5aJ/Th9ft26Hve9SAoJR571nAHa7Vcsd3CR/oXCXNtg3+4FDXMLxUz sa0vh8ppsrgkaKhjt872j13qtbKR/zVqdlz3cQgZ+QFAAczjYFxxwaYQ4UiJ4ogxgj2nMeoKlFE KGhSARWjrj6AArMXI1g1nic7judaX3zcHXcL+Y4KB0cd0PqfpSr/bOdHcEV2vcnBW7ZlBCEd5uk HXBtb00i7xt2Jae9vBA20c1MxvPkpJ+9tA== X-Received: by 2002:a05:6000:22c7:b0:3ec:e276:f3d5 with SMTP id ffacd0b85a97d-40e48a56cddmr11399272f8f.42.1759005420277; Sat, 27 Sep 2025 13:37:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHf/X8n0rnPQnTiFh6PR8PNOgfG0IN2tIXN0qUNFfjcbHhagOSXpXgOJkcWSW/etGX5pqojgA== X-Received: by 2002:a05:6000:22c7:b0:3ec:e276:f3d5 with SMTP id ffacd0b85a97d-40e48a56cddmr11399254f8f.42.1759005419753; Sat, 27 Sep 2025 13:36:59 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1538:2200:56d4:5975:4ce3:246f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e33b9e3bdsm131200905e9.2.2025.09.27.13.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Sep 2025 13:36:59 -0700 (PDT) Date: Sat, 27 Sep 2025 16:36:56 -0400 From: "Michael S. Tsirkin" To: zhangjiao2 Cc: jasowang@redhat.com, eperezma@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman Subject: Re: [PATCH] vhost: vringh: Modify the return value check Message-ID: <20250927163552-mutt-send-email-mst@kernel.org> References: <20250910091739.2999-1-zhangjiao2@cmss.chinamobile.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250910091739.2999-1-zhangjiao2@cmss.chinamobile.com> On Wed, Sep 10, 2025 at 05:17:38PM +0800, zhangjiao2 wrote: > From: zhang jiao > > The return value of copy_from_iter and copy_to_iter can't be negative, > check whether the copied lengths are equal. > > Signed-off-by: zhang jiao Given copy_to_iter was fixed on net, how about applying this one on net, too? > --- > drivers/vhost/vringh.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c > index 9f27c3f6091b..0c8a17cbb22e 100644 > --- a/drivers/vhost/vringh.c > +++ b/drivers/vhost/vringh.c > @@ -1115,6 +1115,7 @@ static inline int copy_from_iotlb(const struct vringh *vrh, void *dst, > struct iov_iter iter; > u64 translated; > int ret; > + size_t size; > > ret = iotlb_translate(vrh, (u64)(uintptr_t)src, > len - total_translated, &translated, > @@ -1132,9 +1133,9 @@ static inline int copy_from_iotlb(const struct vringh *vrh, void *dst, > translated); > } > > - ret = copy_from_iter(dst, translated, &iter); > - if (ret < 0) > - return ret; > + size = copy_from_iter(dst, translated, &iter); > + if (size != translated) > + return -EFAULT; > > src += translated; > dst += translated; > -- > 2.33.0 > >