Re: [PATCH v7 24/24] whpx: apic: use non-deprecated APIs to control interrupt controller state

Pierrick Bouvier
2025-10-27T07:56:02Z

On 2025-10-23 19:02, Bernhard Beschow wrote:
>
>
> Am 23. Oktober 2025 09:23:58 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
>>
>>
>> Am 23. Oktober 2025 06:33:18 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>:
>>> On 20/10/25 12:27, Bernhard Beschow wrote:
>>>>
>>>>
>>>> Am 16. Oktober 2025 17:15:42 UTC schrieb Pierrick Bouvier <pierrick.bouvier@linaro.org>:
>>>>> On 10/16/25 9:55 AM, Mohamed Mediouni wrote:
>>>>>> WHvGetVirtualProcessorInterruptControllerState2 and
>>>>>> WHvSetVirtualProcessorInterruptControllerState2 are
>>>>>> deprecated since Windows 10 version 2004.
>>>>>>
>>>>>> Use the non-deprecated WHvGetVirtualProcessorState and
>>>>>> WHvSetVirtualProcessorState when available.
>>>>>>
>>>>>> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
>>>>>> ---
>>>>>> include/system/whpx-internal.h | 9 +++++++
>>>>>> target/i386/whpx/whpx-apic.c | 46 +++++++++++++++++++++++++---------
>>>>>> 2 files changed, 43 insertions(+), 12 deletions(-)
>>>>>
>>>>> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>>>
>>>> Couldn't we merge this patch already until the rest of the series is figured out?
>>>
>>> OK if you provide your Tested-by tag (:
>>
>> Oh, I did for an older version of the series w/o this patch: <https://lore.kernel.org/qemu-devel/5758AEBA-9E33-4DCA-9B08-0AF91FD03B0E@gmail.com/>
>>
>> I'll retest.
>
> Unfortunately I get:
>
> WHvSetVirtualProcessorInterruptControllerState failed: c0350005
>
> and the VM terminates. Reverting the patch resolves the problem.
>
> Best regards,
> Bernhard

Thanks for testing it Bernhard.
I didn't have time to run latest versions Mohamed posted.

Pierrick