public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Maximilian Dittgen <mdittgen@amazon.de>
To: <maz@kernel.org>
Cc: <epetron@amazon.de>, <kvm@vger.kernel.org>,
	<kvmarm@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kselftest@vger.kernel.org>, <mdittgen@amazon.com>,
	<mdittgen@amazon.de>, <nh-open-source@amazon.com>,
	<oliver.upton@linux.dev>, <pbonzini@redhat.com>,
	<shuah@kernel.org>
Subject: Re: [PATCH] KVM: selftests: fix ITS collection target addresses in vgic_lpi_stress
Date: Mon, 20 Oct 2025 17:13:50 +0200	[thread overview]
Message-ID: <20251020151350.54383-1-mdittgen@amazon.de> (raw)
In-Reply-To: <86ms5lwwv8.wl-maz@kernel.org>

On Mon, 20 Oct 2025 15:01:15 +0200,
Marc Zyngier <maz@kernel.org> wrote:
>
> To be clear: I don't object to the patch. I object to the nonsensical
> commit message.
>
> And yes, what you have is the correct fix. Just wrap it as a helper
> I'd suggest procnum_to_rdbase(), if you need a name for it).

Thank you for the feedback, I've created a PATCH v2 with revised commit
message and a procnum_to_rdbase() helper.

>
> This test also violate the architecture by not performing a SYNC after
> any command, which would also require the use of a properly formatted
> target field. But hey, correctness is overrated.

I am currently working on a RFC patchset for per-vCPU vLPI enablement
that extends this selftest to test the feature. I will package in SYNCs
as a patch on the RFC.

Thanks,
Maximilian



Amazon Web Services Development Center Germany GmbH
Tamara-Danz-Str. 13
10243 Berlin
Geschaeftsfuehrung: Christian Schlaeger
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597


      reply	other threads:[~2025-10-20 15:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 16:19 [PATCH] KVM: selftests: fix ITS collection target addresses in vgic_lpi_stress Maximilian Dittgen
2025-10-17 17:06 ` Marc Zyngier
2025-10-20 12:12   ` Maximilian Dittgen
2025-10-20 13:01     ` Marc Zyngier
2025-10-20 15:13       ` Maximilian Dittgen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251020151350.54383-1-mdittgen@amazon.de \
    --to=mdittgen@amazon.de \
    --cc=epetron@amazon.de \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mdittgen@amazon.com \
    --cc=nh-open-source@amazon.com \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox