public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Nick Hudson" <nhudson@akamai.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Nick Hudson <nhudson@akamai.com>,
	Max Tottenham <mtottenh@akamai.com>,
	kvm@vger.kernel.org, virtualization@lists.linux.dev,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost: add a new ioctl VHOST_GET_VRING_WORKER_INFO and use in net.c
Date: Tue, 28 Oct 2025 06:17:06 +0800	[thread overview]
Message-ID: <202510280515.pRBqbq4I-lkp@intel.com> (raw)
In-Reply-To: <20251027102644.622305-1-nhudson@akamai.com>

Hi Nick,

kernel test robot noticed the following build errors:

[auto build test ERROR on mst-vhost/linux-next]
[also build test ERROR on linus/master v6.18-rc3 next-20251027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nick-Hudson/vhost-add-a-new-ioctl-VHOST_GET_VRING_WORKER_INFO-and-use-in-net-c/20251027-182919
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
patch link:    https://lore.kernel.org/r/20251027102644.622305-1-nhudson%40akamai.com
patch subject: [PATCH] vhost: add a new ioctl VHOST_GET_VRING_WORKER_INFO and use in net.c
config: arm-randconfig-001-20251028 (https://download.01.org/0day-ci/archive/20251028/202510280515.pRBqbq4I-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project e1ae12640102fd2b05bc567243580f90acb1135f)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251028/202510280515.pRBqbq4I-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510280515.pRBqbq4I-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/vhost/vhost.c:2403:3: error: use of undeclared identifier 'worker'
    2403 |                 worker = rcu_dereference_check(vq->worker,
         |                 ^~~~~~
   drivers/vhost/vhost.c:2403:34: error: use of undeclared identifier 'vq'
    2403 |                 worker = rcu_dereference_check(vq->worker,
         |                                                ^~
   drivers/vhost/vhost.c:2403:34: error: use of undeclared identifier 'vq'
    2403 |                 worker = rcu_dereference_check(vq->worker,
         |                                                ^~
   drivers/vhost/vhost.c:2404:30: error: use of undeclared identifier 'dev'
    2404 |                                                lockdep_is_held(&dev->mutex));
         |                                                                 ^~~
   drivers/vhost/vhost.c:2403:34: error: use of undeclared identifier 'vq'
    2403 |                 worker = rcu_dereference_check(vq->worker,
         |                                                ^~
   drivers/vhost/vhost.c:2405:8: error: use of undeclared identifier 'worker'
    2405 |                 if (!worker) {
         |                      ^~~~~~
   drivers/vhost/vhost.c:2406:4: error: use of undeclared identifier 'ret'
    2406 |                         ret = -EINVAL;
         |                         ^~~
   drivers/vhost/vhost.c:2410:11: error: use of undeclared identifier 'ring_worker_info'; did you mean 'print_worker_info'?
    2410 |                 memset(&ring_worker_info, 0, sizeof(ring_worker_info));
         |                         ^~~~~~~~~~~~~~~~
         |                         print_worker_info
   include/linux/workqueue.h:637:13: note: 'print_worker_info' declared here
     637 | extern void print_worker_info(const char *log_lvl, struct task_struct *task);
         |             ^
   drivers/vhost/vhost.c:2410:39: error: use of undeclared identifier 'ring_worker_info'; did you mean 'print_worker_info'?
    2410 |                 memset(&ring_worker_info, 0, sizeof(ring_worker_info));
         |                                                     ^~~~~~~~~~~~~~~~
         |                                                     print_worker_info
   include/linux/workqueue.h:637:13: note: 'print_worker_info' declared here
     637 | extern void print_worker_info(const char *log_lvl, struct task_struct *task);
         |             ^
   drivers/vhost/vhost.c:2411:3: error: use of undeclared identifier 'ring_worker_info'; did you mean 'print_worker_info'?
    2411 |                 ring_worker_info.index = idx;
         |                 ^~~~~~~~~~~~~~~~
         |                 print_worker_info
   include/linux/workqueue.h:637:13: note: 'print_worker_info' declared here
     637 | extern void print_worker_info(const char *log_lvl, struct task_struct *task);
         |             ^
   drivers/vhost/vhost.c:2411:19: error: member reference base type 'void (const char *, struct task_struct *)' is not a structure or union
    2411 |                 ring_worker_info.index = idx;
         |                 ~~~~~~~~~~~~~~~~^~~~~~
   drivers/vhost/vhost.c:2411:28: error: use of undeclared identifier 'idx'
    2411 |                 ring_worker_info.index = idx;
         |                                          ^~~
   drivers/vhost/vhost.c:2412:3: error: use of undeclared identifier 'ring_worker_info'; did you mean 'print_worker_info'?
    2412 |                 ring_worker_info.worker_id = worker->id;
         |                 ^~~~~~~~~~~~~~~~
         |                 print_worker_info
   include/linux/workqueue.h:637:13: note: 'print_worker_info' declared here
     637 | extern void print_worker_info(const char *log_lvl, struct task_struct *task);
         |             ^
   drivers/vhost/vhost.c:2412:19: error: member reference base type 'void (const char *, struct task_struct *)' is not a structure or union
    2412 |                 ring_worker_info.worker_id = worker->id;
         |                 ~~~~~~~~~~~~~~~~^~~~~~~~~~
   drivers/vhost/vhost.c:2412:32: error: use of undeclared identifier 'worker'
    2412 |                 ring_worker_info.worker_id = worker->id;
         |                                              ^~~~~~
   drivers/vhost/vhost.c:2413:3: error: use of undeclared identifier 'ring_worker_info'; did you mean 'print_worker_info'?
    2413 |                 ring_worker_info.worker_pid = task_pid_vnr(vhost_get_task(worker->vtsk));
         |                 ^~~~~~~~~~~~~~~~
         |                 print_worker_info
   include/linux/workqueue.h:637:13: note: 'print_worker_info' declared here
     637 | extern void print_worker_info(const char *log_lvl, struct task_struct *task);
         |             ^
   drivers/vhost/vhost.c:2413:19: error: member reference base type 'void (const char *, struct task_struct *)' is not a structure or union
    2413 |                 ring_worker_info.worker_pid = task_pid_vnr(vhost_get_task(worker->vtsk));
         |                 ~~~~~~~~~~~~~~~~^~~~~~~~~~~
>> drivers/vhost/vhost.c:2413:46: error: call to undeclared function 'vhost_get_task'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2413 |                 ring_worker_info.worker_pid = task_pid_vnr(vhost_get_task(worker->vtsk));
         |                                                            ^
   drivers/vhost/vhost.c:2413:46: note: did you mean 'vhost_get_desc'?
   drivers/vhost/vhost.c:1581:19: note: 'vhost_get_desc' declared here
    1581 | static inline int vhost_get_desc(struct vhost_virtqueue *vq,
         |                   ^
   drivers/vhost/vhost.c:2413:61: error: use of undeclared identifier 'worker'
    2413 |                 ring_worker_info.worker_pid = task_pid_vnr(vhost_get_task(worker->vtsk));
         |                                                                           ^~~~~~
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.


vim +/vhost_get_task +2413 drivers/vhost/vhost.c

  2352	
  2353		/* You must be the owner to do anything else */
  2354		r = vhost_dev_check_owner(d);
  2355		if (r)
  2356			goto done;
  2357	
  2358		switch (ioctl) {
  2359		case VHOST_SET_MEM_TABLE:
  2360			r = vhost_set_memory(d, argp);
  2361			break;
  2362		case VHOST_SET_LOG_BASE:
  2363			if (copy_from_user(&p, argp, sizeof p)) {
  2364				r = -EFAULT;
  2365				break;
  2366			}
  2367			if ((u64)(unsigned long)p != p) {
  2368				r = -EFAULT;
  2369				break;
  2370			}
  2371			for (i = 0; i < d->nvqs; ++i) {
  2372				struct vhost_virtqueue *vq;
  2373				void __user *base = (void __user *)(unsigned long)p;
  2374				vq = d->vqs[i];
  2375				mutex_lock(&vq->mutex);
  2376				/* If ring is inactive, will check when it's enabled. */
  2377				if (vq->private_data && !vq_log_access_ok(vq, base))
  2378					r = -EFAULT;
  2379				else
  2380					vq->log_base = base;
  2381				mutex_unlock(&vq->mutex);
  2382			}
  2383			break;
  2384		case VHOST_SET_LOG_FD:
  2385			r = get_user(fd, (int __user *)argp);
  2386			if (r < 0)
  2387				break;
  2388			ctx = fd == VHOST_FILE_UNBIND ? NULL : eventfd_ctx_fdget(fd);
  2389			if (IS_ERR(ctx)) {
  2390				r = PTR_ERR(ctx);
  2391				break;
  2392			}
  2393			swap(ctx, d->log_ctx);
  2394			for (i = 0; i < d->nvqs; ++i) {
  2395				mutex_lock(&d->vqs[i]->mutex);
  2396				d->vqs[i]->log_ctx = d->log_ctx;
  2397				mutex_unlock(&d->vqs[i]->mutex);
  2398			}
  2399			if (ctx)
  2400				eventfd_ctx_put(ctx);
  2401			break;
  2402		case VHOST_GET_VRING_WORKER_INFO:
  2403			worker = rcu_dereference_check(vq->worker,
  2404						       lockdep_is_held(&dev->mutex));
  2405			if (!worker) {
  2406				ret = -EINVAL;
  2407				break;
  2408			}
  2409	
  2410			memset(&ring_worker_info, 0, sizeof(ring_worker_info));
  2411			ring_worker_info.index = idx;
  2412			ring_worker_info.worker_id = worker->id;
> 2413			ring_worker_info.worker_pid = task_pid_vnr(vhost_get_task(worker->vtsk));
  2414	
  2415			if (copy_to_user(argp, &ring_worker_info, sizeof(ring_worker_info)))
  2416				ret = -EFAULT;
  2417			break;
  2418		default:
  2419			r = -ENOIOCTLCMD;
  2420			break;
  2421		}
  2422	done:
  2423		return r;
  2424	}
  2425	EXPORT_SYMBOL_GPL(vhost_dev_ioctl);
  2426	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-10-27 22:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27 10:26 [PATCH] vhost: add a new ioctl VHOST_GET_VRING_WORKER_INFO and use in net.c Nick Hudson
2025-10-27 22:17 ` kernel test robot [this message]
2025-10-27 22:27 ` kernel test robot
2025-10-28  0:42 ` Jason Wang
2025-10-28  7:13   ` Hudson, Nick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202510280515.pRBqbq4I-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mst@redhat.com \
    --cc=mtottenh@akamai.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhudson@akamai.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox