From: David Matlack <dmatlack@google.com>
To: Alex Williamson <alex@shazbot.org>
Cc: Alex Mastro <amastro@fb.com>, David Matlack <dmatlack@google.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Josh Hilke <jrhilke@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Raghavendra Rao Ananta <rananta@google.com>,
Vipin Sharma <vipinsh@google.com>
Subject: [PATCH v3 07/18] vfio: selftests: Eliminate overly chatty logging
Date: Fri, 21 Nov 2025 18:14:18 +0000 [thread overview]
Message-ID: <20251121181429.1421717-8-dmatlack@google.com> (raw)
In-Reply-To: <20251121181429.1421717-1-dmatlack@google.com>
Eliminate overly chatty logs that are printed during almost every test.
These logs are adding more noise than value. If a test cares about this
information it can log it itself. This is especially true as the VFIO
selftests gains support for multiple devices in a single test (which
multiplies all these logs).
Reviewed-by: Alex Mastro <amastro@fb.com>
Tested-by: Alex Mastro <amastro@fb.com>
Signed-off-by: David Matlack <dmatlack@google.com>
---
tools/testing/selftests/vfio/lib/vfio_pci_driver.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/tools/testing/selftests/vfio/lib/vfio_pci_driver.c b/tools/testing/selftests/vfio/lib/vfio_pci_driver.c
index e5e8723ecb41..abb7a62a03ea 100644
--- a/tools/testing/selftests/vfio/lib/vfio_pci_driver.c
+++ b/tools/testing/selftests/vfio/lib/vfio_pci_driver.c
@@ -1,6 +1,4 @@
// SPDX-License-Identifier: GPL-2.0-only
-#include <stdio.h>
-
#include "../../../kselftest.h"
#include <vfio_util.h>
@@ -29,7 +27,6 @@ void vfio_pci_driver_probe(struct vfio_pci_device *device)
if (ops->probe(device))
continue;
- printf("Driver found: %s\n", ops->name);
device->driver.ops = ops;
}
}
@@ -58,17 +55,6 @@ void vfio_pci_driver_init(struct vfio_pci_device *device)
driver->ops->init(device);
driver->initialized = true;
-
- printf("%s: region: vaddr %p, iova 0x%lx, size 0x%lx\n",
- driver->ops->name,
- driver->region.vaddr,
- driver->region.iova,
- driver->region.size);
-
- printf("%s: max_memcpy_size 0x%lx, max_memcpy_count 0x%lx\n",
- driver->ops->name,
- driver->max_memcpy_size,
- driver->max_memcpy_count);
}
void vfio_pci_driver_remove(struct vfio_pci_device *device)
--
2.52.0.rc2.455.g230fcf2819-goog
next prev parent reply other threads:[~2025-11-21 18:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 18:14 [PATCH v3 00/18] vfio: selftests: Support for multi-device tests David Matlack
2025-11-21 18:14 ` [PATCH v3 01/18] vfio: selftests: Move run.sh into scripts directory David Matlack
2025-11-21 18:14 ` [PATCH v3 02/18] vfio: selftests: Split run.sh into separate scripts David Matlack
2025-11-21 18:14 ` [PATCH v3 03/18] vfio: selftests: Allow passing multiple BDFs on the command line David Matlack
2025-11-21 18:14 ` [PATCH v3 04/18] vfio: selftests: Rename struct vfio_iommu_mode to iommu_mode David Matlack
2025-11-21 18:14 ` [PATCH v3 05/18] vfio: selftests: Introduce struct iommu David Matlack
2025-11-21 18:14 ` [PATCH v3 06/18] vfio: selftests: Support multiple devices in the same container/iommufd David Matlack
2025-11-24 11:17 ` Raghavendra Rao Ananta
2025-11-25 17:37 ` David Matlack
2025-11-21 18:14 ` David Matlack [this message]
2025-11-22 14:56 ` [PATCH v3 07/18] vfio: selftests: Eliminate overly chatty logging kernel test robot
2025-11-21 18:14 ` [PATCH v3 08/18] vfio: selftests: Prefix logs with device BDF where relevant David Matlack
2025-11-21 18:14 ` [PATCH v3 09/18] vfio: selftests: Upgrade driver logging to dev_err() David Matlack
2025-11-21 18:14 ` [PATCH v3 10/18] vfio: selftests: Rename struct vfio_dma_region to dma_region David Matlack
2025-11-21 18:14 ` [PATCH v3 11/18] vfio: selftests: Move IOMMU library code into iommu.c David Matlack
2025-11-23 1:59 ` kernel test robot
2025-11-21 18:14 ` [PATCH v3 12/18] vfio: selftests: Move IOVA allocator into iova_allocator.c David Matlack
2025-11-23 1:57 ` kernel test robot
2025-11-21 18:14 ` [PATCH v3 13/18] vfio: selftests: Stop passing device for IOMMU operations David Matlack
2025-11-21 18:14 ` [PATCH v3 14/18] vfio: selftests: Rename vfio_util.h to libvfio.h David Matlack
2025-11-21 18:14 ` [PATCH v3 15/18] vfio: selftests: Move vfio_selftests_*() helpers into libvfio.c David Matlack
2025-11-21 18:14 ` [PATCH v3 16/18] vfio: selftests: Split libvfio.h into separate header files David Matlack
2025-11-21 18:14 ` [PATCH v3 17/18] vfio: selftests: Eliminate INVALID_IOVA David Matlack
2025-11-21 18:14 ` [PATCH v3 18/18] vfio: selftests: Add vfio_pci_device_init_perf_test David Matlack
2025-11-24 11:20 ` [PATCH v3 00/18] vfio: selftests: Support for multi-device tests Raghavendra Rao Ananta
2025-11-25 17:38 ` David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121181429.1421717-8-dmatlack@google.com \
--to=dmatlack@google.com \
--cc=alex@shazbot.org \
--cc=amastro@fb.com \
--cc=jgg@nvidia.com \
--cc=jrhilke@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rananta@google.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox