Re: [PATCH v5 5/7] vfio/nvgrace-gpu: split the code to wait for GPU ready

Ankit Agrawal
2025-11-25T02:53:15Z

Thanks Shameer for the reviewed-by.

>> +     do {
>> +             if ((ioread32(io + C2C_LINK_BAR0_OFFSET) ==
>> STATUS_READY) &&
>> +                 (ioread32(io + HBM_TRAINING_BAR0_OFFSET) ==
>> STATUS_READY)) {
>> +                     ret = 0;
>> +                     goto ready_check_exit;
>
> You could return directly here and avoid that goto.

Yeah, I have a bad habit of overusing goto. I'll update it to return.