From: Jason Gunthorpe <jgg@ziepe.ca>
To: ankita@nvidia.com
Cc: yishaih@nvidia.com, skolothumtho@nvidia.com,
kevin.tian@intel.com, alex@shazbot.org, aniketa@nvidia.com,
vsethi@nvidia.com, mochs@nvidia.com, Yunxiang.Li@amd.com,
yi.l.liu@intel.com, zhangdongdong@eswincomputing.com,
avihaih@nvidia.com, bhelgaas@google.com, peterx@redhat.com,
pstanner@redhat.com, apopple@nvidia.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, cjia@nvidia.com,
kwankhede@nvidia.com, targupta@nvidia.com, zhiw@nvidia.com,
danw@nvidia.com, dnigam@nvidia.com, kjaju@nvidia.com
Subject: Re: [PATCH v5 3/7] vfio/nvgrace-gpu: Add support for huge pfnmap
Date: Mon, 24 Nov 2025 14:15:21 -0400 [thread overview]
Message-ID: <20251124181521.GV233636@ziepe.ca> (raw)
In-Reply-To: <20251124115926.119027-4-ankita@nvidia.com>
On Mon, Nov 24, 2025 at 11:59:22AM +0000, ankita@nvidia.com wrote:
> +static size_t nvgrace_gpu_aligned_devmem_size(size_t memlength)
> +{
> +#ifdef CONFIG_ARCH_SUPPORTS_PMD_PFNMAP
> + return ALIGN(memlength, PMD_SIZE);
> +#endif
> +#ifdef CONFIG_ARCH_SUPPORTS_PUD_PFNMAP
> + return ALIGN(memlength, PUD_SIZE);
> +#endif
> + return memlength;
> +}
This needs a comment why it is OK to change the size up? Seems really
surprising (and wrong!). The commit message should explain it too.
Jason
next prev parent reply other threads:[~2025-11-24 18:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 11:59 [PATCH v5 0/7] vfio/nvgrace-gpu: Support huge PFNMAP and wait for GPU ready post reset ankita
2025-11-24 11:59 ` [PATCH v5 1/7] vfio/nvgrace-gpu: Use faults to map device memory ankita
2025-11-24 17:09 ` Shameer Kolothum
2025-11-24 17:16 ` Jason Gunthorpe
2025-11-24 17:16 ` Jason Gunthorpe
2025-11-24 11:59 ` [PATCH v5 2/7] vfio: export function to map the VMA ankita
2025-11-24 17:22 ` Shameer Kolothum
2025-11-24 11:59 ` [PATCH v5 3/7] vfio/nvgrace-gpu: Add support for huge pfnmap ankita
2025-11-24 15:32 ` Alex Williamson
2025-11-24 15:40 ` Ankit Agrawal
2025-11-24 18:08 ` Shameer Kolothum
2025-11-24 18:15 ` Jason Gunthorpe [this message]
2025-11-24 11:59 ` [PATCH v5 4/7] vfio: use vfio_pci_core_setup_barmap to map bar in mmap ankita
2025-11-24 18:10 ` Shameer Kolothum
2025-11-24 11:59 ` [PATCH v5 5/7] vfio/nvgrace-gpu: split the code to wait for GPU ready ankita
2025-11-24 15:32 ` Alex Williamson
2025-11-24 15:39 ` Ankit Agrawal
2025-11-24 18:22 ` Shameer Kolothum
2025-11-25 2:53 ` Ankit Agrawal
2025-11-24 11:59 ` [PATCH v5 6/7] vfio/nvgrace-gpu: Inform devmem unmapped after reset ankita
2025-11-24 18:16 ` Jason Gunthorpe
2025-11-25 2:52 ` Ankit Agrawal
2025-11-24 11:59 ` [PATCH v5 7/7] vfio/nvgrace-gpu: wait for the GPU mem to be ready ankita
2025-11-24 18:41 ` Shameer Kolothum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124181521.GV233636@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Yunxiang.Li@amd.com \
--cc=alex@shazbot.org \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=apopple@nvidia.com \
--cc=avihaih@nvidia.com \
--cc=bhelgaas@google.com \
--cc=cjia@nvidia.com \
--cc=danw@nvidia.com \
--cc=dnigam@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochs@nvidia.com \
--cc=peterx@redhat.com \
--cc=pstanner@redhat.com \
--cc=skolothumtho@nvidia.com \
--cc=targupta@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=yi.l.liu@intel.com \
--cc=yishaih@nvidia.com \
--cc=zhangdongdong@eswincomputing.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox