From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0D2F212564; Wed, 26 Nov 2025 04:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764132853; cv=none; b=rpXqlSKGDErV1t7HQh508Jh8quG7HMpDi//ZfWCuHOmeHW52AwcmnnIqkYLiUnH0d5rA1vrqpBSN6Z+ZEjfG4mxwp1G/HjGGqzd+RkDeZ7eLLnrJyepXHD5UQPobFHYkreGXUOZ1vUAZ9VxPYRJ+r0jbZr9mFzrfF6QiNXkILYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764132853; c=relaxed/simple; bh=azYVioa3PoS1KXDSbFJDNPE7YhRu7rDG6dcHIl5e1jU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NpL/7NJfsiNrMWXRrAvu9s1mZjTvJa7+KoUTb9R40Az+gQVBWDQdLZTQInJdv6+iijs7O7oQaTfHvxw0/VqRswciikO3PEeu/egHnpAZG2ohQbacFLYScKkY21o9167suSYgMdcxSQ0pulMcrWSFfg2n4w55PRiIRHRaHVQh0HM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=PCkl2Z3n; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=adgDSPtZ; arc=none smtp.client-ip=103.168.172.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="PCkl2Z3n"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="adgDSPtZ" Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id BEEC4140026A; Tue, 25 Nov 2025 23:54:07 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Tue, 25 Nov 2025 23:54:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1764132847; x=1764219247; bh=OJapMed/C+yKNoaqUK0e+pVkzZmShWWGBcRCvt+tEqw=; b= PCkl2Z3nrmBIvFDwtTdC1Ab2kugXko8LUJMCqpCKfZsmYha+3hUvTcYSSQ60Yh5B I+RtYHz9LpMDX9hGE9Z+VAxLxPddaZVjC6GwcWEFYOp0vOmqolg92oMxc+AB9vuC u9ukKOJlAJL9c0iniSwQpUWQCtJ0VCwSFk2VnBnkB12fOGi+u9CXCTZCTo3p1Ssh jtuo/vBnOS0TbtZ+hTsG6k1JAeiGuyoOMK/xCbo4iYfxu+Vgaqm0EoJiFg5Qb/WL pKJiXjbq3hcj6OLBvJW8FEddBhlaE2pkP64GTos5PixzEx9lhzGDgGM0Ag7GlsOv PToxTSOpEpJZsu07oYTbHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1764132847; x= 1764219247; bh=OJapMed/C+yKNoaqUK0e+pVkzZmShWWGBcRCvt+tEqw=; b=a dgDSPtZs6ph4YK5E+5pMvWuEkBmrm3PhcZXMbiopnn0wG7OFGNWOqZRANODGjjml RZJioK1OWNMi4/ps2cvNyGXSFhbrZE3OzgFJnZwaUv6CLhuwMb52A7hDrF66wQck Qj09pCagupdhYN/py1enXKqlifPhg924EGZal8BuQROsEwUj58xISmiw63taSlzq sMKQGJcMq2CXysrkNAXLmfiAj+KNTweBw0dh4rcwuLuIQqaM1lBrWs5dMrThaNlB tqn62jyzRo4+x8vwpfOyG+5s+1TLTf/k7JAC4uhYfgWePa2Tt2wQodFNKL9eY21F VIK4cZGHhET1KAQjn54ig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvgeefgeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkjghfgggtgfesthhqredttddtjeenucfhrhhomheptehlvgigucgh ihhllhhirghmshhonhcuoegrlhgvgiesshhhrgiisghothdrohhrgheqnecuggftrfgrth htvghrnhepgfffvdefjeejueevfeetudfhgeetfeeuheetfeekjedvuddvueehffdtgeej keetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hlvgigsehshhgriigsohhtrdhorhhgpdhnsggprhgtphhtthhopedvhedpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtoheprghnkhhithgrsehnvhhiughirgdrtghomhdprhgtph htthhopehjghhgseiiihgvphgvrdgtrgdprhgtphhtthhopeihihhshhgrihhhsehnvhhi ughirgdrtghomhdprhgtphhtthhopehskhholhhothhhuhhmthhhohesnhhvihguihgrrd gtohhmpdhrtghpthhtohepkhgvvhhinhdrthhirghnsehinhhtvghlrdgtohhmpdhrtghp thhtoheprghnihhkvghtrgesnhhvihguihgrrdgtohhmpdhrtghpthhtohepvhhsvghthh hisehnvhhiughirgdrtghomhdprhgtphhtthhopehmohgthhhssehnvhhiughirgdrtgho mhdprhgtphhtthhopeihuhhngihirghnghdrlhhisegrmhgurdgtohhm X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Nov 2025 23:54:05 -0500 (EST) Date: Tue, 25 Nov 2025 21:54:04 -0700 From: Alex Williamson To: Ankit Agrawal Cc: "jgg@ziepe.ca" , Yishai Hadas , Shameer Kolothum , "kevin.tian@intel.com" , Aniket Agashe , Vikram Sethi , Matt Ochs , "Yunxiang.Li@amd.com" , "yi.l.liu@intel.com" , "zhangdongdong@eswincomputing.com" , Avihai Horon , "bhelgaas@google.com" , "peterx@redhat.com" , "pstanner@redhat.com" , Alistair Popple , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Zhi Wang , Dan Williams , Dheeraj Nigam , Krishnakant Jaju Subject: Re: [PATCH v6 5/6] vfio/nvgrace-gpu: Inform devmem unmapped after reset Message-ID: <20251125215404.14c969be@shazbot.org> In-Reply-To: References: <20251125173013.39511-1-ankita@nvidia.com> <20251125173013.39511-6-ankita@nvidia.com> <20251125135247.62878956.alex@shazbot.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 26 Nov 2025 03:26:54 +0000 Ankit Agrawal wrote: > >>=C2=A0 MODULE_DEVICE_TABLE(pci, nvgrace_gpu_vfio_pci_table); > >> =20 > > /* > > =C2=A0* Comment explaining why this can't use lockdep_assert_held_write= but > > =C2=A0* in vfio use cases relies on this for serialization against faul= ts and > > =C2=A0* read/write. > > =C2=A0*/ > > =20 >=20 > In this patch or the next where we actually do the serialization with > memory_lock? When the interaction is added would make more sense. Thanks, Alex