From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a4-smtp.messagingengine.com (fhigh-a4-smtp.messagingengine.com [103.168.172.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C18F82F12CE; Tue, 23 Dec 2025 23:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766533285; cv=none; b=c8dxo9Efxd6V7g1F0XCGVaoZKFocpo0RRURz7Hy6UXmLRtC5DbBnPQ0li/1rSmjuJ2w54/JwMxznyPT9tRYvhw3kHmkLOuE3o/YCH6hgzcFBhsradQ6vH0ORi4YkdmcOUn4Xsr1ZiFCCXVU7FPY52+OFhTkXoo+nPh6oJu35d5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766533285; c=relaxed/simple; bh=r5G6JS64ySTh5vmDZDGEM3TJ5FPIg5JWgLqslzKjyGQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lwvmbUUdT9660GtyzGZ9T11hQcv/v+5UGl6CLE5oEwuNV/gK3vV5zLEXH9DnFYw/DzbjCO57ZvZ5aAmgjo1BRbwGun8sgUBN75DHPHla/vzxL+T7XGsiAX+HnBjAPzl8leqdayhr2e5fWNIsTlifuI0aaqC/wJAfrMTGuBKYZlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=GX+ZQova; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=DICYizRA; arc=none smtp.client-ip=103.168.172.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="GX+ZQova"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="DICYizRA" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id C813C140009B; Tue, 23 Dec 2025 18:41:21 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Tue, 23 Dec 2025 18:41:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1766533281; x=1766619681; bh=o7r3ytA43pUHLpxhqQjH44Xiv52OWQmH6R3NnII+EP4=; b= GX+ZQova6lZqkDWMYmpWS5aCahyMU94ZXaEK3jExCmhCnKqDgAobmK/m9vASsY2P ietqr33vUaSYIrzmF8e8xw6pgZgw0s+OjVCjtzGH5oYHoCQeWk5Y2t35l2DuZ9CK iWfxFZKQfK1JTKiWWy91w1vlPEa+wEAgKHIz9KRPm+fA9ROGMD3ungzOUy9qStor 0SzJacNT5Jcb7PU3BM5bOZORbZXnMayazYoIGMq/qXtVsJ1wx5aEVkkuHzBHKaIj 3lBsr5tbbb3OiBxls26F7ooHj4IOXX7sP7EmsjbfE4MKLh360v+gXpkAR4F/Ox9B UXAeXohzpt4G5Pb9UzWhSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1766533281; x= 1766619681; bh=o7r3ytA43pUHLpxhqQjH44Xiv52OWQmH6R3NnII+EP4=; b=D ICYizRAIrbr1MlCjTUM80wI4OwsS7KP5pS+uqDbTmmo8s0eabbqfgsHRoJgKyXW7 VdUq1VgEARTfsvbQf1Bf1hwFgKRFzSkGU3Pu5bdUaKac6ng3s3+Kt/6BGfjjA3ie rgs6E0DcAzwz17OpU+L+qecW2gPmBPfiIVYbSbDuGN1kKlPqJ5CS2Loz9awEobC1 WsWKJZ5W0UYLOwWqbKhygLhH82nh/SIyhB54J0m7ofcQqk6bsMt/GSd3GRbrkj0t HPLmoniZixBwN94wK6KDG0JwYFOopqSGONM2CVRgKHAlB8EfBeWSSKU03M1MkOd6 Ww0Sp+Zo6kHBBUDaCq+6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeiuddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfgjfhggtgfgsehtqhertddttdejnecuhfhrohhmpeetlhgvgicuhghi lhhlihgrmhhsohhnuceorghlvgigsehshhgriigsohhtrdhorhhgqeenucggtffrrghtth gvrhhnpefgffdvfeejjeeuveefteduhfegteefueehteefkeejvdduvdeuhefftdegjeek teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlh gvgiesshhhrgiisghothdrohhrghdpnhgspghrtghpthhtohepuddupdhmohguvgepshhm thhpohhuthdprhgtphhtthhopehmihgthhgrlhdrfigrjhguvggtiihkohesihhnthgvlh drtghomhdprhgtphhtthhopehinhhtvghlqdigvgeslhhishhtshdrfhhrvggvuggvshhk thhophdrohhrghdprhgtphhtthhopehthhhomhgrshdrhhgvlhhlshhtrhhomheslhhinh hugidrihhnthgvlhdrtghomhdprhgtphhtthhopehrohgurhhighhordhvihhvihesihhn thgvlhdrtghomhdprhgtphhtthhopehjghhgsehnvhhiughirgdrtghomhdprhgtphhtth hopehkvghvihhnrdhtihgrnhesihhnthgvlhdrtghomhdprhgtphhtthhopehmihgthhgr lhdrfihinhhirghrshhkihesihhnthgvlhdrtghomhdprhgtphhtthhopehmrghrtghinh drsggvrhhnrghtohifihgtiieslhhinhhugidrihhnthgvlhdrtghomhdprhgtphhtthho pegurhhiqdguvghvvghlsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhg X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Dec 2025 18:41:20 -0500 (EST) Date: Tue, 23 Dec 2025 16:41:19 -0700 From: Alex Williamson To: Michal Wajdeczko Cc: intel-xe@lists.freedesktop.org, Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?= , Rodrigo Vivi , Jason Gunthorpe , Kevin Tian , =?UTF-8?B?TWljaGHFgg==?= Winiarski , Marcin Bernatowicz , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] vfio/xe: Add default handler for .get_region_info_caps Message-ID: <20251223164119.5b9bb979.alex@shazbot.org> In-Reply-To: <20251218205106.4578-1-michal.wajdeczko@intel.com> References: <20251218205106.4578-1-michal.wajdeczko@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 18 Dec 2025 21:51:06 +0100 Michal Wajdeczko wrote: > New requirement for the vfio drivers was added by the commit > f97859503859 ("vfio: Require drivers to implement get_region_info") > followed by commit 1b0ecb5baf4a ("vfio/pci: Convert all PCI drivers > to get_region_info_caps") that was missed by the new vfio/xe driver. >=20 > Add handler for .get_region_info_caps to avoid -EINVAL errors. >=20 > Fixes: 2e38c50ae492 ("vfio/xe: Add device specific vfio_pci driver varian= t for Intel graphics") > Signed-off-by: Michal Wajdeczko > --- > Cc: Thomas Hellstr=C3=B6m > Cc: Rodrigo Vivi > Cc: Jason Gunthorpe > Cc: Kevin Tian > Cc: Alex Williamson > Cc: Micha=C5=82 Winiarski > Cc: Marcin Bernatowicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Cc: kvm@vger.kernel.org > --- > drivers/vfio/pci/xe/main.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/vfio/pci/xe/main.c b/drivers/vfio/pci/xe/main.c > index 0156b53c678b..719ab4660085 100644 > --- a/drivers/vfio/pci/xe/main.c > +++ b/drivers/vfio/pci/xe/main.c > @@ -504,6 +504,7 @@ static const struct vfio_device_ops xe_vfio_pci_ops = =3D { > .open_device =3D xe_vfio_pci_open_device, > .close_device =3D xe_vfio_pci_close_device, > .ioctl =3D vfio_pci_core_ioctl, > + .get_region_info_caps =3D vfio_pci_ioctl_get_region_info, > .device_feature =3D vfio_pci_core_ioctl_feature, > .read =3D vfio_pci_core_read, > .write =3D vfio_pci_core_write, Applied to vfio for-linus branch for v6.19. Thanks, Alex