From: Kommula Shiva Shankar <kshankar@marvell.com>
To: <mst@redhat.com>
Cc: <jasowang@redhat.com>, <virtualization@lists.linux.dev>,
<eperezma@redhat.com>, <kvm@vger.kernel.org>,
<netdev@vger.kernel.org>, <jerinj@marvell.com>,
<ndabilpuram@marvell.com>, <schalla@marvell.com>
Subject: [PATCH] vhost: fix caching attributes of MMIO regions by setting them explicitly
Date: Fri, 2 Jan 2026 12:27:03 +0530 [thread overview]
Message-ID: <20260102065703.656255-1-kshankar@marvell.com> (raw)
Explicitly set non-cached caching attributes for MMIO regions.
Default write-back mode can cause CPU to cache device memory,
causing invalid reads and unpredictable behavior.
Invalid read and write issues were observed on ARM64 when mapping the
notification area to userspace via mmap.
Signed-off-by: Kommula Shiva Shankar <kshankar@marvell.com>
Acked-by: Jason Wang <jasowang@redhat.com>
---
Originally sent to net-next, now redirected to vhost tree
per Jason Wang's suggestion.
drivers/vhost/vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 05a481e4c385..b0179e8567ab 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -1527,6 +1527,7 @@ static int vhost_vdpa_mmap(struct file *file, struct vm_area_struct *vma)
if (vma->vm_end - vma->vm_start != notify.size)
return -ENOTSUPP;
+ vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP);
vma->vm_ops = &vhost_vdpa_vm_ops;
return 0;
--
2.48.1
next reply other threads:[~2026-01-02 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 6:57 Kommula Shiva Shankar [this message]
2026-01-13 6:19 ` [EXTERNAL] [PATCH] vhost: fix caching attributes of MMIO regions by setting them explicitly Shiva Shankar Kommula
2026-01-13 7:30 ` Michael S. Tsirkin
2026-01-13 10:11 ` [EXTERNAL] " Shiva Shankar Kommula
2026-01-13 17:25 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102065703.656255-1-kshankar@marvell.com \
--to=kshankar@marvell.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jerinj@marvell.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ndabilpuram@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=schalla@marvell.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox