From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9832530FC35 for ; Tue, 27 Jan 2026 09:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507997; cv=none; b=X2xgKjJ8hGfTRwEBblO0SUm6wGS6R8S/zdcCM3cdjiLej+uwdsRy+rI2xob76IuKpX4T4vZs4rivN9USWhmleDSeIiJZXBi7c50mF9UsgZd6FFEoh3JPkn7lAhQDT+30KDVylYSqPD+jjbY2EkxwJrgpTNn671X9F6Cq/ilBij4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507997; c=relaxed/simple; bh=jvVTlOrCwUQ798UqiYB31Ha/4wwtGH5t7x4X++RYugw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rN1A/WmA47fwYqVfCs4vDE9A71NvLM00Spf1jJ1tJvI4nOuKugHDE55QFE7oCsZ3hKc6f21f6LY6BcZAPfrAi6me1i0FF7DkvirkwossBPZJzsKsm3/QdSvBV4q8/vihjYSZHnddcBKajj6sIjcCPla7UmNavo6V7yrMcqSFjLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UH587Hgo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UH587Hgo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769507994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WBzv/EEHOLl1lvpY0Tolfh3wVeN8GBPJIxvAOWVtvEE=; b=UH587HgoiUBaHjcEO+dtrWT2LwFQSyms83d6TsWvWggQj4XidfSHRY8q5cEp+yyA+H3GBQ ua1dYDQ1k+TLB2AjJk5iYTi91GMmWgui3uz2d0S6uPXOX7WzLQvvJuergp2xPYf7lxfHyI HgbC9PboTVdoGvrb/Zzsw8y6Sy1zlqs= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-X6xRwTTRNX-EnlP50FozHg-1; Tue, 27 Jan 2026 04:59:51 -0500 X-MC-Unique: X6xRwTTRNX-EnlP50FozHg-1 X-Mimecast-MFC-AGG-ID: X6xRwTTRNX-EnlP50FozHg_1769507989 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7665F180044D; Tue, 27 Jan 2026 09:59:49 +0000 (UTC) Received: from osteffen-thinkpadx1carbongen12.rmtde.csb (unknown [10.44.34.174]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 98E5A19560B2; Tue, 27 Jan 2026 09:59:44 +0000 (UTC) From: Oliver Steffen To: qemu-devel@nongnu.org Cc: Ani Sinha , Eduardo Habkost , Stefano Garzarella , Igor Mammedov , Richard Henderson , Gerd Hoffmann , Paolo Bonzini , Luigi Leonardi , Joerg Roedel , "Michael S. Tsirkin" , Marcelo Tosatti , Marcel Apfelbaum , Zhao Liu , kvm@vger.kernel.org, Oliver Steffen Subject: [PATCH v5 1/6] hw/acpi: Make BIOS linker optional Date: Tue, 27 Jan 2026 10:59:31 +0100 Message-ID: <20260127095936.1072464-2-osteffen@redhat.com> In-Reply-To: <20260127095936.1072464-1-osteffen@redhat.com> References: <20260127095936.1072464-1-osteffen@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Make the BIOS linker optional in acpi_table_end() and calculate the ACPI table checksum directly if no linker is provided. This makes it possible to call for example acpi_build_madt() from outside the ACPI table builder context. Signed-off-by: Oliver Steffen --- hw/acpi/aml-build.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index dad4cfcc7d..6a3650076f 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -1730,6 +1730,25 @@ void acpi_table_begin(AcpiTable *desc, GArray *array) build_append_int_noprefix(array, 1, 4); /* Creator Revision */ } +static uint8_t calculate_acpi_checksum(const gchar *data, size_t len) +{ + size_t i; + uint8_t sum = 0; + + for (i = 0; i < len; ++i) { + sum += (uint8_t)data[i]; + } + + return sum; +} + +static void update_acpi_checksum(gchar *data, size_t start_offset, + size_t table_len, size_t checksum_offset) +{ + uint8_t sum = calculate_acpi_checksum(&data[start_offset], table_len); + data[checksum_offset] = 0xff - sum + 1; +} + void acpi_table_end(BIOSLinker *linker, AcpiTable *desc) { /* @@ -1748,8 +1767,14 @@ void acpi_table_end(BIOSLinker *linker, AcpiTable *desc) */ memcpy(len_ptr, &table_len_le, sizeof table_len_le); - bios_linker_loader_add_checksum(linker, ACPI_BUILD_TABLE_FILE, - desc->table_offset, table_len, desc->table_offset + checksum_offset); + if (linker != NULL) { + bios_linker_loader_add_checksum(linker, ACPI_BUILD_TABLE_FILE, + desc->table_offset, table_len, + desc->table_offset + checksum_offset); + } else { + update_acpi_checksum(desc->array->data, desc->table_offset, + table_len, desc->table_offset + checksum_offset); + } } void *acpi_data_push(GArray *table_data, unsigned size) -- 2.52.0