From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5916234EF1E for ; Thu, 29 Jan 2026 01:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769649383; cv=none; b=ayyp+nj1xOP+ZvrydB2b8Lu5q0sjkYouahbt899JZ5T7XpXglPxFAuUifuKffLb4EOqxuVAg8JrmCdQzS9Clv0hvo5HTY1vXXfr9HrgPHOaYzrxbqscTjAvpw/dU8Gk6zr7erz3D0uOhWy6HHOO51dAOdqo1cE5VVWGgx0iUsgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769649383; c=relaxed/simple; bh=nHJ7z1F0QJ+ff3YYPLezHicV71ohVDGuIQUyQzSTkzQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NbnrojcSQMMWolc5G4jDX6UwcJ14ondqRD/gGaNiCFRKeSSIM/vtdg67s8GXYBHYN3lRhWeHEOpjUZ8sevOoM0ENHn9VagrhdI8ttHVYHlk4mWZiiJuOP5N0jPqHKokouUQNt3tyKcfXG2gjupAp1nqwO/r9Wc4OWl1PI03dxpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=JimtEvw/; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="JimtEvw/" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8c6a7638f42so62569185a.2 for ; Wed, 28 Jan 2026 17:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1769649380; x=1770254180; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WReYS7VDfIh+dvxdrk0biwhaBbpxlirvLLAI4b8c7GA=; b=JimtEvw/M9s1zQiNQoK5XBOJVKAPBC0ZPH+Ww+nhg7HM120zXzPPDFQ66dxw3qVIkh 41KFAv5+ldYueku3BLZMrAHudLNNK/pjzR325IvCVYgAjfezrdFp+Ypjnmcs8Z2WWpms Hnkz7ru3rUgn6MmQTBlVKZp0y6quJVwOYGhjcKcvZIbHB6f3VZF4HrJ7ENAeKE+2Ukuy zFMq8IZPJX1HkYQk1TQQorMGWwZZ6+bCDV3o+M0HD2kYBy6jefimyqAQy7F5U5BqRVtD kUo6mdW+EKWp7Wa5NI1ztftQRXc17I8/6KEDYfze9hhVxHgoa/rcyB0qcWZAHLRDjYK9 vixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769649380; x=1770254180; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WReYS7VDfIh+dvxdrk0biwhaBbpxlirvLLAI4b8c7GA=; b=uYSjfjM3z3y6XQfQpytVRxzBGFjGV4UqMhi2oBYxw5bOucbAXjDJ6np56xx7En1YHB JUzP3jZXw9545VJ03av98HWCCKhXHhN/2nhNtEHJRSZqzI9WvOIWqC010MOLKqy04YQ2 GXiXope/5iVodIvQAsHVqnJ9o+FtvvVvJnhEN2co/a+EG/CUedQnNIn+MA1hENYdm61n 7SZTmkqRyAjzkHWwGttqcc8Xy7cUSosoMzo0LxwhS/KJVNIfdZ+wlRnZey7MB7TWQJmD YKqL4+I4q8kt56v05ji8BquFbRT6xn57NcSfTJpHgUeboyQac9UN3Mrlpdxds2yMejgY XIlw== X-Forwarded-Encrypted: i=1; AJvYcCVHPTolqMHO2KDjutNwPqvFjWvBQFOKJmdWJO3loz6jQrBsYnQHKC176RS2+yHa9ltd+Ts=@vger.kernel.org X-Gm-Message-State: AOJu0YzX8Qg0D/qhEzUSgPR78Lj8J6PZ9rQSZC+DGE1dVyiAxzbi/XjI TkRiccSX0In/8n3aPMb3/JHIgJ8XM44L2v1esJ1u7fbzZG+6KjNm6WhXWo0j7feIRMg= X-Gm-Gg: AZuq6aJT+b0JJf+0WyinFXZrsRxXLt8VEt9ZtswF51+CegN2LC1fEhYN99ZzSkCefzr 3rD0kSHStz1Vsc5iE/qwQt//aKch1HM+mvfRdS5Po4sNYHRxTBc9r4Cbeui2LHLOMu6k1YnUfrl 9wNkDjE6rX0Xa/6pvYJSNLz3uFbTV2WFJR+Lm0vMQEiC2Wb13JaBo8KYpbT1ggWYUM0BywmFu/6 LMGgT6k84ROj2KZzBRm+OppEUlweEPa5BarW3ZD/HN+B/As1UIoi1rRSHg7wYwxhGlpTb4m37BF JZI/4UpqHHEespiBItGCIBYpReK4oACH/r+A720qOyWijN/BGnlND3LNA7TYf2GlVHXfp2VfYyF 0VAJ+WCGPGD9MIZCrSNzCMNO6TqXgNtI4Y5HIvxASaLZgFlta7CS3ma6fuTH6absw9ruVmNrIlJ 7diTnMJEYOS5snqyDIWU2yAtPTXgzJPxKy82sEwSxTaYcHo+yXc8PaFk2ePw9ojt8yKto= X-Received: by 2002:a05:620a:d88:b0:8c5:2ce6:dca with SMTP id af79cd13be357-8c70b841159mr939733985a.6.1769649380018; Wed, 28 Jan 2026 17:16:20 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c711d2ab04sm283038485a.25.2026.01.28.17.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 17:16:19 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vlGdu-00000009gKo-3mMh; Wed, 28 Jan 2026 21:16:18 -0400 Date: Wed, 28 Jan 2026 21:16:18 -0400 From: Jason Gunthorpe To: Sean Christopherson Cc: Ackerley Tng , Alexey Kardashevskiy , cgroups@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, akpm@linux-foundation.org, binbin.wu@linux.intel.com, bp@alien8.de, brauner@kernel.org, chao.p.peng@intel.com, chenhuacai@kernel.org, corbet@lwn.net, dave.hansen@intel.com, dave.hansen@linux.intel.com, david@redhat.com, dmatlack@google.com, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, haibo1.xu@intel.com, hannes@cmpxchg.org, hch@infradead.org, hpa@zytor.com, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maobibo@loongson.cn, mathieu.desnoyers@efficios.com, maz@kernel.org, mhiramat@kernel.org, mhocko@kernel.org, mic@digikod.net, michael.roth@amd.com, mingo@redhat.com, mlevitsk@redhat.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, peterx@redhat.com, pgonda@google.com, prsampat@amd.com, pvorel@suse.cz, qperret@google.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, rostedt@goodmis.org, roypat@amazon.co.uk, rppt@kernel.org, shakeel.butt@linux.dev, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, tglx@linutronix.de, thomas.lendacky@amd.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, wyihan@google.com, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Subject: Re: [RFC PATCH v1 05/37] KVM: guest_memfd: Wire up kvm_get_memory_attributes() to per-gmem attributes Message-ID: <20260129011618.GA2307128@ziepe.ca> References: <071a3c6603809186e914fe5fed939edee4e11988.1760731772.git.ackerleytng@google.com> <07836b1d-d0d8-40f2-8f7b-7805beca31d0@amd.com> <20260129003753.GZ1641016@ziepe.ca> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 28, 2026 at 05:03:27PM -0800, Sean Christopherson wrote: > For a dmabuf fd, the story is the same as guest_memfd. Unless private vs. shared > is all or nothing, and can never change, then the only entity that can track that > info is the owner of the dmabuf. And even if the private vs. shared attributes > are constant, tracking it external to KVM makes sense, because then the provider > can simply hardcode %true/%false. Oh my I had not given that bit any thought. My remarks were just about normal non-CC systems. So MMIO starts out shared, and then converts to private when the guest triggers it. It is not all or nothing, there are permanent shared holes in the MMIO ranges too. Beyond that I don't know what people are thinking. Clearly VFIO has to revoke and disable the DMABUF once any of it becomes private. VFIO will somehow have to know when it changes modes from the TSM subsystem. I guess we could have a special channel for KVM to learn the shared/private page by page from VFIO as some kind of "aware of CC" importer. I suppose AMD needs to mangle the RMP when it changes, and KVM has to do that. I forget what ARM does, but I seem to recall there is a call to create a vPCI function and that is what stuffs the S2? So maybe KVM isn't even involved? (IIRC people were talking that something else would call the vPCI function but I haven't seen patches) No idea what x86 does beyond it has to unmap all the MMIO otherwise the machine crashes :P Oh man, what a horrible mess to even contemplate. I'm going to bed. Jason