public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marc Morcos <marcmorcos@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	"Dr . David Alan Gilbert" <dave@treblig.org>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/4] Clean up TSAN warnings
Date: Tue, 3 Feb 2026 11:32:34 -0500	[thread overview]
Message-ID: <20260203113137-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251213001443.2041258-1-marcmorcos@google.com>

On Sat, Dec 13, 2025 at 12:14:39AM +0000, Marc Morcos wrote:
> When running several tests with tsan, thread races were detected when reading certain variables. This should allieviate the problem.
> Additionally, the apicbase member of APICCommonState has been updated to 64 bit to reflect its 36 bit contents.


Doing a sweep over old threads, Paolo iiuc you will be
fixing it all up differently, yourself?

> Marc Morcos (4):
>   apic: Resize APICBASE
>   thread-pool: Fix thread race
>   qmp: Fix thread race
>   apic: Make apicbase accesses atomic to fix data race
> 
>  hw/i386/kvm/apic.c              | 12 ++++++++----
>  hw/intc/apic_common.c           | 24 ++++++++++++++----------
>  include/hw/i386/apic_internal.h |  2 +-
>  monitor/monitor.c               | 11 ++++++++++-
>  monitor/qmp.c                   |  6 ++++--
>  util/thread-pool.c              | 30 ++++++++++++++++--------------
>  6 files changed, 53 insertions(+), 32 deletions(-)
> 
> -- 
> 2.52.0.239.gd5f0c6e74e-goog


      parent reply	other threads:[~2026-02-03 16:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-13  0:14 [PATCH 0/4] Clean up TSAN warnings Marc Morcos
2025-12-13  0:14 ` [PATCH 1/4] apic: Resize APICBASE Marc Morcos
2025-12-15  9:48   ` Alex Bennée
2025-12-13  0:14 ` [PATCH 2/4] thread-pool: Fix thread race Marc Morcos
2025-12-15 14:43   ` Paolo Bonzini
2025-12-13  0:14 ` [PATCH 3/4] qmp: " Marc Morcos
2025-12-15 14:52   ` Paolo Bonzini
2025-12-13  0:14 ` [PATCH 4/4] apic: Make apicbase accesses atomic to fix data race Marc Morcos
2026-02-03 16:32 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203113137-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=eduardo@habkost.net \
    --cc=kvm@vger.kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=marcmorcos@google.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox