From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736782E285C for ; Sat, 14 Feb 2026 18:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771093131; cv=none; b=myFMmWwOYoSLpFbgAzLXsjQtnorflT3YdEXzkr6L0mE2DmHXbduy4SX23pDeppm/cIDL/mJqkfhs4yRkkuQS1uaLciIaBN8htJirig0/bgMuQ9itskt5lc4xPA1ahFR98ViT8y+etlUpUqiG8GoeTf0bJbCRaEktkp/hPwrjfX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771093131; c=relaxed/simple; bh=yEelQuIDmS5A4nF6l+/HEJSY7JzkT8eOu+50RPHRcm0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B8CKkdHNeK5jjzBjk9MQy7agc2B19VqfgS1FtqS/gy3lt4ibqiDtcImFpIntfwvGxrTCecHL2OHWQ50hXq6tseLk0PcMqgRXS13IYq7CPorz/EYbysTaP87uVXGKUcnT2CTtK9H9fyLQPZ73lKd2plaboS09O8Itx3z3BTi7sn0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zddm+8jF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qdIvS4YA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zddm+8jF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qdIvS4YA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771093129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hGvEkNLWiFwc7xvXmNfeTPVLJWvbXxlHncgYSGzv/5o=; b=Zddm+8jFo542z++7Z3hV3LZIQzSl80rgC8h45DuNw1DMRFNu/LXMo8fvljn03AsqQAvMKv kOXvFrRIOeTTc1983qg+ud6MSuHDTmjA5ZMviEYDsE1gH/n8sw1HpZ7I9/M/lEwui45a44 ewNP6S3ACeRM6MoPmvl8RtgoULwaU/o= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-YWhxqg3kNJGa8Zkm5wf2XQ-1; Sat, 14 Feb 2026 13:18:46 -0500 X-MC-Unique: YWhxqg3kNJGa8Zkm5wf2XQ-1 X-Mimecast-MFC-AGG-ID: YWhxqg3kNJGa8Zkm5wf2XQ_1771093125 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48372facfedso16317765e9.0 for ; Sat, 14 Feb 2026 10:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1771093125; x=1771697925; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hGvEkNLWiFwc7xvXmNfeTPVLJWvbXxlHncgYSGzv/5o=; b=qdIvS4YAkVnmIoOstaP/B0Uq5mvZXin2Kw/oE0qZ+AGOlpqQB5S4kzO5UtIXmqdzJq MjttFGFrX2hq7X9X/7ixu8LObFTlMs91edNW1hO1yHD5mRlOAbQorfkVKf7JZZW7Zofn HBb9U/2tqy8BSCugSz4FaJN1b/eEg5vAgWWjMDymZimEZOwAO00wbMcCgKrLyC2Ow+dB 9TkbDswNKZtB+X3T2CGTufhi/NCrgNXvpmBUCMnd/BUjSOzoXwX8wNyhQSHZEFux1Ofg dSjQd2hQTwEgLEUI4DoBwTQqDkftSCz3DAO6h3J+78Zq2EqUloMK2m7wyRTwhjZnP56O QyiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771093125; x=1771697925; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hGvEkNLWiFwc7xvXmNfeTPVLJWvbXxlHncgYSGzv/5o=; b=r+mwr1Nx5gwUbpuVefEuChS5BC+28MnpwmMU5LrQuHYl9koxhcv5O850StVFTGwKpB GUl/heNJukbRdEvExvlhVMXEFOFQQHpJcs9w7JnKRBJYhCwggCg8Fz+F/96MWVw1mNvo ILD/bWnfa1Vu1OmS6GFvJVd3ILkvvS1brtAu0LPn1qo7Kr9+zEfOL0KMNwwRmL1qCQx8 zKvHx6xCbBCHCQQrGPyykUfG3rfI7WcqIVWObdb3CRKXWU/1G4K0Kkbyj0xOn1yE1Tb5 TdBezI5ZqnJuza9IzvB1AJxlxpXJEe12SbJ5AGu8ha/SfqBVDfdkSqoHoSJm/uuswAHa MQww== X-Forwarded-Encrypted: i=1; AJvYcCVh6uzUZm3WxQQBO9Tg0/GPzaYytjullQa5s5Y4Nx1BaQV9w2uAXeqtAXwSuTp1pF4bn88=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8TZrwGxZyAM9BSvLJY3yf7Sn6TwR2vzY2zwOguW9oAsyyux/G MhimRMveNYIE7u56lBOvUEvP09wimRE0xVUMDLNFdnTMIgGcvpg2RfBq0gJ674lUfz5eqc2wbNO jQOuLF0/GXycSOG34SeeHIuzoSw/GjD5g4+fbmM0p68sWq8TAtBM25Q== X-Gm-Gg: AZuq6aJKg5HYzq3QfZrA17MgqGcqxfz5uk1R67+MvqyfIPuqCSPU173QwrEQsDRqJqL DK5U4reBbflm+ZnwkgpepzDZvFt5eYr1u8q5V/oDW8zvsyuB9FdTgrUl1ljCpwWhQIn6yMPb6lJ 57umy5OSMVPT2fzZdvQk6cr0ljhj9GwgKumsOCzjRToI2Ooy6w7hdNsbXZXXierYYHbK/l+ZDQM oeW0l1tbVzMFL/L237qnKC8fP4SyEmszV7AWbd4ZN5i9jiX2L5ngRqFWxACVzUCsU3ETnxs8wIr Rkxv1DuUKfAWf5qMhNq5nYJ7qFvM5Q14n3Qr1ML1FB7ogah+ummpebZnuB31XxjiqEKLZNv4Xu0 H4EmOHhmKcWGS8tcFvA== X-Received: by 2002:a05:600c:40c4:b0:47d:403a:277 with SMTP id 5b1f17b1804b1-48378f062b0mr48481455e9.4.1771093125064; Sat, 14 Feb 2026 10:18:45 -0800 (PST) X-Received: by 2002:a05:600c:40c4:b0:47d:403a:277 with SMTP id 5b1f17b1804b1-48378f062b0mr48481055e9.4.1771093124647; Sat, 14 Feb 2026 10:18:44 -0800 (PST) Received: from redhat.com ([2a06:c701:73e3:8f00:866c:5eeb:fc46:7674]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4837e565f5esm65320555e9.10.2026.02.14.10.18.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Feb 2026 10:18:44 -0800 (PST) Date: Sat, 14 Feb 2026 13:18:41 -0500 From: "Michael S. Tsirkin" To: Simon Schippers Cc: Jason Wang , willemdebruijn.kernel@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eperezma@redhat.com, leiyang@redhat.com, stephen@networkplumber.org, jon@nutanix.com, tim.gebauer@tu-dortmund.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH net-next v7 3/9] tun/tap: add ptr_ring consume helper with netdev queue wakeup Message-ID: <20260214131703-mutt-send-email-mst@kernel.org> References: <0ebc00ba-35e7-4570-a44f-b0ae634f2316@tu-dortmund.de> <197573a1-df52-4928-adb9-55a7a4f78839@tu-dortmund.de> <0c776172-2f02-47fc-babf-2871adca42cb@tu-dortmund.de> <205aa139-975d-4092-aa04-a2c570ae43a6@tu-dortmund.de> <59529fd2-2a08-4a89-a853-27198b76f842@tu-dortmund.de> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59529fd2-2a08-4a89-a853-27198b76f842@tu-dortmund.de> On Sat, Feb 14, 2026 at 06:13:14PM +0100, Simon Schippers wrote: ... > Patched: Waking on __ptr_ring_produce_created_space() is too early. The > stop/wake cycle occurs too frequently which slows down > performance as can be seen for TAP. > > Wake on empty variant: Waking on __ptr_ring_empty() is (slightly) too > late. The consumer starves because the producer > first has to produce packets again. This slows > down performance aswell as can be seen for TAP > and TAP+vhost-net (both down ~30-40Kpps). > > I think something inbetween should be used. > The wake should be done as late as possible to have as few > NET_TX_SOFTIRQs as possible but early enough that there are still > consumable packets remaining to not starve the consumer. > > However, I can not think of a proper way to implement this right now. > > Thanks! What is the difficulty? Your patches check __ptr_ring_consume_created_space(..., 1). How about __ptr_ring_consume_created_space(..., 8) then? 16? -- MST