public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex@shazbot.org>
To: Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>
Cc: jgg@ziepe.ca, yishaih@nvidia.com, skolothumtho@nvidia.com,
	kevin.tian@intel.com, giovanni.cabiddu@intel.com,
	kvm@vger.kernel.org, qat-linux@intel.com, alex@shazbot.org
Subject: Re: [PATCH] vfio/qat: extend Kconfig dependencies for 420xx and 6xxx devices
Date: Mon, 9 Mar 2026 17:02:47 -0600	[thread overview]
Message-ID: <20260309170247.2bd96b78@shazbot.org> (raw)
In-Reply-To: <20260213091403.72338-1-suman.kumar.chakraborty@intel.com>

On Fri, 13 Feb 2026 09:14:03 +0000
Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com> wrote:

> From: Vijay Sundar Selvamani <vijay.sundar.selvamani@intel.com>
> 
> Currently, the QAT VFIO PCI driver can only be configured when the 4xxx
> QAT driver (CRYPTO_DEV_QAT_4XXX) is enabled. This is too restrictive as
> the VFIO driver also supports VFs from the 420xx and 6xxx device
> families, which share a compatible migration interface.
> 
> Extends the Kconfig dependencies to allow configuration when any of the
> supported QAT device families (4xxx, 420xx, or 6xxx) are enabled.

420xx seems to be device ID 0x4947:

drivers/crypto/intel/qat/qat_common/adf_accel_devices.h
#define PCI_DEVICE_ID_INTEL_QAT_420XXIOV 0x4947

We don't currently have that in the ID table for the vfio qat driver:

static const struct pci_device_id qat_vf_vfio_pci_table[] = {
        /* Intel QAT GEN4 4xxx VF device */
        { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_INTEL, 0x4941) },
        { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_INTEL, 0x4943) },
        { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_INTEL, 0x4945) },
        /* Intel QAT GEN6 6xxx VF device */
        { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_INTEL, 0x4949) },
        {}
};

Are we missing support for this device and is this Kconfig change
therefore a little overeager?  Thanks,

Alex

> Signed-off-by: Vijay Sundar Selvamani <vijay.sundar.selvamani@intel.com>
> Signed-off-by: Suman Kumar Chakraborty <suman.kumar.chakraborty@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
>  drivers/vfio/pci/qat/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/qat/Kconfig b/drivers/vfio/pci/qat/Kconfig
> index bf52cfa4b595..83f037d7e9a4 100644
> --- a/drivers/vfio/pci/qat/Kconfig
> +++ b/drivers/vfio/pci/qat/Kconfig
> @@ -2,7 +2,7 @@
>  config QAT_VFIO_PCI
>  	tristate "VFIO support for QAT VF PCI devices"
>  	select VFIO_PCI_CORE
> -	depends on CRYPTO_DEV_QAT_4XXX
> +	depends on CRYPTO_DEV_QAT_4XXX || CRYPTO_DEV_QAT_420XX || CRYPTO_DEV_QAT_6XXX
>  	help
>  	  This provides migration support for Intel(R) QAT Virtual Function
>  	  using the VFIO framework.
> 
> base-commit: b10c62483b324e60e45fb27d7fdc09c9198993d7


  reply	other threads:[~2026-03-09 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  9:14 [PATCH] vfio/qat: extend Kconfig dependencies for 420xx and 6xxx devices Suman Kumar Chakraborty
2026-03-09 23:02 ` Alex Williamson [this message]
2026-03-10 17:27   ` Giovanni Cabiddu
2026-03-10 17:40     ` Alex Williamson
2026-03-20 21:18 ` Alex Williamson
2026-03-20 21:40   ` Giovanni Cabiddu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309170247.2bd96b78@shazbot.org \
    --to=alex@shazbot.org \
    --cc=giovanni.cabiddu@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=qat-linux@intel.com \
    --cc=skolothumtho@nvidia.com \
    --cc=suman.kumar.chakraborty@intel.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox