Re: [RFC PATCH v3 5/6] KVM: Rename mn_* invalidate-related fields to generic ones

[Takahiro Itazuri <itazur@amazon.com>]

On Wed, 11 Mar 2026 13:57:30 -0700, Sean Christopherson wrote:
> On Tue, Mar 10, 2026, Takahiro Itazuri wrote:
> > The addition of guest_memfd support to pfncaches introduces additional
> > sources of pfncache invalidation beyond the MMU notifier path.  The
> > existing mn_* naming implies that they are only relevant to MMU
> > notifiers, which is no longer true.
> 
> I very strongly disagree.  Except for kvm_swap_active_memslots() and
> kvm_create_vm(), literally every function here has mmu_notifier in its name.
> 
> They no longer are used only the for the _kernel's_ MMU-notifier implementation,
> but they're still very much scoped explicitly to KVM's overarching MMU notification
> system.
>
> If we want to come up with a "better" name, then it needs to capture that somewhere
> in the prefix.  Because e.g. invalidate_lock is way, way too generic.  I read that
> and my very first question is "ivalidate what, exactly?".  Ditto for
> memslots_update_rcuwait and pretty much every other field.

That makes sense to me.  I only had the kernel's MMU notifier in mind
at that time, which is why I thought this renaming would be appropriate.

Since I'm not particularly seeking a better name, I'll leave these as
they are.