From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675353264DC for ; Mon, 16 Mar 2026 16:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773677101; cv=none; b=O5QDC+eVgc3Zy6bqOgTsACFeprspDJYsxjCTH5g1V58OyS3JQ7TkHMqO7liG9Pxv0G/g/U2UDrjiAPydBk7CUElaHBkl637Z3jd4FIO/V0WmT9iYzeDcNFfkjiFoJy5lIzHVE3lyrADFK6QeN8KO/uVibNxJdQpVDw76D9HOudA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773677101; c=relaxed/simple; bh=pnPMIg6QAJhhfdXh1P/12ht0oe+xBK5/i0AcyCLYy1s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qfHHQxJV6TR5ROiapuwo9FXX938/G2tTvtN+rRzw1+ahAO74SRTDDlZnCq1DSo22zHKRy34jXDm+Fxr930CjZ5IWukKW7X9CoegKq326Xj9DCZmve0IfZcgIb44Hdnf/D7XKMclNJ5eTAYbxN65klNqAAuA55sQwB+KHs9Tag1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BmZHXHcG; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BmZHXHcG" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2b052ec7176so93975ad.1 for ; Mon, 16 Mar 2026 09:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773677100; x=1774281900; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x9RU4Mq6bXwi7763tJq20duY+x4lhVoegGX5yfdZIpA=; b=BmZHXHcGJzYaI37c8BNWaiYCMivWtKyuq2oIQA+zrVNsgHcNRJeLBNiGc/b9XMmjox REcRfSnIa+BHCwdtM/J7AKMJhmD2nKUcYn4H1Hjv/73RMiOwzjh35UY+YZVPTS59/iSM 1YPelz89za90uNuVPmnw8be1a4I2fB7rjQyjtuLZVxrHGvcCOmzm/0l1DbnaeiOQfqJR SMYfQuFr+0qDrFL/mVHVsdybWPG9Eb30Ty70c2J2BSKDgHATcleAFEjy+g+IVbxgIjeG 3owJZuNbCyzutxl1wQ3Pu+flC0BLlyvCxBGQg0uf84ye4w1sr1EFdDKZcI1h1/aoyt1e FQZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773677100; x=1774281900; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x9RU4Mq6bXwi7763tJq20duY+x4lhVoegGX5yfdZIpA=; b=Q6Jz9wIGDQckRBZWxyMLlK4h05uyqylxOxQLJzJEcXbP6Mnr/KtKnD72DGXLApCdIy KKqtGEyoLC2o8aIsPhgy/QSXjkP0hmOv8hkcLFug5VsYfATLZXbYXUhTBODcfRqrRtGV PHO9HqHKAQCaK/rzf/vPbIIa84DneNVY5VmI5MF7+AOmymksvgYpGMNYzDOmByS4aTEo tbyF+2tGsVN1He2tYk1g82I3lt4rB95Z/YC64P/0RBRzDNR8W9gzynKk/MTj3Au6arpu rkGwDGBOg0oUEEBNi7GvMreUZIhdJEJC8UdMOEhrbEGvdf5W+S3lqS8Os1hHC6hxDfZL Qy3g== X-Forwarded-Encrypted: i=1; AJvYcCV1Uwbt/c/Sca25Af12Ky+R5F+7OAtLLtEUP9AuZJstwoxYdhbIl/avFhctlAtOQ6lBHeI=@vger.kernel.org X-Gm-Message-State: AOJu0YyPuTutIXVw+ycXqr5UYJ6DKCkN7TtXEON9K0U85EEeyLg5hlQd Uo+C1TGoYER4xau/k8CSn7KR0JvQJ8aiMWYK+SVWHx1sQ8isWakhGa4tWHS8bQc3Jg== X-Gm-Gg: ATEYQzx4xLFNV9XeGteK/Hq85S6C4YqEh0GSnQG7oNYw/yXGPQkjTwdxQHXtfh36qJc HAKT8Vv524wMLikHNKTwQZFQdHjItuR9DEHHSv6VjUPtxqv6UIWtXD0PTQ/noLkfiEQUpg9o6ur rAC9s3edd/zyEw6iDWK7J36Xur/Xjpgdrpa5opQe2eHJjWvrny0WV2hy4xQgdJwbzUyrUGRicVu vWqY3x/SFW8FrtxSrO3wa6hzPkV2su5A4Gij2//skl0DinKZ0F6ZuqsUrCrCZWpy8KwOLe54fCK 4ZgRKCrE8sCGrBLwtZUB+lMOlyuoO7T0ya8Z9vxCEhMoGt9WV9fPScy7RvCPitaLZCM24hDsC4M vBFZjTZtv7q6iFpQD4C1w43mMWspIPXrc2Kr7hBJPvuwfK2WYrmlMxaVBhqkEaanjsVPcr8xLHy EwOPApFcB/Zi939W9PjkozmpZsCMN4io4O70DWrLMTDOAIUglNSumlYtKuZMlz X-Received: by 2002:a17:902:ce0f:b0:2ae:575f:3755 with SMTP id d9443c01a7336-2b04215e0c7mr4424785ad.20.1773677099288; Mon, 16 Mar 2026 09:04:59 -0700 (PDT) Received: from google.com (176.13.105.34.bc.googleusercontent.com. [34.105.13.176]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b048527a19sm71890555ad.7.2026.03.16.09.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 09:04:58 -0700 (PDT) Date: Mon, 16 Mar 2026 09:04:54 -0700 From: Vipin Sharma To: David Matlack Cc: Alex Williamson , Adithya Jayachandran , Alexander Graf , Alex Mastro , Alistair Popple , Andrew Morton , Ankit Agrawal , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Kevin Tian , kexec@lists.infradead.org, kvm@vger.kernel.org, Leon Romanovsky , Leon Romanovsky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Lukas Wunner , =?utf-8?Q?Micha=C5=82?= Winiarski , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Raghavendra Rao Ananta , Rodrigo Vivi , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Tomita Moeko , Vivek Kasireddy , William Tu , Yi Liu , Zhu Yanjun Subject: Re: [PATCH v2 16/22] vfio: selftests: Add vfio_pci_liveupdate_uapi_test Message-ID: <20260314073250.GE4177610.vipinsh@google.com> References: <20260129212510.967611-1-dmatlack@google.com> <20260129212510.967611-17-dmatlack@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260129212510.967611-17-dmatlack@google.com> On Thu, Jan 29, 2026 at 09:25:03PM +0000, David Matlack wrote: > + > +TEST_F(vfio_pci_liveupdate_uapi_test, preserve_device) > +{ > + int ret; > + > + ret = luo_session_preserve_fd(self->session_fd, self->device->fd, 0); > + > + /* Preservation should only be supported for VFIO cdev files. */ > + ASSERT_EQ(ret, self->iommu->iommufd ? 0 : -ENOENT); > +} > + > +TEST_F(vfio_pci_liveupdate_uapi_test, preserve_group_fails) > +{ > + int ret; > + > + if (self->iommu->iommufd) > + return; for iommufd variant, should we mark test as skipped instead of showing it as passed? > +int main(int argc, char *argv[]) > +{ > + int fd; > + > + fd = luo_open_device(); > + if (fd < 0) { > + printf("open(%s) failed: %s, skipping\n", LUO_DEVICE, strerror(errno)); > + return KSFT_SKIP; Both can be combined using ksft_exit_skip()