public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Hisam Mehboob <hisamshar@gmail.com>
To: pbonzini@redhat.com, shuah@kernel.org, seanjc@google.com
Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Hisam Mehboob <hisamshar@gmail.com>,
	Aqib Faruqui <aqibaf@amazon.com>
Subject: [PATCH] KVM: selftests: Guard execinfo.h inclusion for non-glibc builds
Date: Thu, 19 Mar 2026 05:08:43 +0500	[thread overview]
Message-ID: <20260319000842.1213426-2-hisamshar@gmail.com> (raw)

The backtrace() function and execinfo.h are GNU extensions available
in glibc but not in non-glibc C libraries such as musl. Building KVM
selftests with musl-gcc fails with:

  lib/assert.c:9:10: fatal error: execinfo.h: No such file or directory

Guard the inclusion of execinfo.h under #ifdef __GLIBC__, and wrap
all backtrace() usage under the same guard with a fallback message
for non-glibc builds indicating that stack traces are not available.

Unlike the approach of adding a weak stub for backtrace(), this
explicitly handles the non-glibc case rather than silently providing
an empty implementation.

Link: https://lore.kernel.org/kvm/20250829142556.72577-7-aqibaf@amazon.com/

Suggested-by: Aqib Faruqui <aqibaf@amazon.com>
Signed-off-by: Hisam Mehboob <hisamshar@gmail.com>
---
 tools/testing/selftests/kvm/lib/assert.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/testing/selftests/kvm/lib/assert.c b/tools/testing/selftests/kvm/lib/assert.c
index b49690658c60..3442b80c37c1 100644
--- a/tools/testing/selftests/kvm/lib/assert.c
+++ b/tools/testing/selftests/kvm/lib/assert.c
@@ -6,7 +6,9 @@
  */
 #include "test_util.h"
 
+#ifdef __GLIBC__
 #include <execinfo.h>
+#endif
 #include <sys/syscall.h>
 
 #include "kselftest.h"
@@ -15,6 +17,7 @@
 static void __attribute__((noinline)) test_dump_stack(void);
 static void test_dump_stack(void)
 {
+#ifdef __GLIBC__
 	/*
 	 * Build and run this command:
 	 *
@@ -56,6 +59,10 @@ static void test_dump_stack(void)
 #pragma GCC diagnostic ignored "-Wunused-result"
 	system(cmd);
 #pragma GCC diagnostic pop
+
+#else /* !__GLIBC__ */
+	fputs("  (stack trace not available: compiled without glibc)\n", stderr);
+#endif
 }
 
 static pid_t _gettid(void)
-- 
2.51.0


             reply	other threads:[~2026-03-19  0:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19  0:08 Hisam Mehboob [this message]
2026-03-24 18:02 ` [PATCH] KVM: selftests: Guard execinfo.h inclusion for non-glibc builds Shuah Khan
2026-03-25 18:03   ` Shuah Khan
2026-03-25 18:47     ` Hisam Mehboob
2026-03-31 23:09       ` Shuah Khan
2026-04-01 14:01         ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319000842.1213426-2-hisamshar@gmail.com \
    --to=hisamshar@gmail.com \
    --cc=aqibaf@amazon.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox