From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, qemu-arm@nongnu.org,
"Anton Johansson" <anjo@rev.ng>,
qemu-s390x@nongnu.org,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
qemu-riscv@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alistair Francis" <alistair.francis@wdc.com>
Subject: [PATCH-for-11.1 v2 2/9] accel/kvm: Include missing 'exec/vaddr.h' and 'qemu/queue.h' headers
Date: Thu, 2 Apr 2026 19:04:27 +0200 [thread overview]
Message-ID: <20260402170434.94783-3-philmd@linaro.org> (raw)
In-Reply-To: <20260402170434.94783-1-philmd@linaro.org>
Commit b67be03e3ac ("accel/kvm: Widen pc/saved_insn for
kvm_sw_breakpoint") used the vaddr type in the kvm_sw_breakpoint
structure but forgot to include the header defining it. It is
however indirectly included via "cpu.h", which we want to remove.
The QTAILQ_ENTRY() macro is defined in "qemu/queue.h". Include
both headers in order to avoid later when refactoring unrelated
headers:
include/system/kvm.h:398:5: error: expected specifier-qualifier-list before ‘QTAILQ_ENTRY’
398 | QTAILQ_ENTRY(kvm_sw_breakpoint) entry;
| ^~~~~~~~~~~~
include/system/kvm.h:404:5: error: unknown type name 'vaddr'
404 | vaddr pc;
| ^~~~~
include/system/kvm.h:405:5: error: unknown type name 'vaddr'
405 | vaddr saved_insn;
| ^~~~~
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/system/kvm.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/system/kvm.h b/include/system/kvm.h
index 5fa33eddda3..b5763a562d7 100644
--- a/include/system/kvm.h
+++ b/include/system/kvm.h
@@ -17,7 +17,9 @@
#define QEMU_KVM_H
#include "exec/memattrs.h"
+#include "exec/vaddr.h"
#include "qemu/accel.h"
+#include "qemu/queue.h"
#include "qom/object.h"
#ifdef COMPILING_PER_TARGET
--
2.53.0
next prev parent reply other threads:[~2026-04-02 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 17:04 [PATCH-for-11.1 v2 0/9] target/arm: Compile accelerator-related objects as common code Philippe Mathieu-Daudé
2026-04-02 17:04 ` [PATCH-for-11.1 v2 1/9] accel/kvm: Include missing 'exec/cpu-common.h' header Philippe Mathieu-Daudé
2026-04-02 17:04 ` Philippe Mathieu-Daudé [this message]
2026-04-02 17:04 ` [PATCH-for-11.1 v2 3/9] accel/kvm: Remove TARGET_KVM_HAVE_GUEST_DEBUG Philippe Mathieu-Daudé
2026-04-02 17:04 ` [PATCH-for-11.1 v2 4/9] accel/kvm: Expose all non-target specific declarations Philippe Mathieu-Daudé
2026-04-02 18:02 ` Philippe Mathieu-Daudé
2026-04-02 17:04 ` [PATCH-for-11.1 v2 5/9] target/arm: Compile WHPX as common object Philippe Mathieu-Daudé
2026-04-02 17:04 ` [PATCH-for-11.1 v2 6/9] target/arm: Remove target_ulong use in hvf_handle_psci_call() Philippe Mathieu-Daudé
2026-04-02 17:04 ` [PATCH-for-11.1 v2 7/9] target/arm: Compile HVF as common object Philippe Mathieu-Daudé
2026-04-02 17:04 ` [PATCH-for-11.1 v2 8/9] target/arm: Remove target_ulong cast in kvm_arm_handle_dabt_nisv() Philippe Mathieu-Daudé
2026-04-02 17:04 ` [PATCH-for-11.1 v2 9/9] target/arm: Compile KVM as common object Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402170434.94783-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=anjo@rev.ng \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox