Re: [PATCH] VFIO: remove dead notifier code

Paolo Bonzini
2026-04-08T14:36:56Z

On Wed, Apr 8, 2026 at 4:35 PM Anthony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>
> > open_device:
> > - The vfio_ap driver uses this callback to register a
> > - VFIO_GROUP_NOTIFY_SET_KVM notifier callback function for the matrix mdev
> > - devices. The open_device callback is invoked by userspace to connect the
> > - VFIO iommu group for the matrix mdev device to the MDEV bus. Access to the
> > - KVM structure used to configure the KVM guest is provided via this callback.
> > - The KVM structure, is used to configure the guest's access to the AP matrix
> > - defined via the vfio_ap mediated device's sysfs attribute files.
> > + the open_device callback is invoked by userspace to connect the
>
> Capitalization:
> s/the open_device callback/The open device callback/
>
> > + VFIO iommu group for the matrix mdev device to the MDEV bus. The
> > + callback retrieves the KVM structure used to configure the KVM guest
> > + and configures the guest's access to the AP matrix defined via the
> > + vfio_ap mediated device's sysfs attribute files.
> >
> > close_device:
> > - unregisters the VFIO_GROUP_NOTIFY_SET_KVM notifier callback function for the
> > - matrix mdev device and deconfigures the guest's AP matrix.
> > + this callback deconfigures the guest's AP matrix.
>
> Capitalization:
> s/this callback/This callback/

Heh, I had to pick one or the other (close_device previously used
lowercase) and chose the wrong one. :)

Thanks for reviewing the s390 docs, I wasn't sure about the new text was enough.

Paolo