Re: [PATCH] VFIO: remove dead notifier code

Paolo Bonzini
2026-04-08T22:01:01Z

On Wed, Apr 8, 2026 at 4:36 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On Wed, Apr 8, 2026 at 4:35 PM Anthony Krowiak <akrowiak@linux.ibm.com> wrote:
> >
> >
> > > open_device:
> > > - The vfio_ap driver uses this callback to register a
> > > - VFIO_GROUP_NOTIFY_SET_KVM notifier callback function for the matrix mdev
> > > - devices. The open_device callback is invoked by userspace to connect the
> > > - VFIO iommu group for the matrix mdev device to the MDEV bus. Access to the
> > > - KVM structure used to configure the KVM guest is provided via this callback.
> > > - The KVM structure, is used to configure the guest's access to the AP matrix
> > > - defined via the vfio_ap mediated device's sysfs attribute files.
> > > + the open_device callback is invoked by userspace to connect the
> >
> > Capitalization:
> > s/the open_device callback/The open device callback/
> >
> > Capitalization:
> > s/this callback/This callback/
>
> Heh, I had to pick one or the other (close_device previously used
> lowercase) and chose the wrong one. :)

I was going to make the change, but then noticed that lowercase is
more common in the file:

create:
allocates the ap_matrix_mdev structure used by the vfio_ap driver to:

remove:
deallocates the vfio_ap mediated device's ap_matrix_mdev structure.
This will be allowed only if a running guest is not using the mdev.

ioctl:
this callback handles the VFIO_DEVICE_GET_INFO and VFIO_DEVICE_RESET
ioctls defined by the vfio framework.

What do you think?

Paolo