From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a6-smtp.messagingengine.com (fout-a6-smtp.messagingengine.com [103.168.172.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04F9F345738; Mon, 13 Apr 2026 21:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776117514; cv=none; b=LbeWw+/WtEteAOj8cyDWQkxP34LhXbGelvFRxACSnhPSCmEmnLg1LvA5B4Bsjz2Aq/3sN2MgMMUV4DwCVlWzKL3iL/syjLK+2bX6ULWQeEg/muaFIB9kjkNwumhe24T+i17L+a8s1cQASCXy1IpW/ofakgZpfxOPv171Zl9YWmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776117514; c=relaxed/simple; bh=C0yQ9BDOsFO04xZMEKxNKTeaCSyYENFuecFymEGCchw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QJB5KarwAIGEHhMJLMFVlyJwEsHyG01jlyZ3E4ykApThfpC3Bi5m8YmepraHY73IhH89r0MM/f7NsMM0ROMM7G5M0mfaULqzfZg+0g47a1x2+5HqjTD2vMZg3vyi+fxE08gYPhUBcZGDV9RURcaQC/thPLJg40/2JXbuIrTiZos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org; spf=pass smtp.mailfrom=shazbot.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b=kJgdggOk; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=MA2mEvcW; arc=none smtp.client-ip=103.168.172.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shazbot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shazbot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="kJgdggOk"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MA2mEvcW" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id F0C4BEC0515; Mon, 13 Apr 2026 17:58:29 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Mon, 13 Apr 2026 17:58:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1776117509; x=1776203909; bh=4GkHMXB+cNXlgnY7q7iUg5quFdQWL06EszHzzvx6iBA=; b= kJgdggOk3KxmLPv2DnGRPayw0Dz05sdKkyxHoGRx8a7qFo+Z+CCx8mGKACQeAjrO 9SVG5XuPKfCMk6wX8t9GWWvMmyPGLmfTw8F6SI4v4RojFlmNvlRv3GYUVmijWWzq CBJYDSMNuwz/DuR5ds/27LC5lwg32Z64OnJVvwkzraljLATVOES6OS+Z/EVx+4BX 0Uhrg0bvmeD1LI0jFIlB30rfFtP/vStl9u97iNAyAaK3XzaN/ePEtoVQsKRRvXbl m1HoTUgGmpAEWSASnYc2cM56J+FQUDEFLLOykSM6Hh3/L5upTharLjJ22G+ApPEt O+BDTvGJGtFPQue5ihNWvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1776117509; x= 1776203909; bh=4GkHMXB+cNXlgnY7q7iUg5quFdQWL06EszHzzvx6iBA=; b=M A2mEvcWk9qLJp66rAs9lOcGa8v9aurMVhEHIL91x+aIQzMHqVEyXryfXJEraKVQZ EmBpVo9qWwZiWJQZ50/AXEdUttOrADZbEbi5FVcCRhW2bIn5ZFaT1c0sS3EbA8HX IAaeO9N9+9LgtFYg1LMwwfEwKf5o7mFxSv5FbgKEgJP2V6Vuw/GydnYEPXIoI66/ xXS2jtrNe8QxD4arD9zK58a2+PXnxhZAjDJEjxhV50+mfhWAY6tomsJnmTBXmQfG LxQ3zIuJ+CPX9d7GxRtDCiNO+Ikxf4BC4ApvNF0xRFM+cLlnvzjbNONbQszQbHAw LKlVVnX14smPPDitt7V5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdefleefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfgjfhfogggtgfesthhqredtredtjeenucfhrhhomheptehlvgigucgh ihhllhhirghmshhonhcuoegrlhgvgiesshhhrgiisghothdrohhrgheqnecuggftrfgrth htvghrnhepieeuheevjeefgffffffhffegjeejgeevveelhfegleffgfeugfehkeehgfev ffdunecuffhomhgrihhnpehfrhgvvgguvghskhhtohhprdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvgigsehshhgriigsohht rdhorhhgpdhnsggprhgtphhtthhopedutddpmhhouggvpehsmhhtphhouhhtpdhrtghpth htohepmhhitghhrghlrdifihhnihgrrhhskhhisehinhhtvghlrdgtohhmpdhrtghpthht ohepihhnthgvlhdqgigvsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtg hpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhr tghpthhtohepkhhvmhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehjgh hgseiiihgvphgvrdgtrgdprhgtphhtthhopeihihhshhgrihhhsehnvhhiughirgdrtgho mhdprhgtphhtthhopehskhholhhothhhuhhmthhhohesnhhvihguihgrrdgtohhmpdhrtg hpthhtohepkhgvvhhinhdrthhirghnsehinhhtvghlrdgtohhmpdhrtghpthhtohepshht rggslhgvsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Apr 2026 17:58:28 -0400 (EDT) Date: Mon, 13 Apr 2026 15:58:27 -0600 From: Alex Williamson To: =?UTF-8?B?TWljaGHFgg==?= Winiarski Cc: , , , Jason Gunthorpe , Yishai Hadas , "Shameer Kolothum" , Kevin Tian , , alex@shazbot.org Subject: Re: [PATCH v2 1/2] vfio/xe: Reorganize the init to decouple migration from reset Message-ID: <20260413155827.494b7f0e@shazbot.org> In-Reply-To: <20260410224948.900550-1-michal.winiarski@intel.com> References: <20260410224948.900550-1-michal.winiarski@intel.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 11 Apr 2026 00:49:47 +0200 Micha=C5=82 Winiarski wrote: > Attempting to issue reset on VF devices that don't support migration > leads to the following: [...] > This is caused by the fact that some of the xe_vfio_pci_core_device > members needed for handling reset are only initialized as part of > migration init. >=20 > Fix the problem by reorganizing the code to decouple VF init from > migration init. >=20 > Fixes: 1f5556ec8b9ef ("vfio/xe: Add device specific vfio_pci driver varia= nt for Intel graphics") > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/work_items/7352 > Cc: stable@vger.kernel.org > Signed-off-by: Micha=C5=82 Winiarski > --- > drivers/vfio/pci/xe/main.c | 43 ++++++++++++++++++++++---------------- > 1 file changed, 25 insertions(+), 18 deletions(-) Applied to vfio next branch for v7.1. Thanks, Alex