From: Christoph Schlameuss <schlameuss@linux.ibm.com>
To: linux-s390@vger.kernel.org
Cc: "Janosch Frank" <frankja@linux.ibm.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>,
"David Hildenbrand" <david@kernel.org>,
"Thomas Huth" <thuth@redhat.com>,
kvm@vger.kernel.org,
"Christoph Schlameuss" <schlameuss@linux.ibm.com>
Subject: [kvm-unit-tests PATCH v3 4/6] s390x: sclp: Use sclp_feat_check directly to read DIAG318 feature bit
Date: Tue, 21 Apr 2026 13:31:10 +0200 [thread overview]
Message-ID: <20260421-vsie-stfle-fac-v3-4-3cee84efefa3@linux.ibm.com> (raw)
In-Reply-To: <20260421-vsie-stfle-fac-v3-0-3cee84efefa3@linux.ibm.com>
---
lib/s390x/sclp.c | 2 +-
lib/s390x/sclp.h | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c
index d624872cba60..ad2ba99ee1e1 100644
--- a/lib/s390x/sclp.c
+++ b/lib/s390x/sclp.c
@@ -186,7 +186,7 @@ void sclp_facilities_setup(void)
if (read_info->offset_cpu <= 134)
return;
- sclp_facilities.has_diag318 = read_info->byte_134_diag318;
+ sclp_facilities.has_diag318 = sclp_feat_check(134, SCLP_FEAT_134_BIT_DIAG318);
}
/* Perform service call. Return 0 on success, non-zero otherwise. */
diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h
index 42a2f2e9f25a..87af429b5798 100644
--- a/lib/s390x/sclp.h
+++ b/lib/s390x/sclp.h
@@ -144,6 +144,7 @@ struct sclp_facilities {
#define SCLP_FEAT_116_BIT_ESCA 4
#define SCLP_FEAT_117_BIT_PFMFI 1
#define SCLP_FEAT_117_BIT_IBS 2
+#define SCLP_FEAT_134_BIT_DIAG318 0
typedef struct ReadInfo {
SCCBHeader h;
@@ -169,8 +170,6 @@ typedef struct ReadInfo {
uint8_t _reserved5[124 - 122]; /* 122-123 */
uint32_t hmfai;
uint8_t reserved7[134 - 128]; /* 128-133 */
- uint8_t byte_134_diag318 : 1;
- uint8_t : 7;
/*
* At the end of the ReadInfo, there are also the CPU entries (see
* struct CPUEntry). When the Extended-Length SCCB (ELS) feature is
--
2.53.0
next prev parent reply other threads:[~2026-04-21 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 11:31 [kvm-unit-tests PATCH v3 0/6] s390x: Add test for STFLE interpretive execution (format-2) Christoph Schlameuss
2026-04-21 11:31 ` [kvm-unit-tests PATCH v3 1/6] s390x: snippets: Add reset_guest() to lib Christoph Schlameuss
2026-04-21 11:31 ` [kvm-unit-tests PATCH v3 2/6] s390x: sclp: Remove unnecessary padding from struct sclp_facilities Christoph Schlameuss
2026-04-21 11:31 ` [kvm-unit-tests PATCH v3 3/6] s390x: sclp: Rework sclp_facilities_setup() for simpler control flow Christoph Schlameuss
2026-04-21 11:31 ` Christoph Schlameuss [this message]
2026-04-21 11:31 ` [kvm-unit-tests PATCH v3 5/6] s390x: sclp: Add detection of alternate STFLE facilities Christoph Schlameuss
2026-04-21 11:31 ` [kvm-unit-tests PATCH v3 6/6] s390x: Add test for STFLE interpretive execution (format-2) Christoph Schlameuss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421-vsie-stfle-fac-v3-4-3cee84efefa3@linux.ibm.com \
--to=schlameuss@linux.ibm.com \
--cc=david@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox