Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Chenyi Qiang <chenyi.qiang@intel.com>
To: kvm@vger.kernel.org
Cc: Chenyi Qiang <chenyi.qiang@intel.com>,
	Sean Christopherson <seanjc@google.com>,
	Jim Mattson <jmattson@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Gao Chao <chao.gao@intel.com>
Subject: [PATCH v2 0/2] KVM: x86: Fix max_irr reporting when PIR is empty despite PID.ON
Date: Wed, 29 Apr 2026 15:28:06 +0800	[thread overview]
Message-ID: <20260429072851.3004430-1-chenyi.qiang@intel.com> (raw)

Fix a race in the PIR-to-IRR synchronization path where PID.ON is set
but PIR is empty, causing __kvm_apic_update_irr() to report max_irr as
-1 even though there are pending interrupts in the IRR.  This triggers a
spurious WARNING in vmx_check_nested_events() during nested VM stress
tests.

v2:
  - Move the fix from vmx_sync_pir_to_irr() to __kvm_apic_update_irr()
    as suggested by Paolo along with some commit message changes. [Paolo]
  - Add Cc: stable, Suggested-by, Reviewed-by tags.
  - Carry Sean's cleanup patch for variable renames and expanded
    comments. [Sean]

v1: https://lore.kernel.org/kvm/20260428070349.1633238-1-chenyi.qiang@intel.com/

Chenyi Qiang (1):
  KVM: x86: Always report highest IRR from __kvm_apic_update_irr()

Sean Christopherson (1):
  KVM: x86: Fix misleading variable names and add more comments for
    PIR=>IRR flow

 arch/x86/kvm/lapic.c   | 24 +++++++++++++-----------
 arch/x86/kvm/vmx/vmx.c | 40 ++++++++++++++++++++++++++++++++--------
 2 files changed, 45 insertions(+), 19 deletions(-)

-- 
2.43.5


             reply	other threads:[~2026-04-29  7:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  7:28 Chenyi Qiang [this message]
2026-04-29  7:28 ` [PATCH v2 1/2] KVM: x86: Always report highest IRR from __kvm_apic_update_irr() Chenyi Qiang
2026-04-29  7:28 ` [PATCH v2 2/2] KVM: x86: Fix misleading variable names and add more comments for PIR=>IRR flow Chenyi Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260429072851.3004430-1-chenyi.qiang@intel.com \
    --to=chenyi.qiang@intel.com \
    --cc=chao.gao@intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox