From: Vipin Sharma <vipinsh@google.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: David Matlack <dmatlack@google.com>,
Alex Williamson <alex@shazbot.org>,
Josh Hilke <jrhilke@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/8] vfio: selftests: Add -Wall and -Werror to the Makefile
Date: Tue, 12 May 2026 15:25:44 -0700 [thread overview]
Message-ID: <20260512221637.GA3046123.vipinsh@google.com> (raw)
In-Reply-To: <20260505212838.1698034-2-rananta@google.com>
On Tue, May 05, 2026 at 09:28:31PM +0000, Raghavendra Rao Ananta wrote:
> Add the compiler flags, -Wall and -Werror, to catch all the build
> warnings and flag them as a build error, respectively. This is to
> ensure that no obvious programmer errors are introduced. We can
> add -Wno-* flags in the future to ignore specific warnings as necesasry.
>
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> Reviewed-by: David Matlack <dmatlack@google.com>
> ---
> tools/testing/selftests/vfio/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> index 0684932d91bfc..e26917ee169c5 100644
> --- a/tools/testing/selftests/vfio/Makefile
> +++ b/tools/testing/selftests/vfio/Makefile
> @@ -23,6 +23,7 @@ include lib/libvfio.mk
>
> CFLAGS += -I$(top_srcdir)/tools/include
> CFLAGS += -MD
> +CFLAGS += -Wall -Werror
> CFLAGS += $(EXTRA_CFLAGS)
>
> LDFLAGS += -pthread
> --
> 2.54.0.545.g6539524ca2-goog
>
Reviewed-by: Vipin Sharma <vipinsh@google.com>
next prev parent reply other threads:[~2026-05-12 22:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 21:28 [PATCH v8 0/8] vfio: selftest: Add SR-IOV UAPI test Raghavendra Rao Ananta
2026-05-05 21:28 ` [PATCH v8 1/8] vfio: selftests: Add -Wall and -Werror to the Makefile Raghavendra Rao Ananta
2026-05-12 22:25 ` Vipin Sharma [this message]
2026-05-05 21:28 ` [PATCH v8 2/8] vfio: selftests: Introduce snprintf_assert() Raghavendra Rao Ananta
2026-05-12 22:26 ` Vipin Sharma
2026-05-05 21:28 ` [PATCH v8 3/8] vfio: selftests: Introduce a sysfs lib Raghavendra Rao Ananta
2026-05-12 22:28 ` Vipin Sharma
2026-05-05 21:28 ` [PATCH v8 4/8] vfio: selftests: Extend container/iommufd setup for passing vf_token Raghavendra Rao Ananta
2026-05-12 22:29 ` Vipin Sharma
2026-05-05 21:28 ` [PATCH v8 5/8] vfio: selftests: Expose more vfio_pci_device functions Raghavendra Rao Ananta
2026-05-12 22:29 ` Vipin Sharma
2026-05-05 21:28 ` [PATCH v8 6/8] vfio: selftests: Add helper to set/override a vf_token Raghavendra Rao Ananta
2026-05-12 22:30 ` Vipin Sharma
2026-05-05 21:28 ` [PATCH v8 7/8] vfio: selftests: Add helpers to alloc/free vfio_pci_device Raghavendra Rao Ananta
2026-05-12 22:30 ` Vipin Sharma
2026-05-05 21:28 ` [PATCH v8 8/8] vfio: selftests: Add tests to validate SR-IOV UAPI Raghavendra Rao Ananta
2026-05-12 22:31 ` Vipin Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512221637.GA3046123.vipinsh@google.com \
--to=vipinsh@google.com \
--cc=alex@shazbot.org \
--cc=dmatlack@google.com \
--cc=jrhilke@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rananta@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox