Re: [PATCH v3 40/40] KVM: x86: Move a pile of stuff from kvm_host.h => x86.h

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Several x86 KVM-internal declarations and definitions were unintentionally left in `kvm_host.h` despite the commit's goal to move them to `x86.h`.
--

commit 6fbb37590b9a07586090f255933e9452d592518d
Author: Sean Christopherson <seanjc@google.com>

KVM: x86: Move a pile of stuff from kvm_host.h => x86.h

Move the majority of remaining KVM-internal declarations and defines in
kvm_host.h to x86.h, so that kvm_host.h only holds structure and function
definitions that need to be visible to arch-neutral KVM.

> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index a3c1ff784e5c0..4efad65e53e24 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h

[ ... ]

> @@ -2326,11 +2154,6 @@ static inline unsigned long read_msr(unsigned long msr)
>  }
>  #endif
>  
> -static inline void kvm_inject_gp(struct kvm_vcpu *vcpu, u32 error_code)
> -{
> -	kvm_queue_exception_e(vcpu, GP_VECTOR, error_code);
> -}
> -
>  #define TSS_IOPB_BASE_OFFSET 0x66
>  #define TSS_BASE_SIZE 0x68
>  #define TSS_IOPB_SIZE (65536 / 8)
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Medium]
The commit message notes that any "misses" are likely unintentional. Should
TSS_IOPB_BASE_OFFSET and related constants also be moved to x86.h?

There are a few other x86-specific definitions still left in this file that
might have been missed, such as struct kvm_host_values (earlier in the file).

> @@ -2361,16 +2184,6 @@ enum {
>  #endif
>  
>  int kvm_arch_interrupt_allowed(struct kvm_vcpu *vcpu);
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Medium]
Similarly, should kvm_arch_interrupt_allowed() and the preceding enum
containing TASK_SWITCH_CALL also be moved to x86.h?

> -void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event);
> -

[ ... ]

> @@ -2382,14 +2195,6 @@ void kvm_arch_async_page_present_queued(struct kvm_vcpu *vcpu);
>  bool kvm_arch_can_dequeue_async_page_present(struct kvm_vcpu *vcpu);
>  extern bool kvm_find_async_pf_gfn(struct kvm_vcpu *vcpu, gfn_t gfn);
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[Severity: Medium]
Are kvm_find_async_pf_gfn() and the other async page fault prototypes missed
here as well?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260529222223.870923-1-seanjc@google.com?part=40