Re: [PATCH] tools/include/linux/types.h: add ulong typedef for musl compatibility

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding `ulong` typedef to `tools/include/linux/types.h` causes a `-Werror=redundant-decls` build failure in host tools like `perf`.
--

commit 88e8d7a9a4205d14733be0e5978d3a32589a15e0
Author: Hisam Mehboob <hisamshar@gmail.com>

tools/include/linux/types.h: add ulong typedef for musl compatibility

This commit adds a ulong typedef to tools/include/linux/types.h to fix build
failures in KVM selftests when using the musl libc.

> diff --git a/tools/include/linux/types.h b/tools/include/linux/types.h
> index d41f8a261bce8..ccc90dd4baeb2 100644
> --- a/tools/include/linux/types.h
> +++ b/tools/include/linux/types.h
> @@ -42,6 +42,7 @@ typedef __s16 s16;
>  typedef __u8  u8;
>  typedef __s8  s8;
>  
> +typedef unsigned long		ulong;

[Severity: Low]
Will this unconditional typedef cause a build failure in other host tools 
like perf?

Because glibc and musl <sys/types.h> also provide a ulong typedef, adding
this here without guards triggers a -Werror=redundant-decls build failure
in tools like perf, which compile with -Wredundant-decls (via EXTRA_WARNINGS
in tools/scripts/Makefile.include) alongside -Werror.

>  typedef unsigned long long	ullong;
>  
>  #ifdef __CHECKER__

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260531144934.403888-3-hisamshar@gmail.com?part=1