Re: [PATCH v7 05/20] KVM: selftests: Seed libc's RNG before using it to generate a seed for KVM's pRNG

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `<time.h>` inclusion causes an implicit function declaration of `time()`.
--

commit 3749f42be6b5df3b7d863a819171920d1f5980cc
Author: Sean Christopherson <seanjc@google.com>

KVM: selftests: Seed libc's RNG before using it to generate a seed for KVM's pRNG

This commit updates the KVM selftests initialization to seed the RNG used
by random() with the current time. This ensures a different seed is used
in each test run instead of using the same static seed.

> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 1016865d3f7a2..2e08d9fcefc77 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -2284,6 +2284,7 @@ void __attribute((constructor)) kvm_selftest_init(void)
>  	sigaction(SIGILL, &sig_sa, NULL);
>  	sigaction(SIGFPE, &sig_sa, NULL);
>  
> +	srandom(time(0));

[Severity: Low]
Does this file need to explicitly include <time.h>?

While it might compile cleanly on standard glibc environments due to
transitive inclusions, using time() without explicitly including <time.h>
can cause an implicit function declaration warning or error on stricter
build environments like musl.

>  	kvm_seed_rng(random());
>  
>  	kvm_selftest_arch_init();

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260613002031.745413-1-seanjc@google.com?part=5