Re: [PATCH v11 2/4] dma-buf: add optional get_pci_tph() callback

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The kernel-doc comment references a non-existent callback `move_notify` in `struct dma_buf_attach_ops`.
--

commit 335ebd67b3a2610991185474a464ea3b3511fff0
Author: Zhiping Zhang <zhipingz@meta.com>
Subject: dma-buf: add optional get_pci_tph() callback

This commit adds an optional get_pci_tph callback to dma_buf_ops and a 
wrapper function dma_buf_get_pci_tph(). This allows importers to retrieve 
PCIe TLP Processing Hints (TPH) from the exporter to emit matching hints on 
outbound TLPs.

> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c

[ ... ]

> + * The returned steering tag and processing hint are only valid until the
> + * exporter invalidates the current mapping (signalled to the importer via
> + * &dma_buf_attach_ops.move_notify). Importers must re-query after a new

[Severity: Low]
This isn't a bug, but should this kernel-doc reference invalidate_mappings 
instead of move_notify? There does not appear to be a move_notify callback 
defined in struct dma_buf_attach_ops.

> + * mapping is established following invalidation.
> + */
> +int dma_buf_get_pci_tph(struct dma_buf *dmabuf, bool extended,
> +			u16 *steering_tag, u8 *ph)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702181025.2694961-1-zhipingz@meta.com?part=2